Skip to contentSkip to conversation

S5PC110: Add OneNAND interrupt number

PATCH New Kyungmin Park 3 participants 4 messages Jul 27, 2010 – Aug 5, 2010

Subsystems (4)
Arm (32-bit) Arm sub-architectures Memory technology devices (MTD) Arm Samsung Exynos
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/1 S5PC110: Add OneNAND interrupt number

To use OneNAND interrupt at drivers, also extend DMA address to cover fully.

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/mach-s5pv210/dev-onenand.c +6 -1
index 34997b7..f8ede33 100644
@@ -27,9 +27,14 @@ static struct resource s5pc110_onenand_resources[] = {
 	},
 	[1] = {
 		.start	= S5PC110_PA_ONENAND_DMA,
-		.end	= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
+		.end	= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
 		.flags	= IORESOURCE_MEM,
 	},
+	[2] = {
+		.start	= IRQ_ONENAND_AUDI,
+		.end	= IRQ_ONENAND_AUDI,
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 struct platform_device s5pc110_device_onenand = {
#1 lore raw

PATCH 1/1 S5PC110: Add OneNAND interrupt number

Quoted 12 lines · Kyungmin Park

To use OneNAND interrupt at drivers, also extend DMA address to cover fully.

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/mach-s5pv210/dev-onenand.c +0 -0
index 34997b7..f8ede33 100644
@@ -27,9 +27,14 @@ static struct resource s5pc110_onenand_resources[] = {
 	},
 	[1] = {
 		.start	= S5PC110_PA_ONENAND_DMA,

arch/arm/mach-s5pv210/dev-onenand.c static struct resource s5pc110_onenand_resources[] = { · line 38

Quoted 10 lines
arch/arm/mach-s5pv210/dev-onenand.c +6 -1
-		.end	= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
+		.end	= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
 		.flags	= IORESOURCE_MEM,
 	},
+	[2] = {
+		.start	= IRQ_ONENAND_AUDI,
+		.end	= IRQ_ONENAND_AUDI,
+		.flags	= IORESOURCE_IRQ,
+	},
 };

You do not expect this to go through the MTD tree, right?

Signature · 2 lines
Best Regards,
Artem Bityutskiy (????? ????????)
author
#2 lore raw

PATCH 1/1 S5PC110: Add OneNAND interrupt number

Quoted 17 lines · Artem Bityutskiy
Quoted 16 lines · Kyungmin Park

To use OneNAND interrupt at drivers, also extend DMA address to cover fully.

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/mach-s5pv210/dev-onenand.c +1 -1
index 34997b7..f8ede33 100644
@@ -27,9 +27,14 @@ static struct resource s5pc110_onenand_resources[] = {
 ? ? ? },
 ? ? ? [1] = {
 ? ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA,
- ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
+ ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
 ? ? ? ? ? ? ? .flags ?= IORESOURCE_MEM,
 ? ? ? },
Quoted 8 lines

arch/arm/mach-s5pv210/dev-onenand.c static struct resource s5pc110_onenand_resources[] = { · line 38

Quoted 6 lines
arch/arm/mach-s5pv210/dev-onenand.c +5 -0
+ ? ? [2] = {
+ ? ? ? ? ? ? .start ?= IRQ_ONENAND_AUDI,
+ ? ? ? ? ? ? .end ? ?= IRQ_ONENAND_AUDI,
+ ? ? ? ? ? ? .flags ?= IORESOURCE_IRQ,
+ ? ? },
 ?};

You do not expect this to go through the MTD tree, right?

After this patch, I did a lot of works but failed to persuade the Kukjin. At this time. it's okay only this patch to mtd tree.

Kukjin, are you okay?
Since It's only affect the c110.

Thank you,
Kyungmin Park

#3 lore raw

PATCH 1/1 S5PC110: Add OneNAND interrupt number

Quoted 2 lines · Kyungmin Park

On Thu, Aug 5, 2010 at 1:32 PM, Artem Bityutskiy <[email protected]>

Quoted 2 lines · wrote:
Quoted 2 lines · Kyungmin Park
Quoted 1 line

To use OneNAND interrupt at drivers, also extend DMA address to cover

fully.

Quoted 9 lines
Quoted 4 lines

arch/arm/mach-

Quoted 4 lines
Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/mach- renamed from arch/arm/mach-s5pv210/dev-onenand.c +0 -0

s5pv210/dev-onenand.c

Quoted 4 lines

arch/arm/mach-s5pv210/dev-onenand.c static struct resource s5pc110_onenand_resources[] =

Quoted 4 lines

index 34997b7..f8ede33 100644

arch/arm/mach-s5pv210/dev-onenand.c +0 -0
@@ -27,9 +27,14 @@ static struct resource s5pc110_onenand_resources[] =

{

Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
arch/arm/mach-s5pv210/dev-onenand.c +6 -1
 ? ? ? },
 ? ? ? [1] = {
 ? ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA,
- ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
+ ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
 ? ? ? ? ? ? ? .flags ?= IORESOURCE_MEM,
 ? ? ? },
+ ? ? [2] = {
+ ? ? ? ? ? ? .start ?= IRQ_ONENAND_AUDI,
+ ? ? ? ? ? ? .end ? ?= IRQ_ONENAND_AUDI,
+ ? ? ? ? ? ? .flags ?= IORESOURCE_IRQ,
+ ? ? },
 ?};
Quoted 3 lines
Quoted 1 line

You do not expect this to go through the MTD tree, right?

After this patch, I did a lot of works but failed to persuade the Kukjin.

Maybe I missed this single patch...looks ok itself.

Quoted 2 lines

At this time. it's okay only this patch to mtd tree.

I think, it's better this patch is going to upstream through ARM tree.

Artem, I will apply in my tree. Thanks.

Quoted 3 lines

Kukjin, are you okay?
Since It's only affect the c110.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.