Skip to contentSkip to conversation

cred - synchronize rcu before releasing cred

PATCH In review Jiri Olsa 2 participants 4 messages Jun 25, 2010 – Jul 27, 2010 Proc filesystem

lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 cred - synchronize rcu before releasing cred

BZ 591015 - kernel BUG at kernel/cred.c:168
https://bugzilla.redhat.com/show_bug.cgi?id=591015

Above bugzilla reported bug during the releasing of old cred structure.

There is reproducer attached to the bugzilla.

The issue is caused by releasing old cred struct while other kernel path might be still using it. This leads to cred->usage inconsistency inside the __put_cred and triggering the bug.

Following kernel paths are affected:

The CPU1 path is setting the new groups creds.
The CPU2 path is cat /proc/PID/status

CPU 1 CPU 2

sys_setgroups proc_pid_status
set_current_groups task_state

    commit_creds                       rcu_read_lock
      put_cred                         ...
        __put_cred                     get_cred
          BUG_ON(usage != 0)           ...

rcu_read_unlock

If __put_cred got executed during the CPU2 holding the reference the BUG_ON inside __put_cred is trigered.

I think there's no need to get the cred refference as long as the 'cred' handling stays inside the rcu_read_lock block.

And the condition of __task_cred 'make sure task doesn't go away', is done by proc_single_show as this is the proc file.

wbr,
jirka

---

fs/proc/array.c +2 -3
index 9b58d38..ac3b3a4 100644
@@ -176,7 +176,7 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
 		if (tracer)
 			tpid = task_pid_nr_ns(tracer, ns);
 	}
-	cred = get_cred((struct cred *) __task_cred(p));
+	cred = __task_cred(p);
 	seq_printf(m,
 		"State:\t%s\n"
 		"Tgid:\t%d\n"
@@ -199,15 +199,14 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
 		"FDSize:\t%d\n"
 		"Groups:\t",
 		fdt ? fdt->max_fds : 0);
-	rcu_read_unlock();
 
 	group_info = cred->group_info;
 	task_unlock(p);
 
 	for (g = 0; g < min(group_info->ngroups, NGROUPS_SMALL); g++)
 		seq_printf(m, "%d ", GROUP_AT(group_info, g));
-	put_cred(cred);
 
+	rcu_read_unlock();
 	seq_printf(m, "\n");
 }
 
author
#1 lore raw

hi,
any feedback?

jirka

Quoted 76 lines · Jiri Olsa

BZ 591015 - kernel BUG at kernel/cred.c:168
https://bugzilla.redhat.com/show_bug.cgi?id=591015

Above bugzilla reported bug during the releasing of old cred structure.

There is reproducer attached to the bugzilla.

The issue is caused by releasing old cred struct while other kernel path might be still using it. This leads to cred->usage inconsistency inside the __put_cred and triggering the bug.

Following kernel paths are affected:

The CPU1 path is setting the new groups creds.
The CPU2 path is cat /proc/PID/status

CPU 1 CPU 2

sys_setgroups proc_pid_status
set_current_groups task_state

    commit_creds                       rcu_read_lock
      put_cred                         ...
        __put_cred                     get_cred
          BUG_ON(usage != 0)           ...

rcu_read_unlock

If __put_cred got executed during the CPU2 holding the reference the BUG_ON inside __put_cred is trigered.

I think there's no need to get the cred refference as long as the 'cred' handling stays inside the rcu_read_lock block.

And the condition of __task_cred 'make sure task doesn't go away', is done by proc_single_show as this is the proc file.

wbr,
jirka

---

fs/proc/array.c +2 -3
index 9b58d38..ac3b3a4 100644
@@ -176,7 +176,7 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
 		if (tracer)
 			tpid = task_pid_nr_ns(tracer, ns);
 	}
-	cred = get_cred((struct cred *) __task_cred(p));
+	cred = __task_cred(p);
 	seq_printf(m,
 		"State:\t%s\n"
 		"Tgid:\t%d\n"
@@ -199,15 +199,14 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
 		"FDSize:\t%d\n"
 		"Groups:\t",
 		fdt ? fdt->max_fds : 0);
-	rcu_read_unlock();
 
 	group_info = cred->group_info;
 	task_unlock(p);
 
 	for (g = 0; g < min(group_info->ngroups, NGROUPS_SMALL); g++)
 		seq_printf(m, "%d ", GROUP_AT(group_info, g));
-	put_cred(cred);
 
+	rcu_read_unlock();
 	seq_printf(m, "\n");
 }
 
author
#2 lore raw

Re: [PATCH] cred - BUG: synchronize rcu before releasing cred

hi,
any feedback?

jirka

Quoted 86 lines · Jiri Olsa

hi,
any feedback?

jirka

Quoted 66 lines · Jiri Olsa

BZ 591015 - kernel BUG at kernel/cred.c:168
https://bugzilla.redhat.com/show_bug.cgi?id=591015

Above bugzilla reported bug during the releasing of old cred structure.

There is reproducer attached to the bugzilla.

The issue is caused by releasing old cred struct while other kernel path might be still using it. This leads to cred->usage inconsistency inside the __put_cred and triggering the bug.

Following kernel paths are affected:

The CPU1 path is setting the new groups creds.
The CPU2 path is cat /proc/PID/status

CPU 1 CPU 2

sys_setgroups proc_pid_status
set_current_groups task_state

    commit_creds                       rcu_read_lock
      put_cred                         ...
        __put_cred                     get_cred
          BUG_ON(usage != 0)           ...

rcu_read_unlock

If __put_cred got executed during the CPU2 holding the reference the BUG_ON inside __put_cred is trigered.

I think there's no need to get the cred refference as long as the 'cred' handling stays inside the rcu_read_lock block.

And the condition of __task_cred 'make sure task doesn't go away', is done by proc_single_show as this is the proc file.

wbr,
jirka

---

fs/proc/array.c +1 -2
index 9b58d38..ac3b3a4 100644
@@ -176,7 +176,7 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
 		if (tracer)
 			tpid = task_pid_nr_ns(tracer, ns);
 	}
-	cred = get_cred((struct cred *) __task_cred(p));
+	cred = __task_cred(p);
 	seq_printf(m,
 		"State:\t%s\n"
 		"Tgid:\t%d\n"
@@ -199,15 +199,14 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
 		"FDSize:\t%d\n"
 		"Groups:\t",
 		fdt ? fdt->max_fds : 0);
-	rcu_read_unlock();
 
 	group_info = cred->group_info;

fs/proc/array.c static inline void task_state(struct seq_file *m, struct pid_namespace *ns, · line 212

Quoted 10 lines
fs/proc/array.c +1 -1
 	task_unlock(p);
 
 	for (g = 0; g < min(group_info->ngroups, NGROUPS_SMALL); g++)
 		seq_printf(m, "%d ", GROUP_AT(group_info, g));
-	put_cred(cred);
 
+	rcu_read_unlock();
 	seq_printf(m, "\n");
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

Re: [PATCH] cred - BUG: synchronize rcu before releasing cred

Quoted 1 line · Jiri Olsa

any feedback?

Guess no one's objecting. Post it to Linus then.

David