Skip to contentSkip to conversation

e1000e: 82577/82578 PHY register access issues

PATCH Applied Jeff Kirsher 2 participants 4 messages Jul 27, 2010 – Aug 3, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Jeff Kirsher

author
#0 lore raw

PATCH 1/1 e1000e: 82577/82578 PHY register access issues

From: Bruce Allan <[email protected]>

The MAC-PHY interconnect on 82577/82578 uses a power management feature (called K1) which must be disabled when in 1Gbps due to a hardware issue on these parts. The #define bit setting used to enable/disable K1 is incorrect and can cause PHY register accesses to stop working altogether until the next device reset. This patch sets the register correctly.

This issue is present in kernels since 2.6.32.

CC [email protected]
Signed-off-by Bruce Allan <[email protected]>
Tested-by Jeff Pieper <[email protected]>
Signed-off-by Jeff Kirsher <[email protected]>

---

 drivers/net/e1000e/hw.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/e1000e/hw.h +1 -1
index 5d1220d..664ed58 100644
@@ -308,7 +308,7 @@ enum e1e_registers {
 #define E1000_KMRNCTRLSTA_INBAND_PARAM	0x9    /* Kumeran InBand Parameters */
 #define E1000_KMRNCTRLSTA_DIAG_NELPBK	0x1000 /* Nearend Loopback mode */
 #define E1000_KMRNCTRLSTA_K1_CONFIG	0x7
-#define E1000_KMRNCTRLSTA_K1_ENABLE	0x140E
+#define E1000_KMRNCTRLSTA_K1_ENABLE	0x0002
 #define E1000_KMRNCTRLSTA_K1_DISABLE	0x1400
 
 #define IFE_PHY_EXTENDED_STATUS_CONTROL	0x10
maintainer Applied
#1 lore raw

From: Jeff Kirsher <[email protected]>
Date: Tue, 27 Jul 2010 15:28:46 -0700

Quoted 8 lines

From: Bruce Allan <[email protected]>

The MAC-PHY interconnect on 82577/82578 uses a power management feature (called K1) which must be disabled when in 1Gbps due to a hardware issue on these parts. The #define bit setting used to enable/disable K1 is incorrect and can cause PHY register accesses to stop working altogether until the next device reset. This patch sets the register correctly.

Quoted 6 lines

This issue is present in kernels since 2.6.32.

CC [email protected]
Signed-off-by Bruce Allan <[email protected]>
Tested-by Jeff Pieper <[email protected]>
Signed-off-by Jeff Kirsher <[email protected]>

Applied, thanks.

author
#2 lore raw
Quoted 13 lines · David Miller

From: Jeff Kirsher <[email protected]>
Date: Tue, 27 Jul 2010 15:28:46 -0700

Quoted 10 lines

From: Bruce Allan <[email protected]>

The MAC-PHY interconnect on 82577/82578 uses a power management feature (called K1) which must be disabled when in 1Gbps due to a hardware issue on these parts.  The #define bit setting used to enable/disable K1 is incorrect and can cause PHY register accesses to stop working altogether until the next device reset.  This patch sets the register correctly.

This issue is present in kernels since 2.6.32.

Quoted 7 lines
Quoted 4 lines
CC [email protected]
Signed-off-by Bruce Allan <[email protected]>
Tested-by Jeff Pieper <[email protected]>
Signed-off-by Jeff Kirsher <[email protected]>

Applied, thanks.
--

Dave,
Have you sync'd up your net-next-2.6 tree with net-2.6 tree? Because I do not see this change in the net-next-2.6 tree.

Signature · 2 lines
Cheers,
Jeff
maintainer
#3 lore raw

From: Jeff Kirsher <[email protected]>
Date: Mon, 2 Aug 2010 18:04:43 -0700

Quoted 2 lines

Have you sync'd up your net-next-2.6 tree with net-2.6 tree? Because I do not see this change in the net-next-2.6 tree.

No, I plan to do that tonight or tomorrow.