Skip to contentSkip to conversation

video/w100fb: ignore void return value / fix build failure

PATCH In review Peter Hüwe 2 participants 2 messages Jul 28, 2010

Subsystems (2)
Kernel janitors Framebuffer layer
lore
Share & tools
lore

Peter Hüwe

author
#0 lore raw

PATCH 1/1 video/w100fb: ignore void return value / fix build failure

From: Peter Huewe <[email protected]>

This patch fixes a build failure [1] (error: void value not ignored as it ought to be) by removing an assignment of a void return value. The functionality of the code is not changed.

Signed-off-by Peter Huewe <[email protected]>

---
KernelVersion: linux-next-20100728
References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/2980912/

 drivers/video/w100fb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/w100fb.c +2 -2
index e66b8b1..d8b12c3 100644
@@ -858,9 +858,9 @@ unsigned long w100fb_gpio_read(int port)
 void w100fb_gpio_write(int port, unsigned long value)
 {
 	if (port=W100_GPIO_PORT_A)
-		value = writel(value, remapped_regs + mmGPIO_DATA);
+		writel(value, remapped_regs + mmGPIO_DATA);
 	else
-		value = writel(value, remapped_regs + mmGPIO_DATA2);
+		writel(value, remapped_regs + mmGPIO_DATA2);
 }
 EXPORT_SYMBOL(w100fb_gpio_read);
 EXPORT_SYMBOL(w100fb_gpio_write);
Signature · 1 line
1.7.1
#1 lore raw

Am 28.07.2010 20:29, schrieb Peter Hüwe:

Quoted 7 lines

From: Peter Huewe <[email protected]>

This patch fixes a build failure [1] (error: void value not ignored as it ought to be) by removing an assignment of a void return value. The functionality of the code is not changed.

Signed-off-by Peter Huewe <[email protected]>
Ached-by Henrik Kretzschmar <[email protected]>
Quoted 14 lines

---
KernelVersion: linux-next-20100728
References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/2980912/

 drivers/video/w100fb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/w100fb.c +0 -0
index e66b8b1..d8b12c3 100644
@@ -858,9 +858,9 @@ unsigned long w100fb_gpio_read(int port)
 void w100fb_gpio_write(int port, unsigned long value)

drivers/video/w100fb.c unsigned long w100fb_gpio_read(int port) · line 866

Quoted 10 lines
drivers/video/w100fb.c +2 -2
 {
 	if (port=W100_GPIO_PORT_A)
-		value = writel(value, remapped_regs + mmGPIO_DATA);
+		writel(value, remapped_regs + mmGPIO_DATA);
 	else
-		value = writel(value, remapped_regs + mmGPIO_DATA2);
+		writel(value, remapped_regs + mmGPIO_DATA2);
 }
 EXPORT_SYMBOL(w100fb_gpio_read);
 EXPORT_SYMBOL(w100fb_gpio_write);

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html