Skip to contentSkip to conversation

mflash: use common cmd_usage function

PATCH New Mike Frysinger 3 participants 5 messages Jul 23, 2010 – Aug 8, 2010

lore
Share & tools
lore

Mike Frysinger

author
#0 lore raw

PATCH 1/1 mflash: use common cmd_usage function

Signed-off-by Mike Frysinger <[email protected]>

---
note: i have no target that uses it, so i havent compile tested this.
but the change is straight forward enough ...

 common/cmd_mgdisk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
common/cmd_mgdisk.c +1 -1
index 3ba62f6..03bed88 100644
@@ -54,7 +54,7 @@ int do_mg_disk_cmd (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 			return 1;
 		break;
 	default:
-		printf("Usage:\n%s\n", cmdtp->usage);
+		cmd_usage(cmdtp);
 		return 1;
 	}
 	return 0;
Signature · 1 line
1.7.2
#1 lore raw

PATCH 1/1 mflash: use common cmd_usage function

Hi Mike,

Quoted 13 lines
Signed-off-by Mike Frysinger <[email protected]>

---
note: i have no target that uses it, so i havent compile tested this.
but the change is straight forward enough ...

 common/cmd_mgdisk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
common/cmd_mgdisk.c +0 -0
index 3ba62f6..03bed88 100644

common/cmd_mgdisk.c int do_mg_disk_cmd (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) · line 60

Quoted 8 lines
common/cmd_mgdisk.c +1 -1
@@ -54,7 +54,7 @@ int do_mg_disk_cmd (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 			return 1;
 		break;
 	default:
-		printf("Usage:\n%s\n", cmdtp->usage);
+		cmd_usage(cmdtp);
 		return 1;
 	}
 	return 0;

With commit 47e26b1bf91ddef69f4a3892815c857db094cef9 [cmd_usage():
simplify return code handling] I suppose this should be directly changed to a return cmd_usage.

This applies to one other patch you sent.

Cheers
Detlev

Signature · 7 lines
Those who would give up essential liberty to purchase a little
temporary safety, deserve neither liberty nor safety.
                                     -- Benjamin Franklin
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
author
#2 lore raw

PATCH 1/1 mflash: use common cmd_usage function

Quoted 13 lines · On Thursday, July 29, 2010 07:28:13 Detlev Zundel wrote:
Quoted 13 lines
common/cmd_mgdisk.c +1 -1
@@ -54,7 +54,7 @@ int do_mg_disk_cmd (cmd_tbl_t *cmdtp, int flag, int
 argc, char *argv[])
 
 			return 1;
 
 		break;
 
 	default:
-		printf("Usage:\n%s\n", cmdtp->usage);
+		cmd_usage(cmdtp);
Quoted 8 lines

common/cmd_mgdisk.c int do_mg_disk_cmd (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) · line 60

Quoted 4 lines
common/cmd_mgdisk.c +0 -0
 		return 1;
 
 	}
 	return 0;

With commit 47e26b1bf91ddef69f4a3892815c857db094cef9 [cmd_usage():
simplify return code handling] I suppose this should be directly changed to a return cmd_usage.

hadnt noticed that. ill send updated patches; thanks.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100729/317d7522/attachment.pgp

author
#3 lore raw

PATCH v2 1/1 mflash: use common cmd_usage function

In reply to Mike Frysinger
Signed-off-by Mike Frysinger <[email protected]>

---
v2
- tail into cmd_usage() as pointed out by Detlev Zundel

 common/cmd_mgdisk.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
common/cmd_mgdisk.c +1 -2
index c2d5217..51c994b 100644
@@ -54,8 +54,7 @@ int do_mg_disk_cmd (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 			return 1;
 		break;
 	default:
-		printf("Usage:\n%s\n", cmdtp->usage);
-		return 1;
+		return cmd_usage(cmdtp);
 	}
 	return 0;
 }
Signature · 1 line
1.7.2
Applied
#4 lore raw

PATCH v2 1/1 mflash: use common cmd_usage function

Dear Mike Frysinger,

Quoted 7 lines · In message <[email protected]> you wrote:
Signed-off-by Mike Frysinger <[email protected]>

---
v2
- tail into cmd_usage() as pointed out by Detlev Zundel

 common/cmd_mgdisk.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Where a calculator on the ENIAC is equipped with 18,000 vacuum  tubes
and  weighs  30  tons,  computers  in  the future may have only 1,000
vacuum tubes and weigh only 1/2 tons. - Popular Mechanics, March 1949