Skip to contentSkip to conversation

drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.

PATCH In review Henrique Camargo 3 participants 5 messages Jul 29, 2010 – Aug 3, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Henrique Camargo

author
#0 lore raw

PATCH 1/1 drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.

From: Henrique Camargo

Fixes a typo from "dev" to "ndev" that caused compilation errors.

Signed-off-by Henrique Camargo <[email protected]>
---
 drivers/net/davinci_emac.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/davinci_emac.c +2 -2
index 25e14d2..b89b7bf 100644
@@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
        struct net_device *ndev = priv->ndev;
        u32 cnt;
 
-       if (unlikely(num_tokens && netif_queue_stopped(dev)))
-               netif_start_queue(dev);
+       if (unlikely(num_tokens && netif_queue_stopped(ndev)))
+               netif_start_queue(ndev);
        for (cnt = 0; cnt < num_tokens; cnt++) {
                struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
                if (skb == NULL)
Signature · 1 line
1.7.0.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Henrique Camargo

From: Henrique Camargo

Fixes a typo from "dev" to "ndev" that caused compilation errors.

Signed-off-by Henrique Camargo <[email protected]>

Thanks,

Reviewed-by Kulikov Vasiliy <[email protected]>

Also I've checked my other patches of removing private stats, the rest are ok.

Quoted 21 lines
---
 drivers/net/davinci_emac.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/davinci_emac.c +2 -2
index 25e14d2..b89b7bf 100644
@@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
        struct net_device *ndev = priv->ndev;
        u32 cnt;
 
-       if (unlikely(num_tokens && netif_queue_stopped(dev)))
-               netif_start_queue(dev);
+       if (unlikely(num_tokens && netif_queue_stopped(ndev)))
+               netif_start_queue(ndev);
        for (cnt = 0; cnt < num_tokens; cnt++) {
                struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
                if (skb == NULL)
Signature · 1 line
1.7.0.4
maintainer
#2 lore raw
In reply to Henrique Camargo

From: Henrique Camargo <[email protected]>
Date: Thu, 29 Jul 2010 12:51:49 -0300

Quoted 3 lines

From: Henrique Camargo

From lines need valid email addresses. But in this case since you

are the person who wrote the patch, adding another From: tag in the message body is superfluous and you can just omit it.

drivers/net/davinci_emac.c static int emac_net_tx_complete(struct emac_priv *priv, · line 1186

Quoted 12 lines
drivers/net/davinci_emac.c +2 -2
index 25e14d2..b89b7bf 100644
@@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
        struct net_device *ndev = priv->ndev;
        u32 cnt;
 
-       if (unlikely(num_tokens && netif_queue_stopped(dev)))
-               netif_start_queue(dev);
+       if (unlikely(num_tokens && netif_queue_stopped(ndev)))
+               netif_start_queue(ndev);

Your patch is corrupted, tab characters have been turned into spaces by your email client.

This makes your patch unusable.

Please fix up these errors and resubmit your patch.

Thank you.

author
#3 lore raw

PATCH 1/1 Fixes a typo from "dev" to "ndev"

The typo was causing compilation errors since "dev" was not defined.

Signed-off-by Henrique Camargo <[email protected]>
---
 drivers/net/davinci_emac.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/davinci_emac.c +2 -2
index 25e14d2..b89b7bf 100644
@@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
 	struct net_device *ndev = priv->ndev;
 	u32 cnt;
 
-	if (unlikely(num_tokens && netif_queue_stopped(dev)))
-		netif_start_queue(dev);
+	if (unlikely(num_tokens && netif_queue_stopped(ndev)))
+		netif_start_queue(ndev);
 	for (cnt = 0; cnt < num_tokens; cnt++) {
 		struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
 		if (skb == NULL)
Signature · 1 line
1.7.0.4