S5PV310: Add Samsung Mobile Reference Board support

PATCH New Kyungmin Park 2 participants 4 messages Jul 30, 2010 – Jul 31, 2010

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Kyungmin Park

author

2010-07-30 10:10 UTC #0 lore raw

PATCH 1/1 S5PV310: Add Samsung Mobile Reference Board support

From: Kyungmin Park <[email protected]>

Initial samsung mobile reference board support

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s5pv310/Kconfig          |    9 +++
 arch/arm/mach-s5pv310/Makefile         |    1 +
 arch/arm/mach-s5pv310/mach-universal.c |   86 ++++++++++++++++++++++++++++++++
 3 files changed, 96 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv310/mach-universal.c

arch/arm/mach-s5pv310/Kconfig +9 -0

index 24ef3cd..2fe8149 100644
@@ -23,4 +23,13 @@ config MACH_SMDKV310
 	select ARCH_SPARSEMEM_ENABLE
 	help
 	  Machine support for Samsung SMDKV310
+
+config MACH_UNIVERSAL
+	bool "Mobile Universal Board"
+	select CPU_S5PV310
+	select ARCH_SPARSEMEM_ENABLE
+	help
+	  Machine support for Samsung Mobile Universal Reference Board.
+	  S5PC210(MCP) is one of package option of S5PV310
+
 endif

arch/arm/mach-s5pv310/Makefile +1 -0

index 56e7693..5b52132 100644
@@ -22,3 +22,4 @@ obj-$(CONFIG_HOTPLUG_CPU)	+= hotplug.o
 # machine support
 
 obj-$(CONFIG_MACH_SMDKV310)	+= mach-smdkv310.o
+obj-$(CONFIG_MACH_UNIVERSAL)	+= mach-universal.o

arch/arm/mach-s5pv310/mach-universal.c new file +86 -0

86 lines not on this page · raw message

Signature · 1 line

1.5.3.3

Kukjin Kim

2010-07-31 03:08 UTC #1 lore raw

PATCH 1/1 S5PV310: Add Samsung Mobile Reference Board support

Quoted 6 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>
Initial samsung mobile reference board support
Signed-off-by Kyungmin Park <[email protected]>

Cc'ed Ben Dooks...again, please include Ben Dooks in Cc.

And it would be helpful to me for review if you could add patch version and changes.
It can help to avoid omission your new patch which has same name with previous one.

Quoted 13 lines

---
 arch/arm/mach-s5pv310/Kconfig          |    9 +++
 arch/arm/mach-s5pv310/Makefile         |    1 +
 arch/arm/mach-s5pv310/mach-universal.c |   86
++++++++++++++++++++++++++++++++
 3 files changed, 96 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv310/mach-universal.c

arch/arm/mach-s5pv310/Kconfig +0 -0

index 24ef3cd..2fe8149 100644

arch/arm/mach-s5pv310/Kconfig config MACH_SMDKV310 · line 27

Quoted 5 lines

arch/arm/mach-s5pv310/Kconfig +2 -0

@@ -23,4 +23,13 @@ config MACH_SMDKV310
 	select ARCH_SPARSEMEM_ENABLE
 	help
 	  Machine support for Samsung SMDKV310
+
+config MACH_UNIVERSAL

As I still asking, do you _really_ want to use 'UNIVERSAL' as the board(machine) name?

Review

Quoted 9 lines

arch/arm/mach-s5pv310/Kconfig +7 -0

+	bool "Mobile Universal Board"
+	select CPU_S5PV310
+	select ARCH_SPARSEMEM_ENABLE
+	help
+	  Machine support for Samsung Mobile Universal Reference Board.
+	  S5PC210(MCP) is one of package option of S5PV310
+
 endif

(quoted diff) +0 -0

b/arch/arm/mach-s5pv310/Makefile

Quoted 27 lines

index 56e7693..5b52132 100644

arch/arm/mach-s5pv310/Makefile +1 -0

@@ -22,3 +22,4 @@ obj-$(CONFIG_HOTPLUG_CPU)	+= hotplug.o
 # machine support
 
 obj-$(CONFIG_MACH_SMDKV310)	+= mach-smdkv310.o
+obj-$(CONFIG_MACH_UNIVERSAL)	+= mach-universal.o

arch/arm/mach- renamed from arch/arm/mach-s5pv310/mach-universal.c +0 -0

s5pv310/mach-universal.c
new file mode 100644
index 0000000..d22727f

arch/arm/mach-s5pv310/mach-universal.c new file +12 -0

@@ -0,0 +1,86 @@
+/* linux/arch/arm/mach-s5pv310/mach-universal.c
+ *
+ * Copyright (C) 2010 Samsung Electronics Co., Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>

arch/arm/mach-s5pv310/mach-universal.c line 22

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +10 -0

+#include <asm/mach-types.h>
+#include <asm/hardware/cache-l2x0.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv310.h>
+#include <plat/cpu.h>
+
+#include <mach/map.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers

Quoted 37 lines

arch/arm/mach-s5pv310/mach-universal.c new file +35 -0

+#define UNIVERSAL_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
+				 S3C2410_UCON_RXILEVEL |	\
+				 S3C2410_UCON_TXIRQMODE |	\
+				 S3C2410_UCON_RXIRQMODE |	\
+				 S3C2410_UCON_RXFIFO_TOI |	\
+				 S3C2443_UCON_RXERR_IRQEN)
+
+#define UNIVERSAL_ULCON_DEFAULT	S3C2410_LCON_CS8
+
+#define UNIVERSAL_UFCON_DEFAULT	(S3C2410_UFCON_FIFOMODE |	\
+				S5PV210_UFCON_TXTRIG256 |	\
+				S5PV210_UFCON_RXTRIG256)
+
+static struct s3c2410_uartcfg universal_uartcfgs[] __initdata = {
+	[0] = {
+		.hwport		= 0,
 
 
+		.ucon		= UNIVERSAL_UCON_DEFAULT,
+		.ulcon		= UNIVERSAL_ULCON_DEFAULT,
+		.ufcon		= UNIVERSAL_UFCON_DEFAULT,
+	},
+	[1] = {
+		.hwport		= 1,
+		.ucon		= UNIVERSAL_UCON_DEFAULT,
+		.ulcon		= UNIVERSAL_ULCON_DEFAULT,
+		.ufcon		= UNIVERSAL_UFCON_DEFAULT,
+	},
+	[2] = {
+		.hwport		= 2,
+		.ucon		= UNIVERSAL_UCON_DEFAULT,
+		.ulcon		= UNIVERSAL_ULCON_DEFAULT,
+		.ufcon		= UNIVERSAL_UFCON_DEFAULT,
+	},
+	[3] = {
+		.hwport		= 3,
+		.ucon		= UNIVERSAL_UCON_DEFAULT,

arch/arm/mach-s5pv310/mach-universal.c

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +10 -0

+		.ulcon		= UNIVERSAL_ULCON_DEFAULT,
+		.ufcon		= UNIVERSAL_UFCON_DEFAULT,
+	},
+};
+
+static void __init universal_map_io(void)
+{
+	s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+	s3c24xx_init_clocks(24000000);
+	s3c24xx_init_uarts(universal_uartcfgs,

ARRAY_SIZE(universal_uartcfgs));

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +10 -0

+}
+
+static void __init universal_machine_init(void)
+{
+#ifdef CONFIG_CACHE_L2X0
+	l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
+#endif
+}
+
+MACHINE_START(UNIVERSAL, "UNIVERSAL")

arch/arm/mach-s5pv310/mach-universal.c

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +9 -1

+	/* Maintainer: Kyungmin Park <[email protected]> */
+	.phys_io	= S3C_PA_UART & 0xfff00000,
+	.io_pg_offst	= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+	.boot_params	= S5P_PA_SDRAM + 0x100,
+	.init_irq	= s5pv310_init_irq,
+	.map_io		= universal_map_io,
+	.init_machine	= universal_machine_init,
+	.timer		= &s5pv310_timer,
+MACHINE_END
--

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kyungmin Park

author

2010-07-31 04:00 UTC #2 lore raw

PATCH 1/1 S5PV310: Add Samsung Mobile Reference Board support

Quoted 6 lines · Kukjin Kim

Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
Initial samsung mobile reference board support

Quoted 8 lines

Quoted 1 line
Signed-off-by Kyungmin Park <[email protected]>
Cc'ed Ben Dooks...again, please include Ben Dooks in Cc.
And it would be helpful to me for review if you could add patch version and changes.
It can help to avoid omission your new patch which has same name with previous one.

As I can't see the patch at your for-next I resend it.

Quoted 9 lines

Quoted 9 lines
---
?arch/arm/mach-s5pv310/Kconfig ? ? ? ? ?| ? ?9 +++
?arch/arm/mach-s5pv310/Makefile ? ? ? ? | ? ?1 +
?arch/arm/mach-s5pv310/mach-universal.c | ? 86
++++++++++++++++++++++++++++++++
?3 files changed, 96 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-s5pv310/mach-universal.c

Quoted 13 lines

arch/arm/mach-s5pv310/Kconfig config MACH_SMDKV310 · line 27
Quoted 10 lines
arch/arm/mach-s5pv310/Kconfig +0 -0
index 24ef3cd..2fe8149 100644
@@ -23,4 +23,13 @@ config MACH_SMDKV310
? ? ? select ARCH_SPARSEMEM_ENABLE
? ? ? help
? ? ? ? Machine support for Samsung SMDKV310
arch/arm/mach-s5pv310/Kconfig +2 -0
+
+config MACH_UNIVERSAL
As I still asking, do you _really_ want to use 'UNIVERSAL' as the board(machine) name?

Yes, it's called 'universal' and it's really universal board at here. I don't confuse the engineer who develop this board.
Maybe your engineers saw and hear the brief description about universal board.

Quoted 128 lines

Review

Quoted 10 lines

+ ? ? bool "Mobile Universal Board"
+ ? ? select CPU_S5PV310
+ ? ? select ARCH_SPARSEMEM_ENABLE
+ ? ? help
+ ? ? ? Machine support for Samsung Mobile Universal Reference Board.
+ ? ? ? S5PC210(MCP) is one of package option of S5PV310
+
?endif
(quoted diff) +0 -0

b/arch/arm/mach-s5pv310/Makefile

Quoted 27 lines

index 56e7693..5b52132 100644
arch/arm/mach-s5pv310/Makefile +0 -0
@@ -22,3 +22,4 @@ obj-$(CONFIG_HOTPLUG_CPU) ? += hotplug.o
?# machine support
?obj-$(CONFIG_MACH_SMDKV310) ?+= mach-smdkv310.o
arch/arm/mach-s5pv310/Makefile +1 -0
+obj-$(CONFIG_MACH_UNIVERSAL) += mach-universal.o
arch/arm/mach- renamed from arch/arm/mach-s5pv310/mach-universal.c +0 -0
s5pv310/mach-universal.c
new file mode 100644
index 0000000..d22727f
arch/arm/mach-s5pv310/mach-universal.c new file +12 -0
@@ -0,0 +1,86 @@
+/* linux/arch/arm/mach-s5pv310/mach-universal.c
+ *
+ * Copyright (C) 2010 Samsung Electronics Co., Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>

arch/arm/mach-s5pv310/mach-universal.c line 22

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +10 -0

+#include <asm/mach-types.h>
+#include <asm/hardware/cache-l2x0.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv310.h>
+#include <plat/cpu.h>
+
+#include <mach/map.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers

Quoted 37 lines

arch/arm/mach-s5pv310/mach-universal.c new file +35 -0

+#define UNIVERSAL_UCON_DEFAULT ? ? ? (S3C2410_UCON_TXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN)
+
+#define UNIVERSAL_ULCON_DEFAULT ? ? ?S3C2410_LCON_CS8
+
+#define UNIVERSAL_UFCON_DEFAULT ? ? ?(S3C2410_UFCON_FIFOMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? S5PV210_UFCON_TXTRIG256 | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? S5PV210_UFCON_RXTRIG256)
+
+static struct s3c2410_uartcfg universal_uartcfgs[] __initdata = {
+ ? ? [0] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 0,
 
 
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = UNIVERSAL_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= UNIVERSAL_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= UNIVERSAL_UFCON_DEFAULT,
+ ? ? },
+ ? ? [1] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 1,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = UNIVERSAL_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= UNIVERSAL_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= UNIVERSAL_UFCON_DEFAULT,
+ ? ? },
+ ? ? [2] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 2,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = UNIVERSAL_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= UNIVERSAL_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= UNIVERSAL_UFCON_DEFAULT,
+ ? ? },
+ ? ? [3] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 3,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = UNIVERSAL_UCON_DEFAULT,

arch/arm/mach-s5pv310/mach-universal.c

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +10 -0

+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= UNIVERSAL_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= UNIVERSAL_UFCON_DEFAULT,
+ ? ? },
+};
+
+static void __init universal_map_io(void)
+{
+ ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+ ? ? s3c24xx_init_clocks(24000000);
+ ? ? s3c24xx_init_uarts(universal_uartcfgs,

ARRAY_SIZE(universal_uartcfgs));

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +10 -0

+}
+
+static void __init universal_machine_init(void)
+{
+#ifdef CONFIG_CACHE_L2X0
+ ? ? l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
+#endif
+}
+
+MACHINE_START(UNIVERSAL, "UNIVERSAL")

arch/arm/mach-s5pv310/mach-universal.c

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +9 -1

+ ? ? /* Maintainer: Kyungmin Park <[email protected]> */
+ ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000,
+ ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+ ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100,
+ ? ? .init_irq ? ? ? = s5pv310_init_irq,
+ ? ? .map_io ? ? ? ? = universal_map_io,
+ ? ? .init_machine ? = universal_machine_init,
+ ? ? .timer ? ? ? ? ?= &s5pv310_timer,
+MACHINE_END
--

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kukjin Kim

2010-07-31 04:46 UTC #3 lore raw

PATCH 1/1 S5PV310: Add Samsung Mobile Reference Board support

Quoted 2 lines · Kyungmin Park

On Sat, Jul 31, 2010 at 12:08 PM, Kukjin Kim <[email protected]>

Quoted 11 lines · wrote:

Quoted 11 lines
Quoted 6 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
Initial samsung mobile reference board support
Signed-off-by Kyungmin Park <[email protected]>
Cc'ed Ben Dooks...again, please include Ben Dooks in Cc.
And it would be helpful to me for review if you could add patch version

and

Quoted 4 lines

Quoted 3 lines
changes.
It can help to avoid omission your new patch which has same name with previous one.
As I can't see the patch at your for-next I resend it.

Hmm...I mean, if this is just 'resend', should being the comment, 'RESEND'...
How can I know that without any comments?

However, your this patch changed UFCON_DEFAULT value.

Quoted 10 lines

Quoted 10 lines
Review
Quoted 10 lines
---
?arch/arm/mach-s5pv310/Kconfig ? ? ? ? ?| ? ?9 +++
?arch/arm/mach-s5pv310/Makefile ? ? ? ? | ? ?1 +
?arch/arm/mach-s5pv310/mach-universal.c | ? 86
++++++++++++++++++++++++++++++++
?3 files changed, 96 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-s5pv310/mach-universal.c
(quoted diff) +0 -0

b/arch/arm/mach-s5pv310/Kconfig

Quoted 13 lines

Quoted 4 lines
Quoted 4 lines
index 24ef3cd..2fe8149 100644
arch/arm/mach-s5pv310/Kconfig +0 -0
@@ -23,4 +23,13 @@ config MACH_SMDKV310
Quoted 8 lines
arch/arm/mach-s5pv310/Kconfig config MACH_SMDKV310 · line 27
Quoted 5 lines
? ? ? select ARCH_SPARSEMEM_ENABLE
? ? ? help
? ? ? ? Machine support for Samsung SMDKV310
arch/arm/mach-s5pv310/Kconfig +2 -0
+
+config MACH_UNIVERSAL
As I still asking, do you _really_ want to use 'UNIVERSAL' as the board(machine) name?

Quoted 3 lines

Yes, it's called 'universal' and it's really universal board at here. I don't confuse the engineer who develop this board.
Maybe your engineers saw and hear the brief description about universal

board.

Quoted 1 line

Actually, I know that. But there are S5PC100, S5PC110 universal board also...
So I asked to you that you _really_ want to use 'universal' here...and I'm still concerning.

Quoted 17 lines

Quoted 17 lines
Review
Quoted 10 lines
+ ? ? bool "Mobile Universal Board"
+ ? ? select CPU_S5PV310
+ ? ? select ARCH_SPARSEMEM_ENABLE
+ ? ? help
+ ? ? ? Machine support for Samsung Mobile Universal Reference Board.
+ ? ? ? S5PC210(MCP) is one of package option of S5PV310
+
?endif
(quoted diff) +0 -0
b/arch/arm/mach-s5pv310/Makefile
Quoted 6 lines
index 56e7693..5b52132 100644
arch/arm/mach-s5pv310/Makefile +0 -0
@@ -22,3 +22,4 @@ obj-$(CONFIG_HOTPLUG_CPU) ? += hotplug.o
?# machine support

Quoted 14 lines

Quoted 6 lines
Quoted 6 lines
?obj-$(CONFIG_MACH_SMDKV310) ?+= mach-smdkv310.o
arch/arm/mach-s5pv310/Makefile +1 -0
+obj-$(CONFIG_MACH_UNIVERSAL) += mach-universal.o
arch/arm/mach- renamed from arch/arm/mach-s5pv310/mach-universal.c +0 -0
s5pv310/mach-universal.c
new file mode 100644
index 0000000..d22727f
Quoted 8 lines
arch/arm/mach-s5pv310/mach-universal.c line 5
Quoted 8 lines
arch/arm/mach-s5pv310/mach-universal.c new file +5 -0
@@ -0,0 +1,86 @@
+/* linux/arch/arm/mach-s5pv310/mach-universal.c
+ *
+ * Copyright (C) 2010 Samsung Electronics Co., Ltd.
+ *
+ * This program is free software; you can redistribute it and/or

modify

Quoted 9 lines

arch/arm/mach-s5pv310/mach-universal.c new file +9 -0

+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach-types.h>
+#include <asm/hardware/cache-l2x0.h>

Quoted 8 lines

Quoted 8 lines
arch/arm/mach-s5pv310/mach-universal.c
Quoted 8 lines
arch/arm/mach-s5pv310/mach-universal.c new file +8 -0
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv310.h>
+#include <plat/cpu.h>
+
+#include <mach/map.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART

registers

Quoted 73 lines

Quoted 2 lines

*/
Quoted 1 line
arch/arm/mach-s5pv310/mach-universal.c new file +1 -0
+#define UNIVERSAL_UCON_DEFAULT ? ? ? (S3C2410_UCON_TXILEVEL

| ? ? ? ?\

Quoted 9 lines

arch/arm/mach-s5pv310/mach-universal.c line 32

Quoted 9 lines

arch/arm/mach-s5pv310/mach-universal.c new file +9 -0

+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN)
+
+#define UNIVERSAL_ULCON_DEFAULT ? ? ?S3C2410_LCON_CS8
+
+#define UNIVERSAL_UFCON_DEFAULT ? ? ?(S3C2410_UFCON_FIFOMODE

| ? ? ? \

Quoted 60 lines

Quoted 27 lines

arch/arm/mach-s5pv310/mach-universal.c new file +25 -0

+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? S5PV210_UFCON_TXTRIG256 | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? S5PV210_UFCON_RXTRIG256)
+
+static struct s3c2410_uartcfg universal_uartcfgs[] __initdata = {
+ ? ? [0] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 0,
 
 
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = UNIVERSAL_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= UNIVERSAL_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= UNIVERSAL_UFCON_DEFAULT,
+ ? ? },
+ ? ? [1] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 1,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = UNIVERSAL_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= UNIVERSAL_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= UNIVERSAL_UFCON_DEFAULT,
+ ? ? },
+ ? ? [2] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 2,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = UNIVERSAL_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= UNIVERSAL_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= UNIVERSAL_UFCON_DEFAULT,
+ ? ? },
+ ? ? [3] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 3,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = UNIVERSAL_UCON_DEFAULT,

arch/arm/mach-s5pv310/mach-universal.c

Quoted 10 lines

arch/arm/mach-s5pv310/mach-universal.c new file +10 -0

+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= UNIVERSAL_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= UNIVERSAL_UFCON_DEFAULT,
+ ? ? },
+};
+
+static void __init universal_map_io(void)
+{
+ ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+ ? ? s3c24xx_init_clocks(24000000);
+ ? ? s3c24xx_init_uarts(universal_uartcfgs,

ARRAY_SIZE(universal_uartcfgs));

Quoted 20 lines

arch/arm/mach-s5pv310/mach-universal.c new file +19 -1

+}
+
+static void __init universal_machine_init(void)
+{
+#ifdef CONFIG_CACHE_L2X0
+ ? ? l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
+#endif
+}
+
+MACHINE_START(UNIVERSAL, "UNIVERSAL")
+ ? ? /* Maintainer: Kyungmin Park <[email protected]> */
+ ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000,
+ ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+ ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100,
+ ? ? .init_irq ? ? ? = s5pv310_init_irq,
+ ? ? .map_io ? ? ? ? = universal_map_io,
+ ? ? .init_machine ? = universal_machine_init,
+ ? ? .timer ? ? ? ? ?= &s5pv310_timer,
+MACHINE_END
--

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.