Skip to contentSkip to conversation

mke2fs.8.in: correct the sign of a block-size constraint.

PATCH In review Chris Frost 3 participants 5 messages Jul 24, 2010 – Jul 31, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mke2fs.8.in: correct the sign of a block-size constraint.

Small but technical typo correction.

There may be more preferred mark ups (e.g., no space between the negative sign and "block-sized") or expressions (e.g., absolute value instead of negation).

---
 misc/mke2fs.8.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
misc/mke2fs.8.in +1 -1
index 45a99f8..05cfe17 100644
@@ -177,7 +177,7 @@ is negative, then
 .B mke2fs
 will use heuristics to determine the
 appropriate block size, with the constraint that the block size will be
-at least
+at least \-
 .I block-size
 bytes.  This is useful for certain hardware devices which require that
 the blocksize be a multiple of 2k.
Signature · 5 lines
1.7.0.4

-- 
Chris Frost
http://www.frostnet.net/chris/
#1 lore raw
Quoted 5 lines · Chris Frost

Small but technical typo correction.

There may be more preferred mark ups (e.g., no space between the negative sign and "block-sized") or expressions (e.g., absolute value instead of negation).

wow I didn't even know that behavior existed.

How about "If block-size is preceded by a negative sign ("-"), then mke2fs will use heuristics to determine the appropriate block size, with the constraint that the block size will be at least block-size bytes."

-Eric

Quoted 19 lines
---
 misc/mke2fs.8.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
misc/mke2fs.8.in +1 -1
index 45a99f8..05cfe17 100644
@@ -177,7 +177,7 @@ is negative, then
 .B mke2fs
 will use heuristics to determine the
 appropriate block size, with the constraint that the block size will be
-at least
+at least \-
 .I block-size
 bytes.  This is useful for certain hardware devices which require that
 the blocksize be a multiple of 2k.
#2 lore raw
Quoted 5 lines · Eric Sandeen

wow I didn't even know that behavior existed.

How about "If block-size is preceded by a negative sign ("-"), then mke2fs will use heuristics to determine the appropriate block size, with the constraint that the block size will be at least block-size bytes."

I think this is more readable; thanks!

Signature · 2 lines
Chris Frost
http://www.frostnet.net/chris/
#3 lore raw

PATCH v2 1/1 mke2fs.8.in: clarify the sign of a block-size constraint.

In reply to Chris Frost

This bit of the mke2fs manpage is slightly confusing:

-b block-size
Specify the size of blocks in bytes. <snip>
If block-size is negative, then mke2fs will use heuristics to determine the appropriate block size, with the constraint that the block size will be at least block-size bytes.

because it sounds like the block size will be at least a negative number. Clarify just what the negative sign means.

---

misc/mke2fs.8.in +1 -1
index 45a99f8..b46e7e2 100644
@@ -173,7 +173,7 @@ the expected usage of the filesystem (see the
 .B \-T
 option).  If
 .I block-size
-is negative, then
+is preceded by a negative sign ('-'), then
 .B mke2fs
 will use heuristics to determine the
 appropriate block size, with the constraint that the block size will be
Applied
#4 lore raw

Re: [PATCH V2] mke2fs.8.in: clarify the sign of a block-size constraint.

Quoted 8 lines · Eric Sandeen

This bit of the mke2fs manpage is slightly confusing:

-b block-size
Specify the size of blocks in bytes. <snip>
If block-size is negative, then mke2fs will use heuristics to determine the appropriate block size, with the constraint that the block size will be at least block-size bytes.

Quoted 5 lines

because it sounds like the block size will be at least a negative number. Clarify just what the negative sign means.

Applied, thanks.

- Ted