Skip to contentSkip to conversation

S5P: support mmc driver

PATCH New Minkyu Kang 3 participants 5 messages Jul 6, 2010 – Aug 3, 2010

Subsystems (2)
Arm (32-bit) MMC, SD and SDIO
lore
Share & tools
lore

Minkyu Kang

author
#0 lore raw

PATCH 1/2 S5P: support mmc driver

This patch adds support mmc driver for s5p SoC

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/include/asm/arch-s5pc1xx/cpu.h |    2 +
 arch/arm/include/asm/arch-s5pc1xx/mmc.h |   71 +++++
 drivers/mmc/Makefile                    |    1 +
 drivers/mmc/s5p_mmc.c                   |  478 +++++++++++++++++++++++++++++++
 4 files changed, 552 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h
 create mode 100644 drivers/mmc/s5p_mmc.c
arch/arm/include/asm/arch-s5pc1xx/cpu.h +2 -0
index 90485aa..b3af8cc 100644
@@ -38,6 +38,7 @@
 #define S5PC100_PWMTIMER_BASE	0xEA000000
 #define S5PC100_WATCHDOG_BASE	0xEA200000
 #define S5PC100_UART_BASE	0xEC000000
+#define S5PC100_MMC_BASE	0xED800000
 
 /* S5PC110 */
 #define S5PC110_GPIO_BASE	0xE0200000

@@ -45,6 +46,7 @@
 #define S5PC110_WATCHDOG_BASE	0xE2700000
 #define S5PC110_UART_BASE	0xE2900000
 #define S5PC110_SROMC_BASE	0xE8000000
+#define S5PC110_MMC_BASE	0xEB000000
 #define S5PC110_DMC0_BASE	0xF0000000
 #define S5PC110_DMC1_BASE	0xF1400000
 #define S5PC110_VIC0_BASE	0xF2000000
arch/arm/include/asm/arch-s5pc1xx/mmc.h new file +71 -0

71 lines not on this page · raw message

drivers/mmc/Makefile +1 -0
index 6fa04b8..8dfd8a3 100644
@@ -32,6 +32,7 @@ COBJS-$(CONFIG_OMAP3_MMC) += omap3_mmc.o
 COBJS-$(CONFIG_FSL_ESDHC) += fsl_esdhc.o
 COBJS-$(CONFIG_MXC_MMC) += mxcmmc.o
 COBJS-$(CONFIG_PXA_MMC) += pxa_mmc.o
+COBJS-$(CONFIG_S5P_MMC) += s5p_mmc.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
drivers/mmc/s5p_mmc.c new file +478 -0

478 lines not on this page · raw message

Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/2 S5P: support mmc driver

Dear Wolfgang,

Quoted 5 lines · Minkyu Kang

This patch adds support mmc driver for s5p SoC

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Quoted 9 lines

---

?arch/arm/include/asm/arch-s5pc1xx/cpu.h | ? ?2 +
?arch/arm/include/asm/arch-s5pc1xx/mmc.h | ? 71 +++++
?drivers/mmc/Makefile ? ? ? ? ? ? ? ? ? ?| ? ?1 +
?drivers/mmc/s5p_mmc.c ? ? ? ? ? ? ? ? ? | ?478 +++++++++++++++++++++++++++++++

?4 files changed, 552 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h ?create mode 100644 drivers/mmc/s5p_mmc.c

Could I apply this patchset without Andy's review?

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH 1/2 S5P: support mmc driver

Quoted 18 lines · Minkyu Kang

Dear Wolfgang,

Quoted 5 lines · Minkyu Kang

This patch adds support mmc driver for s5p SoC

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Quoted 9 lines

---

?arch/arm/include/asm/arch-s5pc1xx/cpu.h | ? ?2 +
?arch/arm/include/asm/arch-s5pc1xx/mmc.h | ? 71 +++++
?drivers/mmc/Makefile ? ? ? ? ? ? ? ? ? ?| ? ?1 +
?drivers/mmc/s5p_mmc.c ? ? ? ? ? ? ? ? ? | ?478 +++++++++++++++++++++++++++++++

?4 files changed, 552 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h ?create mode 100644 drivers/mmc/s5p_mmc.c

Quoted 2 lines

Could I apply this patchset without Andy's review?

applied to u-boot-samsung

Signature · 2 lines
from. prom.
www.promsoft.net
#3 lore raw

PATCH 1/2 S5P: support mmc driver

In reply to Minkyu Kang

Dear Minkyu Kang,

Quoted 1 line · In message <[email protected]> you wrote:

This patch adds support mmc driver for s5p SoC

...

drivers/mmc/s5p_mmc.c line 30

Quoted 5 lines
drivers/mmc/s5p_mmc.c new file +5 -0
+#ifdef DEBUG_S5P_HSMMC
+#define dbg(x...)       printf(x)
+#else
+#define dbg(x...)       do { } while (0)
+#endif

Can you please rework this code to use the standard debug() macro instead of your own?

Thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...all the  good  computer  designs  are  bootlegged;  the  formally
planned  products,  if  they  are built at all, are dogs!" - David E.
Lundstrom, "A Few Good Men From Univac", MIT Press, 1987
#4 lore raw

PATCH 1/2 S5P: support mmc driver

Dear Wolfgang,

Quoted 6 lines · Wolfgang Denk

Dear Minkyu Kang,

Quoted 1 line · In message <[email protected]> you wrote:

This patch adds support mmc driver for s5p SoC

...

Quoted 8 lines

drivers/mmc/s5p_mmc.c line 30

Quoted 5 lines
drivers/mmc/s5p_mmc.c new file +5 -0
+#ifdef DEBUG_S5P_HSMMC
+#define dbg(x...) ? ? ? printf(x)
+#else
+#define dbg(x...) ? ? ? do { } while (0)
+#endif

Can you please rework this code to use the standard debug() macro instead of your own?

Ok, I'll do.
Thanks.

Quoted 7 lines

Thanks.

Best regards,

Wolfgang Denk

Quoted 12 lines

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "...all the ?good ?computer ?designs ?are ?bootlegged; ?the ?formally planned ?products, ?if ?they ?are built at all, are dogs!" - David E. Lundstrom, "A Few Good Men From Univac", MIT Press, 1987
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net