Skip to contentSkip to conversation

ARM: S5PC210: Use the correct GPIO base addresses

PATCH New Kyungmin Park 2 participants 4 messages Aug 6, 2010 – Aug 20, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/3 ARM: S5PC210: Use the correct GPIO base addresses

From: Kyungmin Park <[email protected]>

The S5PC210 has three GPIO base addresses.

Part1 Base Address=0x11400000
Part2 Base Address=0x11000000
Part3 Base Address=0x03860000

Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv310/include/mach/map.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/mach-s5pv310/include/mach/map.h +3 -1
index 87697c9..7eb2a7a 100644
@@ -39,8 +39,10 @@
 #define S5PV310_PA_GIC_DIST		(0x10501000)
 #define S5PV310_PA_L2CC			(0x10502000)
 
-#define S5PV310_PA_GPIO			(0x11000000)
+#define S5PV310_PA_GPIO			(0x11400000)
 #define S5P_PA_GPIO			S5PV310_PA_GPIO
+#define S5PV310_PA_GPIO2		(0x11000000)
+#define S5PV310_PA_GPIO3		(0x03860000)
 
 #define S5PV310_PA_UART			(0x13800000)
Signature · 1 line
1.5.3.3
#1 lore raw

PATCH 1/3 ARM: S5PC210: Use the correct GPIO base addresses

Quoted 9 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

The S5PC210 has three GPIO base addresses.

Part1 Base Address=0x11400000
Part2 Base Address=0x11000000
Part3 Base Address=0x03860000

Yes, maybe missed.

Quoted 11 lines
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv310/include/mach/map.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s5pv310/include/mach/map.h +0 -0

s5pv310/include/mach/map.h
index 87697c9..7eb2a7a 100644

arch/arm/mach-s5pv310/include/mach/map.h line 42

Quoted 5 lines
arch/arm/mach-s5pv310/include/mach/map.h +1 -1
@@ -39,8 +39,10 @@
 #define S5PV310_PA_GIC_DIST		(0x10501000)
 #define S5PV310_PA_L2CC			(0x10502000)
 
-#define S5PV310_PA_GPIO			(0x11000000)
+#define S5PV310_PA_GPIO			(0x11400000)

S5PV310_PA_GPIO1 is better...

Quoted 9 lines
arch/arm/mach-s5pv310/include/mach/map.h +2 -0
 #define S5P_PA_GPIO			S5PV310_PA_GPIO
 
+#define S5PV310_PA_GPIO2		(0x11000000)
+#define S5PV310_PA_GPIO3		(0x03860000)

#define S5PV310_PA_UART (0x13800000)

--

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

author
#2 lore raw

PATCH 1/3 ARM: S5PC210: Use the correct GPIO base addresses

Quoted 26 lines · Kukjin Kim
Quoted 9 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

The S5PC210 has three GPIO base addresses.

Part1 Base Address=0x11400000
Part2 Base Address=0x11000000
Part3 Base Address=0x03860000

Yes, maybe missed.

Quoted 14 lines
Signed-off-by Kyungmin Park <[email protected]>

---
?arch/arm/mach-s5pv310/include/mach/map.h | ? ?4 +++- ?1 files changed, 3 insertions(+), 1 deletions(-)

arch/arm/mach- renamed from arch/arm/mach-s5pv310/include/mach/map.h +0 -0

s5pv310/include/mach/map.h
index 87697c9..7eb2a7a 100644

arch/arm/mach-s5pv310/include/mach/map.h +0 -0
@@ -39,8 +39,10 @@
 ?#define S5PV310_PA_GIC_DIST ? ? ? ? ?(0x10501000)
 ?#define S5PV310_PA_L2CC ? ? ? ? ? ? ? ? ? ? ?(0x10502000)
Quoted 4 lines

arch/arm/mach-s5pv310/include/mach/map.h line 42

Quoted 2 lines
arch/arm/mach-s5pv310/include/mach/map.h +1 -1
-#define S5PV310_PA_GPIO ? ? ? ? ? ? ? ? ? ? ?(0x11000000)
+#define S5PV310_PA_GPIO ? ? ? ? ? ? ? ? ? ? ?(0x11400000)

S5PV310_PA_GPIO1 is better...

No problem.

Quoted 26 lines
Quoted 10 lines

?#define S5P_PA_GPIO ? ? ? ? ? ? ? ? ?S5PV310_PA_GPIO

arch/arm/mach-s5pv310/include/mach/map.h +2 -0
+#define S5PV310_PA_GPIO2 ? ? ? ? ? ? (0x11000000)
+#define S5PV310_PA_GPIO3 ? ? ? ? ? ? (0x03860000)

?#define S5PV310_PA_UART ? ? ? ? ? ? ? ? ? ? ?(0x13800000)

--

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw

PATCH 1/3 ARM: S5PC210: Use the correct GPIO base addresses

In reply to Kyungmin Park
Quoted 22 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

The S5PC210 has three GPIO base addresses.

Part1 Base Address=0x11400000
Part2 Base Address=0x11000000
Part3 Base Address=0x03860000

Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv310/include/mach/map.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s5pv310/include/mach/map.h +0 -0

s5pv310/include/mach/map.h
index 87697c9..7eb2a7a 100644

arch/arm/mach-s5pv310/include/mach/map.h +0 -0
@@ -39,8 +39,10 @@
 #define S5PV310_PA_GIC_DIST		(0x10501000)
 #define S5PV310_PA_L2CC			(0x10502000)

arch/arm/mach-s5pv310/include/mach/map.h

Quoted 10 lines
arch/arm/mach-s5pv310/include/mach/map.h +3 -2
 
-#define S5PV310_PA_GPIO			(0x11000000)
+#define S5PV310_PA_GPIO			(0x11400000)
 #define S5P_PA_GPIO			S5PV310_PA_GPIO
+#define S5PV310_PA_GPIO2		(0x11000000)
+#define S5PV310_PA_GPIO3		(0x03860000)
 
 #define S5PV310_PA_UART			(0x13800000)
 
--

Ok..will apply.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.