ARM: S5PC210: Add missing GPIO MP0_0 definition

PATCH New Kyungmin Park 2 participants 4 messages Aug 6, 2010 – Aug 20, 2010

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Kyungmin Park

author

2010-08-06 04:23 UTC #0 lore raw

PATCH 2/3 ARM: S5PC210: Add missing GPIO MP0_0 definition

From: Kyungmin Park <[email protected]>

Some board uses the MP0_0 for GPIO.

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s5pv310/include/mach/gpio.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

arch/arm/mach-s5pv310/include/mach/gpio.h +4 -1

index a840d83..4ab4e23 100644
@@ -55,6 +55,7 @@
 #define S5PV310_GPIO_X2_NR	(8)
 #define S5PV310_GPIO_X3_NR	(8)
 #define S5PV310_GPIO_Z_NR	(7)
+#define S5PV310_GPIO_MP00_NR	(8)
 #define S5PV310_GPIO_MP01_NR	(8)
 #define S5PV310_GPIO_MP02_NR	(4)
 #define S5PV310_GPIO_MP03_NR	(8)

@@ -96,7 +97,8 @@ enum s5p_gpio_number {
 	S5PV310_GPIO_X2_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_X1),
 	S5PV310_GPIO_X3_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_X2),
 	S5PV310_GPIO_Z_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_X3),
-	S5PV310_GPIO_MP01_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_Z),
+	S5PV310_GPIO_MP00_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_Z),
+	S5PV310_GPIO_MP01_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_MP00),
 	S5PV310_GPIO_MP02_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_MP01),
 	S5PV310_GPIO_MP03_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_MP02),
 	S5PV310_GPIO_MP04_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_MP03),

@@ -133,6 +135,7 @@ enum s5p_gpio_number {
 #define S5PV310_GPX2(_nr)	(S5PV310_GPIO_X2_START + (_nr))
 #define S5PV310_GPX3(_nr)	(S5PV310_GPIO_X3_START + (_nr))
 #define S5PV310_GPZ(_nr)	(S5PV310_GPIO_Z_START + (_nr))
+#define S5PV310_MP00(_nr)	(S5PV310_GPIO_MP00_START + (_nr))
 #define S5PV310_MP01(_nr)	(S5PV310_GPIO_MP01_START + (_nr))
 #define S5PV310_MP02(_nr)	(S5PV310_GPIO_MP02_START + (_nr))
 #define S5PV310_MP03(_nr)	(S5PV310_GPIO_MP03_START + (_nr))

Signature · 1 line

1.5.3.3

Kukjin Kim

2010-08-06 13:33 UTC #1 lore raw

PATCH 2/3 ARM: S5PC210: Add missing GPIO MP0_0 definition

Quoted 42 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>
Some board uses the MP0_0 for GPIO.
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv310/include/mach/gpio.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s5pv310/include/mach/gpio.h +0 -0
s5pv310/include/mach/gpio.h
index a840d83..4ab4e23 100644
arch/arm/mach-s5pv310/include/mach/gpio.h +2 -1
@@ -55,6 +55,7 @@
 #define S5PV310_GPIO_X2_NR	(8)
 #define S5PV310_GPIO_X3_NR	(8)
 #define S5PV310_GPIO_Z_NR	(7)
+#define S5PV310_GPIO_MP00_NR	(8)
 #define S5PV310_GPIO_MP01_NR	(8)
 #define S5PV310_GPIO_MP02_NR	(4)
 #define S5PV310_GPIO_MP03_NR	(8)
@@ -96,7 +97,8 @@ enum s5p_gpio_number {
 	S5PV310_GPIO_X2_START	=
 S5PV310_GPIO_NEXT(S5PV310_GPIO_X1),
 	S5PV310_GPIO_X3_START	=
 S5PV310_GPIO_NEXT(S5PV310_GPIO_X2),
 	S5PV310_GPIO_Z_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_X3),
-	S5PV310_GPIO_MP01_START	=
 S5PV310_GPIO_NEXT(S5PV310_GPIO_Z),
+	S5PV310_GPIO_MP00_START	=
S5PV310_GPIO_NEXT(S5PV310_GPIO_Z),
arch/arm/mach-s5pv310/include/mach/gpio.h +1 -0
+	S5PV310_GPIO_MP01_START	=
S5PV310_GPIO_NEXT(S5PV310_GPIO_MP00),
S5PV310_GPIO_MP02_START =
S5PV310_GPIO_NEXT(S5PV310_GPIO_MP01),
S5PV310_GPIO_MP03_START =
S5PV310_GPIO_NEXT(S5PV310_GPIO_MP02),
S5PV310_GPIO_MP04_START =
S5PV310_GPIO_NEXT(S5PV310_GPIO_MP03),

arch/arm/mach-s5pv310/include/mach/gpio.h enum s5p_gpio_number {

Quoted 8 lines

arch/arm/mach-s5pv310/include/mach/gpio.h +1 -1

@@ -133,6 +135,7 @@ enum s5p_gpio_number {
 #define S5PV310_GPX2(_nr)	(S5PV310_GPIO_X2_START + (_nr))
 #define S5PV310_GPX3(_nr)	(S5PV310_GPIO_X3_START + (_nr))
 #define S5PV310_GPZ(_nr)	(S5PV310_GPIO_Z_START + (_nr))
+#define S5PV310_MP00(_nr)	(S5PV310_GPIO_MP00_START + (_nr))
 #define S5PV310_MP01(_nr)	(S5PV310_GPIO_MP01_START + (_nr))
 #define S5PV310_MP02(_nr)	(S5PV310_GPIO_MP02_START + (_nr))
 #define S5PV310_MP03(_nr)	(S5PV310_GPIO_MP03_START + (_nr))
--

Should be merged previous '[PATCH] ARM: S5PC210: Define more GPIOs to use the MP pins' and this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kukjin Kim

2010-08-20 10:06 UTC #2 lore raw

PATCH 2/3 ARM: S5PC210: Add missing GPIO MP0_0 definition

In reply to Kyungmin Park

Quoted 47 lines · Kukjin Kim

Quoted 45 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
Some board uses the MP0_0 for GPIO.
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv310/include/mach/gpio.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s5pv310/include/mach/gpio.h +0 -0
s5pv310/include/mach/gpio.h
index a840d83..4ab4e23 100644
arch/arm/mach-s5pv310/include/mach/gpio.h +2 -1
@@ -55,6 +55,7 @@
 #define S5PV310_GPIO_X2_NR	(8)
 #define S5PV310_GPIO_X3_NR	(8)
 #define S5PV310_GPIO_Z_NR	(7)
+#define S5PV310_GPIO_MP00_NR	(8)
 #define S5PV310_GPIO_MP01_NR	(8)
 #define S5PV310_GPIO_MP02_NR	(4)
 #define S5PV310_GPIO_MP03_NR	(8)
@@ -96,7 +97,8 @@ enum s5p_gpio_number {
 	S5PV310_GPIO_X2_START	=
 S5PV310_GPIO_NEXT(S5PV310_GPIO_X1),
 	S5PV310_GPIO_X3_START	=
 S5PV310_GPIO_NEXT(S5PV310_GPIO_X2),
 	S5PV310_GPIO_Z_START	= S5PV310_GPIO_NEXT(S5PV310_GPIO_X3),
-	S5PV310_GPIO_MP01_START	=
 S5PV310_GPIO_NEXT(S5PV310_GPIO_Z),
+	S5PV310_GPIO_MP00_START	=
S5PV310_GPIO_NEXT(S5PV310_GPIO_Z),
arch/arm/mach-s5pv310/include/mach/gpio.h +1 -0
+	S5PV310_GPIO_MP01_START	=
S5PV310_GPIO_NEXT(S5PV310_GPIO_MP00),
S5PV310_GPIO_MP02_START =
S5PV310_GPIO_NEXT(S5PV310_GPIO_MP01),
S5PV310_GPIO_MP03_START =
S5PV310_GPIO_NEXT(S5PV310_GPIO_MP02),
S5PV310_GPIO_MP04_START =
S5PV310_GPIO_NEXT(S5PV310_GPIO_MP03),
arch/arm/mach-s5pv310/include/mach/gpio.h +0 -0
@@ -133,6 +135,7 @@ enum s5p_gpio_number {
 #define S5PV310_GPX2(_nr)	(S5PV310_GPIO_X2_START + (_nr))
 #define S5PV310_GPX3(_nr)	(S5PV310_GPIO_X3_START + (_nr))
 #define S5PV310_GPZ(_nr)	(S5PV310_GPIO_Z_START + (_nr))

Quoted 9 lines

arch/arm/mach-s5pv310/include/mach/gpio.h enum s5p_gpio_number {
Quoted 5 lines
arch/arm/mach-s5pv310/include/mach/gpio.h +1 -1
+#define S5PV310_MP00(_nr)	(S5PV310_GPIO_MP00_START + (_nr))
 #define S5PV310_MP01(_nr)	(S5PV310_GPIO_MP01_START + (_nr))
 #define S5PV310_MP02(_nr)	(S5PV310_GPIO_MP02_START + (_nr))
 #define S5PV310_MP03(_nr)	(S5PV310_GPIO_MP03_START + (_nr))
--
Should be merged previous '[PATCH] ARM: S5PC210: Define more GPIOs to use the MP pins' and this.

I didn't get updated patch...could you please re-submit updated one?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kyungmin Park

author

2010-08-20 10:08 UTC #3 lore raw

PATCH 2/3 ARM: S5PC210: Add missing GPIO MP0_0 definition

Forget it.

It's out-dated document error. there's no MP0* series GPIOs at up-to-dated documents.

others are same.

Thank you,
Kyungmin Park

Quoted 68 lines · Kukjin Kim

Quoted 47 lines · Kukjin Kim
Quoted 45 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
Some board uses the MP0_0 for GPIO.
Signed-off-by Kyungmin Park <[email protected]>
---
?arch/arm/mach-s5pv310/include/mach/gpio.h | ? ?5 ++++- ?1 files changed, 4 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s5pv310/include/mach/gpio.h +0 -0
s5pv310/include/mach/gpio.h
index a840d83..4ab4e23 100644
arch/arm/mach-s5pv310/include/mach/gpio.h +1 -0
@@ -55,6 +55,7 @@
 ?#define S5PV310_GPIO_X2_NR (8)
 ?#define S5PV310_GPIO_X3_NR (8)
 ?#define S5PV310_GPIO_Z_NR ?(7)
+#define S5PV310_GPIO_MP00_NR ? ? ? (8)
 ?#define S5PV310_GPIO_MP01_NR ? ? ? (8)
 ?#define S5PV310_GPIO_MP02_NR ? ? ? (4)
 ?#define S5PV310_GPIO_MP03_NR ? ? ? (8)
@@ -96,7 +97,8 @@ enum s5p_gpio_number {
? ? S5PV310_GPIO_X2_START ? = S5PV310_GPIO_NEXT(S5PV310_GPIO_X1),
? ? S5PV310_GPIO_X3_START ? = S5PV310_GPIO_NEXT(S5PV310_GPIO_X2),
? ? S5PV310_GPIO_Z_START ? ?= S5PV310_GPIO_NEXT(S5PV310_GPIO_X3),
- ? S5PV310_GPIO_MP01_START = S5PV310_GPIO_NEXT(S5PV310_GPIO_Z),
+ ? S5PV310_GPIO_MP00_START = S5PV310_GPIO_NEXT(S5PV310_GPIO_Z),
+ ? S5PV310_GPIO_MP01_START = S5PV310_GPIO_NEXT(S5PV310_GPIO_MP00),
? ? S5PV310_GPIO_MP02_START = S5PV310_GPIO_NEXT(S5PV310_GPIO_MP01),
? ? S5PV310_GPIO_MP03_START = S5PV310_GPIO_NEXT(S5PV310_GPIO_MP02),
? ? S5PV310_GPIO_MP04_START = S5PV310_GPIO_NEXT(S5PV310_GPIO_MP03),
arch/arm/mach-s5pv310/include/mach/gpio.h +0 -0
@@ -133,6 +135,7 @@ enum s5p_gpio_number {
 ?#define S5PV310_GPX2(_nr) ?(S5PV310_GPIO_X2_START + (_nr))
 ?#define S5PV310_GPX3(_nr) ?(S5PV310_GPIO_X3_START + (_nr))
 ?#define S5PV310_GPZ(_nr) ? (S5PV310_GPIO_Z_START + (_nr))
Quoted 9 lines
arch/arm/mach-s5pv310/include/mach/gpio.h enum s5p_gpio_number {
Quoted 5 lines
arch/arm/mach-s5pv310/include/mach/gpio.h +1 -1
+#define S5PV310_MP00(_nr) ?(S5PV310_GPIO_MP00_START + (_nr))
 ?#define S5PV310_MP01(_nr) ?(S5PV310_GPIO_MP01_START + (_nr))
 ?#define S5PV310_MP02(_nr) ?(S5PV310_GPIO_MP02_START + (_nr))
 ?#define S5PV310_MP03(_nr) ?(S5PV310_GPIO_MP03_START + (_nr))
--
Should be merged previous '[PATCH] ARM: S5PC210: Define more GPIOs to use the MP pins' and this.
I didn't get updated patch...could you please re-submit updated one?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.