net: convert to rcu_dereference_index_check()
Subsystems (2)
PATCH 1/1 net: convert to rcu_dereference_index_check()
Hello, Herbert!
At long last, the following is the final patch blocking acceptance of Arnd's sparse annotations for RCU. It was itself blocked behind the definition of rcu_dereference_index_check(), which made it to mainline only just today.
Would you be willing to ack this patch so that I can push it to -tip, along with Arnd's work and a bunch of other stuff?
Thanx, Paul
------------------------------------------------------------------------
commit 34ea15566530f8e4d0c1571cc8c3554fd91d5809
Author: Paul E. McKenney <[email protected]> Date: Mon Jun 14 17:06:21 2010 -0700
net: convert to rcu_dereference_index_check()
The task_cls_classid() function applies rcu_dereference() to integers, which does not work with the shiny new sparse-based checking in rcu_dereference(). This commit therefore moves to the new RCU API rcu_dereference_index_check().
cls_cgroup.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/net/cls_cgroup.h +2 -1
@@ -45,7 +45,8 @@ static inline u32 task_cls_classid(struct task_struct *p)return 0 ;rcu_read_lock (); - id =rcu_dereference (net_cls_subsys_id); + id =rcu_dereference_index_check (net_cls_subsys_id, +rcu_read_lock_held ());if (id >=0 ) classid =container_of (task_subsys_state (p, id), struct cgroup_cls_state, css)->classid;
From: "Paul E. McKenney" <[email protected]>
Date: Fri, 6 Aug 2010 14:26:07 -0700
Quoted 7 lines
At long last, the following is the final patch blocking acceptance of Arnd's sparse annotations for RCU. It was itself blocked behind the definition of
rcu_dereference_index_check(), which made it to mainline only just today.Would you be willing to ack this patch so that I can push it to -tip, along with Arnd's work and a bunch of other stuff?
...
Quoted 9 lines
net: convert to
rcu_dereference_index_check()The
task_cls_classid()function appliesrcu_dereference()to integers, which does not work with the shiny new sparse-based checking inrcu_dereference(). This commit therefore moves to the new RCU APIrcu_dereference_index_check().Signed-off-by Paul E. McKenney <[email protected]>Reviewed-by Josh Triplett <[email protected]>
You should of course wait for Herbert's ACK too, but for the record:
:-)
Quoted 21 lines · David Miller
From: "Paul E. McKenney" <[email protected]>
Date: Fri, 6 Aug 2010 14:26:07 -0700Quoted 7 lines
At long last, the following is the final patch blocking acceptance of Arnd's sparse annotations for RCU. It was itself blocked behind the definition of
rcu_dereference_index_check(), which made it to mainline only just today.Would you be willing to ack this patch so that I can push it to -tip, along with Arnd's work and a bunch of other stuff?
...
Quoted 9 lines
net: convert to
rcu_dereference_index_check()The
task_cls_classid()function appliesrcu_dereference()to integers, which does not work with the shiny new sparse-based checking inrcu_dereference(). This commit therefore moves to the new RCU APIrcu_dereference_index_check().Signed-off-by Paul E. McKenney <[email protected]>Reviewed-by Josh Triplett <[email protected]>
Quoted 6 lines
You should of course wait for Herbert's ACK too, but for the record:
Acked-by David S. Miller <[email protected]>:-)
Thank you, David!!! ;-)
Thanx, Paul
Quoted 9 lines · Paul E. McKenney
Hello, Herbert!
At long last, the following is the final patch blocking acceptance of Arnd's sparse annotations for RCU. It was itself blocked behind the definition of
rcu_dereference_index_check(), which made it to mainline only just today.Would you be willing to ack this patch so that I can push it to -tip, along with Arnd's work and a bunch of other stuff?
Sure,
Thanks,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 8 lines · Herbert Xu
Quoted 7 lines · Paul E. McKenney
Hello, Herbert!
At long last, the following is the final patch blocking acceptance of Arnd's sparse annotations for RCU. It was itself blocked behind the definition of
rcu_dereference_index_check(), which made it to mainline only just today.
Quoted 6 lines
Quoted 2 lines
Would you be willing to ack this patch so that I can push it to -tip, along with Arnd's work and a bunch of other stuff?
Sure,
Acked-by Herbert Xu <[email protected]>
Thank you, Herbert!!!
Thanx, Paul