Skip to contentSkip to conversation

ppc4xx: cleanup default environment for AMCC boards

PATCH New Wolfgang Denk 2 participants 3 messages Jul 23, 2010 – Aug 9, 2010

lore
Share & tools
lore

Wolfgang Denk

author
#0 lore raw

PATCH 1/1 ppc4xx: cleanup default environment for AMCC boards

None of the AMCC boards uses an embedded environment, so there is no need to run "saveenv" after updating U-Boot. Drop the redundant commands from the default environment.

Signed-off-by Wolfgang Denk <[email protected]>
---
 include/configs/amcc-common.h |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
include/configs/amcc-common.h +2 -4
index 13a941e..23a859f 100644
@@ -278,15 +278,13 @@
 	"load=tftp 200000 ${u-boot}\0"					\
 	"update=protect off " xstr(CONFIG_SYS_MONITOR_BASE) " FFFFFFFF;"	\
 		"era " xstr(CONFIG_SYS_MONITOR_BASE) " FFFFFFFF;"		\
-		"cp.b ${fileaddr} " xstr(CONFIG_SYS_MONITOR_BASE) " ${filesize};" \
-		"setenv filesize;saveenv\0"				\
+		"cp.b ${fileaddr} " xstr(CONFIG_SYS_MONITOR_BASE) " ${filesize}" \
 	"upd=run load update\0"						\
 
 #define CONFIG_AMCC_DEF_ENV_NAND_UPD					\
 	"u-boot-nand=" xstr(CONFIG_HOSTNAME) "/u-boot-nand.bin\0"	\
 	"nload=tftp 200000 ${u-boot-nand}\0"				\
-	"nupdate=nand erase 0 100000;nand write 200000 0 100000;"	\
-		"setenv filesize;saveenv\0"				\
+	"nupdate=nand erase 0 100000;nand write 200000 0 100000"	\
 	"nupd=run nload nupdate\0"
 
 #endif /* __AMCC_COMMON_H */
Signature · 1 line
1.7.1.1
author
#1 lore raw

PATCH 1/1 ppc4xx: cleanup default environment for AMCC boards

Dear Stefan,

Quoted 8 lines · In message <[email protected]> I wrote:

None of the AMCC boards uses an embedded environment, so there is no need to run "saveenv" after updating U-Boot. Drop the redundant commands from the default environment.

Signed-off-by Wolfgang Denk <[email protected]>
---
 include/configs/amcc-common.h |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

Ping...

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
... bacteriological warfare ... hard to believe we were once foolish
enough to play around with that.
	-- McCoy, "The Omega Glory", stardate unknown
#2 lore raw

PATCH 1/1 ppc4xx: cleanup default environment for AMCC boards

In reply to Wolfgang Denk
Quoted 3 lines · On Friday 23 July 2010 21:16:26 Wolfgang Denk wrote:

None of the AMCC boards uses an embedded environment, so there is no need to run "saveenv" after updating U-Boot. Drop the redundant commands from the default environment.

Applied to u-boot-ppc4xx/master. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de