Skip to contentSkip to conversation

Fixed clobbered output of the "help usb" command

PATCH New Sergei Poselenov 2 participants 3 messages Aug 9, 2010 – Aug 10, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixed clobbered output of the "help usb" command

Hello all,

I've noticed that the "usb help" doesn't format the output correctly:

=> help usb
usb - USB sub-system

Usage:
usb reset - reset (rescan) USB controller
usb stop [f] - stop USB [f]=force stop
usb tree - show USB device tree
usb info [dev] - show available USB devices
usb storage - show details of USB storage devices
usb dev [dev] - show or set current USB storage device
usb part [dev] - print partition table of one or all USB storage devices usb read addr blk# cnt - read cnt' blocks starting at block blk#'
to memory address addr'usb write addr blk# cnt - write cnt'
blocks starting at block blk#' from memory address addr' =>

With fix below applied, the output is correct:

=> help usb
usb - USB sub-system

Usage:
usb reset - reset (rescan) USB controller
usb stop [f] - stop USB [f]=force stop
usb tree - show USB device tree
usb info [dev] - show available USB devices
usb storage - show details of USB storage devices
usb dev [dev] - show or set current USB storage device
usb part [dev] - print partition table of one or all USB storage devices usb read addr blk# cnt - read cnt' blocks starting at block blk#'
to memory address `addr'
usb write addr blk# cnt - write cnt' blocks starting at block blk#'
from memory address `addr'
=>

Please apply.

Regards,
Sergei

#1 lore raw

PATCH 1/1 Fixed clobbered output of the "help usb" command

Hi,

2010/8/9 Sergei Poselenov <[email protected]>:

Quoted 62 lines

Hello all,

I've noticed that the "usb help" doesn't format the output correctly:

=> help usb
usb - USB sub-system

Usage:
usb reset - reset (rescan) USB controller
usb stop [f] ?- stop USB [f]=force stop
usb tree ?- show USB device tree
usb info [dev] - show available USB devices
usb storage ?- show details of USB storage devices
usb dev [dev] - show or set current USB storage device
usb part [dev] - print partition table of one or all USB storage devices usb read addr blk# cnt - read cnt' blocks starting at block blk#' ? ?to memory address addr'usb write addr blk# cnt - write cnt' blocks starting at block blk#' from memory address addr' =>

With fix below applied, the output is correct:

=> help usb
usb - USB sub-system

Usage:
usb reset - reset (rescan) USB controller
usb stop [f] ?- stop USB [f]=force stop
usb tree ?- show USB device tree
usb info [dev] - show available USB devices
usb storage ?- show details of USB storage devices
usb dev [dev] - show or set current USB storage device
usb part [dev] - print partition table of one or all USB storage devices usb read addr blk# cnt - read cnt' blocks starting at block blk#' ? ?to memory address `addr'
usb write addr blk# cnt - write cnt' blocks starting at block blk#' ? ?from memory address `addr'
=>

Please apply.

Regards,
Sergei

From 473e86d3f5fe82fa7b27e5e73929e0e1f11987f4 Mon Sep 17 00:00:00 2001
From: Sergei Poselenov <[email protected]>
Date: Mon, 9 Aug 2010 13:45:00 +0200
Subject: [PATCH] common/cmd_usb.c: fixed clobbered output in "help usb". ?Signed-off-by: Sergei Poselenov <[email protected]>

---
?common/cmd_usb.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

common/cmd_usb.c +0 -0
index dc63f24..226ea0d 100644
@@ -712,7 +712,7 @@ U_BOOT_CMD(
Quoted 2 lines

? ? ? ?"usb part [dev] - print partition table of one or all USB storage" " devices\n"

Patch is corrupt. Lines are wrapped.

Quoted 7 lines

? ? ? ?"usb read addr blk# cnt - read cnt' blocks starting at block blk#'\n"
- ? ? ? " ? ?to memory address `addr'"
+ ? ? ? " ? ?to memory address `addr'\n"
? ? ? ?"usb write addr blk# cnt - write cnt' blocks starting at block blk#'\n" " ? ?from memory address `addr'"
?);

Applied to u-boot-usb after some small fixes to this patch (header text cleaned up and word wrapping)
Thanks.

Remy

#2 lore raw

PATCH 1/1 Fixed clobbered output of the "help usb" command

Hi Remy,

Quoted 8 lines · On Mon, 9 Aug 2010 19:26:46 +0200 Remy Bohmer <[email protected]> wrote:
Quoted 5 lines
common/cmd_usb.c +0 -0
@@ -712,7 +712,7 @@ U_BOOT_CMD(

? ? ? ?"usb part [dev] - print partition table of one or all USB storage" " devices\n"

Patch is corrupt. Lines are wrapped.

Sorry for that. Now I adjusted wrapping settings on my Claws Mail client.

Quoted 8 lines
Quoted 7 lines

? ? ? ?"usb read addr blk# cnt - read cnt' blocks starting at block blk#'\n"
- ? ? ? " ? ?to memory address `addr'"
+ ? ? ? " ? ?to memory address `addr'\n"
? ? ? ?"usb write addr blk# cnt - write cnt' blocks starting at block blk#'\n" " ? ?from memory address `addr'"
?);

Quoted 4 lines

Applied to u-boot-usb after some small fixes to this patch (header text cleaned up and word wrapping)
Thanks.

Thank you.

Regards,
Sergei