Skip to contentSkip to conversation

isdn: avm: call disable_pci_device() if pci_probe() failed

PATCH Applied Kulikov Vasiliy 2 participants 2 messages Aug 9, 2010 – Aug 10, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 6/18 isdn: avm: call disable_pci_device() if pci_probe() failed

Driver should call disable_pci_device() if it returns from pci_probe() with error.

---
 drivers/isdn/hardware/avm/c4.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/isdn/hardware/avm/c4.c +1 -0
index 7715d32..d3530f6 100644
@@ -1273,6 +1273,7 @@ static int __devinit c4_probe(struct pci_dev *dev,
 	if (retval != 0) {
 		printk(KERN_ERR "c4: no AVM-C%d at i/o %#x, irq %d detected, mem %#x\n",
 		       nr, param.port, param.irq, param.membase);
+		pci_disable_device(dev);
 		return -ENODEV;
 	}
 	return 0;
Signature · 1 line
1.7.0.4
maintainer Applied
#1 lore raw

From: Kulikov Vasiliy <[email protected]>
Date: Mon, 9 Aug 2010 23:50:37 +0400

Quoted 4 lines

Driver should call disable_pci_device() if it returns from pci_probe() with error.

Applied, but please fix the template you're using for the commit message header and the message itself, because in all of your patches you've transposed "disable" and "pci" in "pci_disable_device()"

So I have to fix it up two times in every patch I apply of your's.

Thanks.