Staging: ti-st: writing past end of array

PATCH New Dan Carpenter 1 participant 1 message Aug 10, 2010

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-08-10 05:36 UTC #0 lore raw

PATCH 1/1 Staging: ti-st: writing past end of array

In the original source it would write past the end of the array before returning the error code.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/ti-st/st_core.c +2 -3

index 063c9b1..0dfed21 100644
@@ -686,9 +686,8 @@ long st_register(struct st_proto_s *new_proto)
 		default:
 			pr_err("%d protocol not supported",
 				   new_proto->type);
-			err = -EPROTONOSUPPORT;
-			/* something wrong */
-			break;
+			spin_unlock_irqrestore(&st_gdata->lock, flags);
+			return -EPROTONOSUPPORT;
 		}
 		st_gdata->list[new_proto->type] = new_proto;
 		st_gdata->protos_registered++;