Skip to contentSkip to conversation

mfd: wm831x-core - fix incorrect kfree(i2c) in i2c_driver probe callback handler

PATCH Applied Axel Lin 2 participants 2 messages Aug 9, 2010 – Aug 10, 2010

Subsystems (2)
Multifunction devices (MFD) Wolfson microelectronics drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 3/4 mfd: wm831x-core - fix incorrect kfree(i2c) in i2c_driver probe callback handler

The i2c_client received in probe() should not be kfree()'d.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/wm831x-core.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/mfd/wm831x-core.c +1 -3
index cb94e7e..1e7aaaf 100644
@@ -1757,10 +1757,8 @@ static int wm831x_i2c_probe(struct i2c_client *i2c,
 	struct wm831x *wm831x;
 
 	wm831x = kzalloc(sizeof(struct wm831x), GFP_KERNEL);
-	if (wm831x == NULL) {
-		kfree(i2c);
+	if (wm831x == NULL)
 		return -ENOMEM;
-	}
 
 	i2c_set_clientdata(i2c, wm831x);
 	wm831x->dev = &i2c->dev;
Signature · 1 line
1.5.4.3