Skip to contentSkip to conversation

: Fix arm kconfig

PATCH New xsecute at googlemail.com 3 participants 5 messages Aug 10, 2010 Arm (32-bit)

lore
Share & tools
lore

xsecute at googlemail.com

author
#0 lore raw

PATCH 1/1 : Fix arm kconfig

Hi Russell,

i get an nerror if i try: make ARCH=arm CROSS_COMPILE=arm-eabi

Output:
scripts/kconfig/mconf arch/arm/Kconfig
arch/arm/Kconfig:1187: invalid option
make[1]: *** [menuconfig] Error 1
make: *** [menuconfig] Error 2
--------------------------------------------------------
The following patch fix that.
==========================

arch/arm/Kconfig +0 -1
index 232f0c7..684c1a1 100644
@@ -1184,8 +1184,8 @@ config LOCAL_TIMERS
                REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
                ARCH_U8500 || ARCH_VEXPRESS_CA9X4 || ARCH_TEGRA)
        default y
-       select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS ||

ARCH_OMAP4 || \\
- ARCH_U8500 || ARCH_TEGRA
+ select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS ||
ARCH_OMAP4 || \
+ ARCH_U8500 || ARCH_TEGRA)
help
Enable support for local timers on SMP platforms, rather then the legacy IPI broadcast method. Local timers allows the system

#1 lore raw

PATCH 1/1 : Fix arm kconfig

Quoted 3 lines · xsecute at googlemail.com

Hi Russell,

i get an nerror if i try: make ARCH=arm CROSS_COMPILE=arm-eabi

Yes, Erik Miao reported it yesterday, and I suggested getting rid of the paren which isn't actually required. Unfortuantely, I'm still waiting for that to happen... and land in the patch system.

Instead, the patch system seems to be filling with stuff for the next merge window...

#2 lore raw

PATCH 1/1 : Fix arm kconfig

In reply to xsecute at googlemail.com

Hello,

Quoted 3 lines · xsecute at googlemail.com

Hi Russell,

i get an nerror if i try: make ARCH=arm CROSS_COMPILE=arm-eabi

This is the third patch for this problem and nobody did what Russell requested. Will follow up with a patch.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#3 lore raw

PATCH 1/1 ARM: fix syntax error in main Kconfig file

This fixes:

scripts/kconfig/mconf arch/arm/Kconfig
arch/arm/Kconfig:1187: invalid option
make[1]: *** [menuconfig] Error 1
make: *** [menuconfig] Error 2

which was introduced by

	1cea732 ([ARM] tegra: SMP support)
Signed-off-by Uwe Kleine-K?nig <[email protected]>
Cc Tanmay Upadhyay <[email protected]>
Cc xsecute at googlemail.com
Cc Eric Miao <[email protected]>
Cc Colin Cross <[email protected]>

---
KernelVersion: v2.6.35-3374-g1cea732

 arch/arm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/Kconfig +1 -1
index 232f0c7..952ded5 100644
@@ -1184,7 +1184,7 @@ config LOCAL_TIMERS
 		REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
 		ARCH_U8500 || ARCH_VEXPRESS_CA9X4 || ARCH_TEGRA)
 	default y
-	select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\
+	select HAVE_ARM_TWD if ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\
 		ARCH_U8500 || ARCH_TEGRA
 	help
 	  Enable support for local timers on SMP platforms, rather then the
Signature · 1 line
1.7.1
#4 lore raw

PATCH 1/1 ARM: fix syntax error in main Kconfig file

arch/arm/Kconfig config LOCAL_TIMERS · line 1187

Quoted 2 lines · Uwe Kleine-K?nig
arch/arm/Kconfig +1 -1
-	select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\
+	select HAVE_ARM_TWD if ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\

This is still crap. '\\' on the end of the line...

And no surprises that I'm getting conflicts when merging my master and devel branches here. Don't bother submitting a new patch, I'll fix it in the conflict resolution.