kernel version 2.6.35-git10 build failure
Hi,
Today kernel(version 2.6.35-git10 -commitid 3d30701b58970) build fails with following error on both system x and p
fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr' make[2]: *** [fs/9p/vfs_inode.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [fs/9p] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [fs] Error 2
make: *** Waiting for unfinished jobs....
Seems like the commit 87d7845aa0b is the corrupt which added the function v9fs_vfs_setattr_dotl()
Thanks
Divya
Hi Divya,
Quoted 5 lines · On Wed, 11 Aug 2010 12:51:35 +0530 divya <[email protected]> wrote:
Today kernel(version 2.6.35-git10 -commitid
3d30701b58970) build fails with following error on both system x and p
fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr'
This is known about and a fix is pending. Thanks.
Signature · 3 lines
Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Quoted 13 lines · On Wed, 11 Aug 2010 12:51:35 +0530 divya <[email protected]> wrote:
Hi,
Today kernel(version 2.6.35-git10 -commitid
3d30701b58970) build fails with following error on both system x and p
fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr' make[2]: *** [fs/9p/vfs_inode.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [fs/9p] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [fs] Error 2
make: *** Waiting for unfinished jobs....
Quoted 1 line
Seems like the commit
87d7845aa0bis the corrupt which added the functionv9fs_vfs_setattr_dotl()
Yes, it is a problem I created. Stephen Rothwell has already fixed it. Al Viro has sent a git pull request to Linus today with the fix in it. Here is the patch you need: http://lkml.org/lkml/2010/6/21/442
Thanks,
Sripathi.
Quoted 5 lines
Thanks
Divya
Quoted 16 lines · Sripathi Kodi
Quoted 13 lines · On Wed, 11 Aug 2010 12:51:35 +0530 divya<[email protected]> wrote:
Hi,
Today kernel(version 2.6.35-git10 -commitid
3d30701b58970) build fails with following error on both system x and p
fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr' make[2]: *** [fs/9p/vfs_inode.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [fs/9p] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [fs] Error 2
make: *** Waiting for unfinished jobs....
Quoted 5 lines
Quoted 1 line
Seems like the commit
87d7845aa0bis the corrupt which added the functionv9fs_vfs_setattr_dotl()Yes, it is a problem I created. Stephen Rothwell has already fixed it. Al Viro has sent a git pull request to Linus today with the fix in it. Here is the patch you need: http://lkml.org/lkml/2010/6/21/442
I fail to apply the patch.
aapi205:/usr/src/linux# patch -p1 < ../9p-patch.txt patching file fs/9p/vfs_inode.c Hunk #1 FAILED at 1052. 1 out of 1 hunk FAILED -- saving rejects to file fs/9p/vfs_inode.c.rej
aapi205:/usr/src/linux# cat fs/9p/vfs_inode.c.rej
--- fs/9p/vfs_inode.c
+++ fs/9p/vfs_inode.c
@@ -1052,10 +1052,19 @@
return PTR_ERR(fid);retval = p9_client_setattr(fid, &p9attr);
- if (retval >= 0)
- retval = inode_setattr(dentry->d_inode, iattr);
+ if (retval < 0)
+ return retval;
- return retval;
+ if ((iattr->ia_valid & ATTR_SIZE) &&
+ iattr->ia_size != i_size_read(dentry->d_inode)) {
+ retval = vmtruncate(dentry->d_inode, iattr->ia_size);
+ if (retval)
+ return retval;
+ }
+
+ setattr_copy(dentry->d_inode, iattr); + mark_inode_dirty(dentry->d_inode); + return 0;
}
/**
I must be doing something wrong way.
Regards,
Piotr Hosowicz
Signature · 5 lines
Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach: - Jaką walutę mają Indie? - Ramadan. NP: Patrick O'Hearn - Approaching Summit NB: 2.6.35-git9