Skip to contentSkip to conversation

fsnotify: pass both the vfsmount mark and inode mark

DISCUSSION Dan Carpenter 1 participant 1 message Aug 11, 2010

lore
Share & tools
lore
#0 lore raw

There is a NULL dereference introduced in ce8f76fb7320 "fsnotify: pass both the vfsmount mark and inode mark"

143 static int send_to_group(struct inode *to_tell, struct vfsmount *mnt,

   144                           struct fsnotify_mark *inode_mark,
   145                           struct fsnotify_mark *vfsmount_mark,
   146                           __u32 mask, void *data,
   147                           int data_is, u32 cookie,
   148                           const unsigned char *file_name,
   149                           struct fsnotify_event **event)

150 {
151 struct fsnotify_group *group = inode_mark->group;
^^^^^^^^^^^^^^^^^^
inode_mark can be NULL.

   152          __u32 inode_test_mask = (mask & ~FS_EVENT_ON_CHILD);
   153          __u32 vfsmount_test_mask = (mask & ~FS_EVENT_ON_CHILD);

I'm not sure how to handle this.

regards,
dan carpenter