Skip to contentSkip to conversation

nand/denali: change read_status function method

PATCH New Chuanxiao.Dong 1 participant 1 message Aug 12, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/5 nand/denali: change read_status function method

From 8b09365e8e58ea0d18fe0ce03b20531c98d43a7a Mon Sep 17 00:00:00 2001
From: Chuanxiao Dong <[email protected]>
Date: Wed, 11 Aug 2010 17:14:59 +0800
Subject: [PATCH 2/5] nand/denali: change read_status function method

In mtd->write, Denali controller will use MODE_11 mode to read NAND flash status, then return back to MODE_1O mode to do page write.
Here comes a bug for this kind of using, sometimes controller will not write data to NAND and just return a good interrupt to tell driver writing work is done. The data in this page is all 0xff and this page can not be written again. The reason is unknow.

So read Denali controller register WRITE_PROTECT to get NAND status instead.

---
 drivers/mtd/nand/denali.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)
drivers/mtd/nand/denali.c +5 -7
index 3ba8952..975a893 100644
@@ -169,13 +169,11 @@ static void read_status(struct denali_nand_info *denali)
 	/* initialize the data buffer to store status */
 	reset_buf(denali);
 
-	/* initiate a device status read */
-	cmd = MODE_11 | BANK(denali->flash_bank);
-	index_addr(denali, cmd | COMMAND_CYCLE, 0x70);
-	iowrite32(cmd | STATUS_CYCLE, denali->flash_mem);
-
-	/* update buffer with status value */
-	write_byte_to_buf(denali, ioread32(denali->flash_mem + 0x10));
+	cmd = ioread32(denali->flash_reg + WRITE_PROTECT);
+	if (cmd)
+		write_byte_to_buf(denali, NAND_STATUS_WP);
+	else
+		write_byte_to_buf(denali, 0);
 }
 
 /* resets a specific device connected to the core */
Signature · 1 line
1.6.6.1