Skip to contentSkip to conversation

IR: ir-raw-event: null pointer dereference

PATCH In review Dan Carpenter 2 participants 2 messages Aug 12, 2010

Subsystems (2)
Media (V4L/DVB) Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 IR: ir-raw-event: null pointer dereference

The original code dereferenced ir->raw after freeing it and setting it to NULL.

Signed-off-by Dan Carpenter <[email protected]>
drivers/media/IR/ir-raw-event.c +3 -1
index 43094e7..8e0e1b1 100644
@@ -279,9 +279,11 @@ int ir_raw_event_register(struct input_dev *input_dev)
 			"rc%u",  (unsigned int)ir->devno);
 
 	if (IS_ERR(ir->raw->thread)) {
+		int ret = PTR_ERR(ir->raw->thread);
+
 		kfree(ir->raw);
 		ir->raw = NULL;
-		return PTR_ERR(ir->raw->thread);
+		return ret;
 	}
 
 	mutex_lock(&ir_raw_handler_lock);