Skip to contentSkip to conversation

ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

PATCH Superseded Kukjin Kim 3 participants 4 messages Aug 13, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

PATCH 1/1 ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

This patch fixes on following build warnings.

warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which

             has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)

warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects
CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)

Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>
---
 arch/arm/mach-s3c2440/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c2440/Kconfig +2 -2
index cd8e7de..f60a370 100644
@@ -30,7 +30,7 @@ config CPU_S3C2442
 
 config CPU_S3C244X
 	bool
-	depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
+	depends on (CPU_S3C2440 || CPU_S3C2442)
 	help
 	  Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
 

@@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
 
 config S3C2440_DMA
 	bool
-	depends on ARCH_S3C2410 && CPU_S3C24405B
+	depends on (ARCH_S3C2410 || CPU_S3C24405B)
 	help
 	  Support for S3C2440 specific DMA code5A
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 1/1 ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

Quoted 27 lines · Kukjin Kim

This patch fixes on following build warnings.

warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which

             has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)

warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects
CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)

Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>
---
 arch/arm/mach-s3c2440/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c2440/Kconfig +1 -1
index cd8e7de..f60a370 100644
@@ -30,7 +30,7 @@ config CPU_S3C2442
 
 config CPU_S3C244X
 	bool
-	depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
+	depends on (CPU_S3C2440 || CPU_S3C2442)
 	help
 	  Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.

arch/arm/mach-s3c2440/Kconfig config S3C2440_PLL_16934400 · line 77

Quoted 7 lines
arch/arm/mach-s3c2440/Kconfig +1 -1
@@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
 
 config S3C2440_DMA
 	bool
-	depends on ARCH_S3C2410 && CPU_S3C24405B
+	depends on (ARCH_S3C2410 || CPU_S3C24405B)
 	help
 	  Support for S3C2440 specific DMA code5A

all parenthesis in your +lines are superflous.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
author
#2 lore raw

PATCH 1/1 ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

Quoted 13 lines · Uwe Kleine-König
Quoted 3 lines · Kukjin Kim

This patch fixes on following build warnings.

warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects

S3C2440_DMA which

Quoted 1 line
             has unmet direct dependencies (ARCH_S3C2410 &&

CPU_S3C24405B)

Quoted 1 line

warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 &&

ARCH_S3C2410) selects

Quoted 1 line

CPU_S3C244X which has unmet direct dependencies

(!ARCH_S3C2410)

Quoted 1 line
Quoted 7 lines

Review

Quoted 7 lines
Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>
---
 arch/arm/mach-s3c2440/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-s3c2440/Kconfig

Quoted 15 lines

arch/arm/mach-s3c2440/Kconfig config CPU_S3C2442 · line 35

Quoted 11 lines

index cd8e7de..f60a370 100644

arch/arm/mach-s3c2440/Kconfig +1 -1
@@ -30,7 +30,7 @@ config CPU_S3C2442
 
 config CPU_S3C244X
 	bool
-	depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
+	depends on (CPU_S3C2440 || CPU_S3C2442)
 	help
 	  Support for S3C2440 and S3C2442 Samsung Mobile CPU based

systems.

Quoted 3 lines
arch/arm/mach-s3c2440/Kconfig +0 -0
@@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
Quoted 8 lines

arch/arm/mach-s3c2440/Kconfig config S3C2440_PLL_16934400 · line 77

Quoted 6 lines
arch/arm/mach-s3c2440/Kconfig +1 -1
 config S3C2440_DMA
 	bool
-	depends on ARCH_S3C2410 && CPU_S3C24405B
+	depends on (ARCH_S3C2410 || CPU_S3C24405B)
 	help
 	  Support for S3C2440 specific DMA code5A

all parenthesis in your +lines are superflous.

Yeah, you're right.
Fixed. Thanks. :-)

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#3 lore raw

PATCH 1/1 ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

In reply to Kukjin Kim

Hello.

Quoted 18 lines · Kukjin Kim

This patch fixes on following build warnings.

warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which

             has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)

warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects
CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)

Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>
---
 arch/arm/mach-s3c2440/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c2440/Kconfig +0 -0
index cd8e7de..f60a370 100644

arch/arm/mach-s3c2440/Kconfig config CPU_S3C2442 · line 33

Quoted 5 lines
arch/arm/mach-s3c2440/Kconfig +1 -1
@@ -30,7 +30,7 @@ config CPU_S3C2442
 
 config CPU_S3C244X
 	bool
-	depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
+	depends on (CPU_S3C2440 || CPU_S3C2442)

Parens not necessary...

arch/arm/mach-s3c2440/Kconfig config S3C2440_PLL_16934400 · line 75

Quoted 9 lines
arch/arm/mach-s3c2440/Kconfig +1 -1
 	help
 	  Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
 

@@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
 
 config S3C2440_DMA
 	bool
-	depends on ARCH_S3C2410 && CPU_S3C24405B
+	depends on (ARCH_S3C2410 || CPU_S3C24405B)

Same comment here...

WBR, Sergei