Skip to contentSkip to conversation

ARM: pxa/pwm: Make id const in pwm_probe()

PATCH New Uwe Kleine-König 2 participants 5 messages Aug 12, 2010 – Aug 18, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: pxa/pwm: Make id const in pwm_probe()

This fixes the compiler warning:

arch/arm/plat-pxa/pwm.c: In function 'pwm_probe':
arch/arm/plat-pxa/pwm.c:179: warning: initialization discards qualifiers from pointer target type

---
 arch/arm/plat-pxa/pwm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-pxa/pwm.c +1 -1
index 0732c6c..ef32686 100644
@@ -176,7 +176,7 @@ static inline void __add_pwm(struct pwm_device *pwm)
 
 static int __devinit pwm_probe(struct platform_device *pdev)
 {
-	struct platform_device_id *id = platform_get_device_id(pdev);
+	const struct platform_device_id *id = platform_get_device_id(pdev);
 	struct pwm_device *pwm, *secondary = NULL;
 	struct resource *r;
 	int ret = 0;
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 ARM: pxa/pwm: Make id const in pwm_probe()

2010/8/12 Uwe Kleine-K?nig <[email protected]>:

Quoted 6 lines

This fixes the compiler warning:

? ? ? ?arch/arm/plat-pxa/pwm.c: In function 'pwm_probe':
? ? ? ?arch/arm/plat-pxa/pwm.c:179: warning: initialization discards qualifiers from pointer target type

Ack.

Quoted 21 lines

---
?arch/arm/plat-pxa/pwm.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/plat-pxa/pwm.c +1 -2
index 0732c6c..ef32686 100644
@@ -176,7 +176,7 @@ static inline void __add_pwm(struct pwm_device *pwm)
 
 ?static int __devinit pwm_probe(struct platform_device *pdev)
 ?{
- ? ? ? struct platform_device_id *id = platform_get_device_id(pdev);
+ ? ? ? const struct platform_device_id *id = platform_get_device_id(pdev);
 ? ? ? ?struct pwm_device *pwm, *secondary = NULL;
 ? ? ? ?struct resource *r;
 ? ? ? ?int ret = 0;
--

1.7.1

#2 lore raw

PATCH 1/1 ARM: pxa/pwm: Make id const in pwm_probe()

Quoted 9 lines · Eric Miao

2010/8/12 Uwe Kleine-K?nig <[email protected]>:

Quoted 6 lines

This fixes the compiler warning:

? ? ? ?arch/arm/plat-pxa/pwm.c: In function 'pwm_probe':
? ? ? ?arch/arm/plat-pxa/pwm.c:179: warning: initialization discards qualifiers from pointer target type

Ack.

That means patch system?

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#3 lore raw

PATCH 1/1 ARM: pxa/pwm: Make id const in pwm_probe()

2010/8/13 Uwe Kleine-K?nig <[email protected]>:

Quoted 12 lines · Eric Miao
Quoted 9 lines

2010/8/12 Uwe Kleine-K?nig <[email protected]>:

Quoted 6 lines

This fixes the compiler warning:

? ? ? ?arch/arm/plat-pxa/pwm.c: In function 'pwm_probe':
? ? ? ?arch/arm/plat-pxa/pwm.c:179: warning: initialization discards qualifiers from pointer target type

Ack.

That means patch system?

Nah, I'll merge it later.

Quoted 7 lines

Thanks
Uwe

--

Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | Uwe Kleine-K?nig ? ? ? ? ? ?|
Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
Applied
#4 lore raw

PATCH 1/1 ARM: pxa/pwm: Make id const in pwm_probe()

In reply to Uwe Kleine-König

2010/8/12 Uwe Kleine-K?nig <[email protected]>:

Quoted 6 lines

This fixes the compiler warning:

? ? ? ?arch/arm/plat-pxa/pwm.c: In function 'pwm_probe':
? ? ? ?arch/arm/plat-pxa/pwm.c:179: warning: initialization discards qualifiers from pointer target type

Applied.

Quoted 21 lines

---
?arch/arm/plat-pxa/pwm.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/plat-pxa/pwm.c +1 -2
index 0732c6c..ef32686 100644
@@ -176,7 +176,7 @@ static inline void __add_pwm(struct pwm_device *pwm)
 
 ?static int __devinit pwm_probe(struct platform_device *pdev)
 ?{
- ? ? ? struct platform_device_id *id = platform_get_device_id(pdev);
+ ? ? ? const struct platform_device_id *id = platform_get_device_id(pdev);
 ? ? ? ?struct pwm_device *pwm, *secondary = NULL;
 ? ? ? ?struct resource *r;
 ? ? ? ?int ret = 0;
--

1.7.1