Skip to contentSkip to conversation

staging/comedi das08_cs.c: Fix io_req_t conversion

PATCH In review Andreas Bombe 3 participants 3 messages Aug 14, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging/comedi das08_cs.c: Fix io_req_t conversion

Commit 90abdc3b9 converted all PCMCIA users away from io_req_t. In das08_cs.c the converted IO lines mask setting was added but the old line using the now inexistent p_dev->io was not removed.

---
 drivers/staging/comedi/drivers/das08_cs.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/staging/comedi/drivers/das08_cs.c +0 -1
index c6aa52f..48d9fb1 100644
@@ -222,7 +222,6 @@ static int das08_pcmcia_config_loop(struct pcmcia_device *p_dev,
 		p_dev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH;
 		p_dev->resource[0]->flags |=
 			pcmcia_io_cfg_data_width(io->flags);
-		p_dev->io.IOAddrLines = io->flags & CISTPL_IO_LINES_MASK;
 		p_dev->resource[0]->start = io->win[0].base;
 		p_dev->resource[0]->end = io->win[0].len;
 		if (io->nwin > 1) {
Signature · 1 line
1.7.1
#1 lore raw

Thanks, Andreas.

Greg, do you have other -staging stuff pending to push to Linus? If so, could you take it? Otherwise, I'll queue it up for my bugfixes branch.

Quoted 5 lines · Andreas Bombe

Commit 90abdc3b9 converted all PCMCIA users away from io_req_t. In das08_cs.c the converted IO lines mask setting was added but the old line using the now inexistent p_dev->io was not removed.

Best,
Dominik

#2 lore raw
Quoted 4 lines · Dominik Brodowski

Thanks, Andreas.

Greg, do you have other -staging stuff pending to push to Linus? If so, could you take it? Otherwise, I'll queue it up for my bugfixes branch.

Yes I do, I can take this, thanks.

greg k-h