Skip to contentSkip to conversation

MMC breakage

DISCUSSION Russell King 3 participants 3 messages Aug 17, 2010 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

I get the following build error:

	drivers/built-in.o: In function `mmc_alloc_host':
	mmci.c:(.text+0x80c44): undefined reference to `mmc_pm_notify'

Seems to be down to 4c2ef25fe. The commit claims to fix the CONFIG_PM=n build, but it seems not to as mmc_pm_notify() is within an #ifdef CONFIG_PM block but the initialization isn't.

akpm - do you still have your "fix CONFIG_PM=n" changes for this patch?

Signature · 1 line
Russell King
#1 lore raw

Hi Russell,

Quoted 8 lines · Russell King

I get the following build error:

	drivers/built-in.o: In function `mmc_alloc_host':
	mmci.c:(.text+0x80c44): undefined reference to `mmc_pm_notify'

Seems to be down to 4c2ef25fe. The commit claims to fix the CONFIG_PM=n build, but it seems not to as mmc_pm_notify() is within an #ifdef CONFIG_PM block but the initialization isn't.

Patches have been sent to akpm to fix this already; see
http://lkml.org/lkml/2010/8/12/207
http://article.gmane.org/gmane.linux.kernel/1022716

Thanks,

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>
One Laptop Per Child
#2 lore raw
Quoted 8 lines · On Tue, 17 Aug 2010 16:21:32 +0100 Chris Ball <[email protected]> wrote:

Hi Russell,

Quoted 5 lines · Russell King

I get the following build error:

	drivers/built-in.o: In function `mmc_alloc_host':
	mmci.c:(.text+0x80c44): undefined reference to `mmc_pm_notify'
Quoted 8 lines
Quoted 3 lines

Seems to be down to 4c2ef25fe. The commit claims to fix the CONFIG_PM=n build, but it seems not to as mmc_pm_notify() is within an #ifdef CONFIG_PM block but the initialization isn't.

Patches have been sent to akpm to fix this already; see
http://lkml.org/lkml/2010/8/12/207
http://article.gmane.org/gmane.linux.kernel/1022716

yup. I'm lying on a beach at present. I expect I'll get onto these later in the week.