Skip to contentSkip to conversation

page fault during kernel boot

BUG Marin Mitov 2 participants 3 messages Aug 17, 2010

lore
Share & tools
lore
#0 lore raw

Hi all,

The function: reiserfs_evict_inode() ends with:

<snip>
out:

	end_writeback(inode);	/* note this must go after the journal_end to prevent deadlock */
	dquot_drop(inode);
	inode->i_blocks = 0;
	reiserfs_write_unlock_once(inode->i_sb, depth);

no_delete:

	end_writeback(inode);
	dquot_drop(inode);
}

<snip>

When goto out path is taken,

end_writeback(inode);
dquot_drop(inode);

are executed twice, leading to page fault (in my case) during the kernel boot.

Add return; before no_delete label (but I am not quite sure that this is correct :-).

====================================================================

fs/reiserfs/inode.c +2 -1
@@ -78,11 +78,12 @@ void reiserfs_evict_inode(struct inode *
 		/* no object items are in the tree */
 		;
 	}
-      out:
+out:
 	end_writeback(inode);	/* note this must go after the journal_end to prevent deadlock */
 	dquot_drop(inode);
 	inode->i_blocks = 0;
 	reiserfs_write_unlock_once(inode->i_sb, depth);
+	return;
 
 no_delete:
 	end_writeback(inode);
#1 lore raw
Quoted 15 lines · Marin Mitov

Hi all,

The function: reiserfs_evict_inode() ends with:

<snip>
out:

	end_writeback(inode);	/* note this must go after the journal_end to prevent deadlock */
	dquot_drop(inode);
	inode->i_blocks = 0;
	reiserfs_write_unlock_once(inode->i_sb, depth);

no_delete:

	end_writeback(inode);
	dquot_drop(inode);
}
Quoted 8 lines

<snip>

When goto out path is taken,

end_writeback(inode);
dquot_drop(inode);

are executed twice, leading to page fault (in my case) during the kernel boot.

Indeed. More precisely it triggers a BUG in end_writeback():

	BUG_ON(inode->i_state & I_CLEAR);

that because we call it twice.

Quoted 1 line

Add return; before no_delete label (but I am not quite sure that this is correct :-).

That looks correct.

Also Andrew Benton reported this issue and tested almost the same patch and it seemed to solve the issue.

Thanks.

Quoted 24 lines

====================================================================

fs/reiserfs/inode.c +2 -2
@@ -78,11 +78,12 @@ void reiserfs_evict_inode(struct inode *
 		/* no object items are in the tree */
 		;
 	}
-      out:
+out:
 	end_writeback(inode);	/* note this must go after the journal_end to prevent deadlock */
 	dquot_drop(inode);
 	inode->i_blocks = 0;
 	reiserfs_write_unlock_once(inode->i_sb, depth);
+	return;
 
 no_delete:
 	end_writeback(inode);
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
In reply to Marin Mitov
Quoted 19 lines · Marin Mitov

Hi all,

The function: reiserfs_evict_inode() ends with:

<snip>
out:

	end_writeback(inode);	/* note this must go after the journal_end to prevent deadlock */
	dquot_drop(inode);
	inode->i_blocks = 0;
	reiserfs_write_unlock_once(inode->i_sb, depth);

no_delete:

	end_writeback(inode);
	dquot_drop(inode);
}

<snip>

When goto out path is taken,

Quoted 8 lines

end_writeback(inode);
dquot_drop(inode);

are executed twice, leading to page fault (in my case) during the kernel boot.

Add return; before no_delete label (but I am not quite sure that this is correct :-).

In fact the sam patch has been submitted and applied to the vfs tree already:

http://lkml.org/lkml/2010/8/11/98

The patch will probably reach mainline soon.

Thanks.