powerpc/pci: fix checking for child bridges in PCI code.

PATCH New Grant Likely 1 participant 1 message Aug 18, 2010 PowerPC

Share & tools

Grant Likely

author

2010-08-18 18:27 UTC #0 lore raw

PATCH 1/1 powerpc/pci: fix checking for child bridges in PCI code.

pci_device_to_OF_node() can return null, and list_for_each_entry will never enter the loop when dev is NULL, so it looks like this test is a typo.

Reported-by Julia Lawall <[email protected]>

Signed-off-by Grant Likely <[email protected]>

---
 arch/powerpc/kernel/pci_of_scan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

arch/powerpc/kernel/pci_of_scan.c +1 -1

index 6ddb795..e751506 100644
@@ -336,7 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node,
 		if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
 		    dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) {
 			struct device_node *child = pci_device_to_OF_node(dev);
-			if (dev)
+			if (child)
 				of_scan_pci_bridge(child, dev);
 		}
 	}