drm: move dereference below check

PATCH New Dan Carpenter 1 participant 1 message Aug 19, 2010

Subsystems (3)

DRM drivers DRM misc Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-08-19 09:46 UTC #0 lore raw

PATCH 1/1 drm: move dereference below check

"fb_helper_conn" is dereferenced before the check for NULL. It's never actually NULL here, so this is mostly to keep the static checkers happy.

Signed-off-by Dan Carpenter <[email protected]>

drivers/gpu/drm/drm_fb_helper.c +2 -1

index de82e20..8dd7e6f 100644
@@ -94,10 +94,11 @@ static bool drm_fb_helper_connector_parse_command_line(struct drm_fb_helper_conn
 	int i;
 	enum drm_connector_force force = DRM_FORCE_UNSPECIFIED;
 	struct drm_fb_helper_cmdline_mode *cmdline_mode;
-	struct drm_connector *connector = fb_helper_conn->connector;
+	struct drm_connector *connector;
 
 	if (!fb_helper_conn)
 		return false;
+	connector = fb_helper_conn->connector;
 
 	cmdline_mode = &fb_helper_conn->cmdline_mode;
 	if (!mode_option)