Skip to contentSkip to conversation

tokenring: remove unneeded NULL checks

PATCH Applied Dan Carpenter 2 participants 2 messages Aug 19, 2010 – Aug 22, 2010

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 tokenring: remove unneeded NULL checks

"fw_entry" is always non-NULL at this point and anyway release_firmware() handles NULL parameters.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/tokenring/tms380tr.c +2 -4
index 435ef7d..08182fd 100644
@@ -1321,14 +1321,12 @@ static int tms380tr_reset_adapter(struct net_device *dev)
 
 			/* Clear CPHALT and start BUD */
 			SIFWRITEW(c, SIFACL);
-			if (fw_entry)
-				release_firmware(fw_entry);
+			release_firmware(fw_entry);
 			return (1);
 		}
 	} while(count = 0);
 
-	if (fw_entry)
-		release_firmware(fw_entry);
+	release_firmware(fw_entry);
 	printk(KERN_INFO "%s: Adapter Download Failed\n", dev->name);
 	return (-1);
 }