Skip to contentSkip to conversation

USB: ftdi_sio: fix endianess of max packet size

PATCH In review Michael Wileczka 3 participants 3 messages Aug 18, 2010 – Aug 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: ftdi_sio: fix endianess of max packet size

From: Michael Wileczka <[email protected]>

The USB max packet size (always little-endian) was not being byte swapped on big-endian systems. Created with 2.6.32.16
Applicable since [USB: ftdi_sio: fix hi-speed device packet size calculation] approx 2.6.31

---

drivers/usb/serial/ftdi_sio.c +1 -1
@@ -1397,7 +1397,7 @@ static void ftdi_set_max_packet_size(str
 	}
 
 	/* set max packet size based on descriptor */
-	priv->max_packet_size = ep_desc->wMaxPacketSize;
+	priv->max_packet_size = le16_to_cpu(ep_desc->wMaxPacketSize);
 
 	dev_info(&udev->dev, "Setting MaxPacketSize %d\n", priv->max_packet_size);
 }
#1 lore raw
Quoted 11 lines · On Wed, 18 Aug 2010 07:14:37 -0700 (PDT) Michael Wileczka…

From: Michael Wileczka <[email protected]>

The USB max packet size (always little-endian) was not being byte swapped on big-endian systems. Created with 2.6.32.16
Applicable since [USB: ftdi_sio: fix hi-speed device packet size calculation] approx 2.6.31

---

drivers/usb/serial/ftdi_sio.c static void ftdi_set_max_packet_size(str · line 1403

Quoted 8 lines
drivers/usb/serial/ftdi_sio.c +1 -1
@@ -1397,7 +1397,7 @@ static void ftdi_set_max_packet_size(str
 	}
 
 	/* set max packet size based on descriptor */
-	priv->max_packet_size = ep_desc->wMaxPacketSize;
+	priv->max_packet_size = le16_to_cpu(ep_desc->wMaxPacketSize);
 
 	dev_info(&udev->dev, "Setting MaxPacketSize %d\n", priv->max_packet_size);
 }

So I guess nobody noticed this because the driver deosn't get used on big-endian machines a lot?

What are the user-visible effects of this bug?

#2 lore raw

I guess you're right about it not being used very often on big endian machines.

The original bug report is here: https://dev.openwrt.org/ticket/7365

Quoted 1 line

From the user's point of view, priv->max_packet_size would get set to

0x0020 instead of 0x0200, so a message would print saying "Setting MaxPacketSize 2" when it should be 512. After that you couldn't get any data from the serial port, because priv->max_packet_size is used in other sections of the code.

-Stephen

Quoted 32 lines · Andrew Morton
Quoted 11 lines · On Wed, 18 Aug 2010 07:14:37 -0700 (PDT) Michael Wileczka…

From: Michael Wileczka <[email protected]>

The USB max packet size (always little-endian) was not being byte swapped on big-endian systems. Created with 2.6.32.16
Applicable since [USB: ftdi_sio: fix hi-speed device packet size calculation] approx 2.6.31

---

drivers/usb/serial/ftdi_sio.c static void ftdi_set_max_packet_size(str · line 1403

Quoted 8 lines
drivers/usb/serial/ftdi_sio.c +1 -1
@@ -1397,7 +1397,7 @@ static void ftdi_set_max_packet_size(str
       }
 
       /* set max packet size based on descriptor */
-     priv->max_packet_size = ep_desc->wMaxPacketSize;
+     priv->max_packet_size = le16_to_cpu(ep_desc->wMaxPacketSize);
 
       dev_info(&udev->dev, "Setting MaxPacketSize %d\n", priv->max_packet_size);
  }

So I guess nobody noticed this because the driver deosn't get used on big-endian machines a lot?

What are the user-visible effects of this bug?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html