I2C: Add support for multiple I2C busses for SNTP (effect to RTC)

PATCH New Stephan Linz 3 participants 4 messages Aug 20, 2010 – Aug 23, 2010 Networking

Share & tools

Stephan Linz

author

2010-08-20 13:19 UTC #0 lore raw

PATCH 1/1 I2C: Add support for multiple I2C busses for SNTP (effect to RTC)

This patch switches to the desired I2C bus when the SNTP network service is called. This can be configured using the CONFIG_SYS_RTC_BUS_NUM define.

In my eyes this is a bad and quick hack, but the same as was making for the date and dtt commands (commit: 0dc018e). The right way would be to move all the hardware specific i2c code down to the rtc driver layer.

Signed-off-by Stephan Linz <[email protected]>

---
 net/sntp.c |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

net/sntp.c +16 -0

index 76c10ec..a4399a8 100644
@@ -10,6 +10,12 @@
 #include <net.h>
 #include <rtc.h>
 
+#if defined(CONFIG_CMD_DATE)
+/* FIXME: The i2c dependency should move into the RTC drivers itself. This higher
+ * network layer must not know about hardware specifics!!!!!!! */
+#include <i2c.h>
+#endif
+
 #include "sntp.h"
 
 #define SNTP_TIMEOUT 10000UL

@@ -53,6 +59,9 @@ SntpHandler (uchar *pkt, unsigned dest, unsigned src, unsigned len)
 	struct sntp_pkt_t *rpktp = (struct sntp_pkt_t *)pkt;
 	struct rtc_time tm;
 	ulong seconds;
+#if defined(CONFIG_CMD_DATE)
+	int old_bus;
+#endif
 
 	debug("%s\n", __func__);

@@ -66,7 +75,14 @@ SntpHandler (uchar *pkt, unsigned dest, unsigned src, unsigned len)
 
 	to_tm(ntohl(seconds) - 2208988800UL + NetTimeOffset, &tm);
 #if defined(CONFIG_CMD_DATE)
+	/* switch to correct I2C bus */
+	old_bus = I2C_GET_BUS();
+	I2C_SET_BUS(CONFIG_SYS_RTC_BUS_NUM);
+
 	rtc_set (&tm);
+
+	/* switch back to original I2C bus */
+	I2C_SET_BUS(old_bus);
 #endif
 	printf ("Date: %4d-%02d-%02d Time: %2d:%02d:%02d\n",
 		tm.tm_year, tm.tm_mon, tm.tm_mday,

Signature · 1 line

1.6.3.3

Wolfgang Denk

2010-08-20 14:05 UTC #1 lore raw

PATCH 1/1 I2C: Add support for multiple I2C busses for SNTP (effect to RTC)

Dear Stephan Linz,

Quoted 3 lines · In message <[email protected]> you wrote:

This patch switches to the desired I2C bus when the SNTP network service is called. This can be configured using the CONFIG_SYS_RTC_BUS_NUM define.

...

net/sntp.c line 15

Quoted 3 lines

net/sntp.c +3 -0

+#if defined(CONFIG_CMD_DATE)
+/* FIXME: The i2c dependency should move into the RTC drivers itself. This higher
+ * network layer must not know about hardware specifics!!!!!!! */

Incorrect multiline comment style. And line too long.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Extreme feminine beauty is always disturbing.
	-- Spock, "The Cloud Minders", stardate 5818.4

Stephan Linz

author

2010-08-20 15:54 UTC #2 lore raw

PATCH 1/1 I2C: Add support for multiple I2C busses for SNTP (effect to RTC)

In reply to Stephan Linz

This patch switches to the desired I2C bus when the SNTP network service is called. This can be configured using the CONFIG_SYS_RTC_BUS_NUM define.

Signed-off-by Stephan Linz <[email protected]>

---
 net/sntp.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

net/sntp.c +18 -0

index 76c10ec..5544570 100644
@@ -10,6 +10,14 @@
 #include <net.h>
 #include <rtc.h>
 
+/*
+ * FIXME: The i2c dependency should move into the RTC drivers itself.
+ * This higher network layer must not know about hardware specifics!
+ */
+#if defined(CONFIG_CMD_DATE)
+#include <i2c.h>
+#endif
+
 #include "sntp.h"
 
 #define SNTP_TIMEOUT 10000UL

@@ -53,6 +61,9 @@ SntpHandler (uchar *pkt, unsigned dest, unsigned src, unsigned len)
 	struct sntp_pkt_t *rpktp = (struct sntp_pkt_t *)pkt;
 	struct rtc_time tm;
 	ulong seconds;
+#if defined(CONFIG_CMD_DATE)
+	int old_bus;
+#endif
 
 	debug("%s\n", __func__);

@@ -66,7 +77,14 @@ SntpHandler (uchar *pkt, unsigned dest, unsigned src, unsigned len)
 
 	to_tm(ntohl(seconds) - 2208988800UL + NetTimeOffset, &tm);
 #if defined(CONFIG_CMD_DATE)
+	/* switch to correct I2C bus */
+	old_bus = I2C_GET_BUS();
+	I2C_SET_BUS(CONFIG_SYS_RTC_BUS_NUM);
+
 	rtc_set (&tm);
+
+	/* switch back to original I2C bus */
+	I2C_SET_BUS(old_bus);
 #endif
 	printf ("Date: %4d-%02d-%02d Time: %2d:%02d:%02d\n",
 		tm.tm_year, tm.tm_mon, tm.tm_mday,

Signature · 1 line

1.6.0.4

Heiko Schocher

2010-08-23 06:43 UTC #3 lore raw

PATCH 1/1 I2C: Add support for multiple I2C busses for SNTP (effect to RTC)

Hello Stephan,

added Ben Warren to cc: because this is a change in net, which also falls in his area of responsibility ...

Quoted 8 lines · Stephan Linz

This patch switches to the desired I2C bus when the SNTP network service is called. This can be configured using the CONFIG_SYS_RTC_BUS_NUM define.
In my eyes this is a bad and quick hack, but the same as was making for the date and dtt commands (commit: 0dc018e). The right way would be to move all the hardware specific i2c code down to the rtc driver layer.

Yes, thats would the best way, but why you don;t go this way? Beside of that, this patch look good to me ...

Quoted 39 lines

Signed-off-by Stephan Linz <[email protected]>

---
 net/sntp.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

net/sntp.c +12 -0

index 76c10ec..5544570 100644
@@ -10,6 +10,14 @@
 #include <net.h>
 #include <rtc.h>
 
+/*
+ * FIXME: The i2c dependency should move into the RTC drivers itself.
+ * This higher network layer must not know about hardware specifics!
+ */
+#if defined(CONFIG_CMD_DATE)
+#include <i2c.h>
+#endif
+
 #include "sntp.h"
 
 #define SNTP_TIMEOUT 10000UL

@@ -53,6 +61,9 @@ SntpHandler (uchar *pkt, unsigned dest, unsigned src, unsigned len)
 	struct sntp_pkt_t *rpktp = (struct sntp_pkt_t *)pkt;
 	struct rtc_time tm;
 	ulong seconds;
+#if defined(CONFIG_CMD_DATE)
+	int old_bus;
+#endif
 
 	debug("%s\n", __func__);

@@ -66,7 +77,14 @@ SntpHandler (uchar *pkt, unsigned dest, unsigned src, unsigned len)
 
 	to_tm(ntohl(seconds) - 2208988800UL + NetTimeOffset, &tm);
 #if defined(CONFIG_CMD_DATE)
+	/* switch to correct I2C bus */

net/sntp.c SntpHandler (uchar *pkt, unsigned dest, unsigned src, unsigned len) · line 90

Quoted 10 lines

net/sntp.c +6 -0

+	old_bus = I2C_GET_BUS();
+	I2C_SET_BUS(CONFIG_SYS_RTC_BUS_NUM);
+
 	rtc_set (&tm);
+
+	/* switch back to original I2C bus */
+	I2C_SET_BUS(old_bus);
 #endif
 	printf ("Date: %4d-%02d-%02d Time: %2d:%02d:%02d\n",
 		tm.tm_year, tm.tm_mon, tm.tm_mday,

bye
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany