Skip to contentSkip to conversation

Under linux console gpm cursor now going to opposite direction of mouse

2.6.36 regression Applied Bruno Prémont 4 participants 4 messages Aug 20, 2010 – Aug 25, 2010

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Bruno Prémont

author
#0 lore raw

Somewhere between 2.6.35 and Linus's tree as of this writing gpm started moving its cursor to the opposite direction of mouse movement.

e.g. moving mouse up causes cursor to move down, moving mouse left
causes cursor to go right

Under 2.6.35 the cursor moved into the same direction as the mouse.

Note, mouse is synaptics touchpad (Acer TravelMate660):
Synaptics Touchpad, model: 1, fw: 5.8, id: 0x9d48b1, caps: 0x904713/0x4006/0x0

When I get around to it I will try to get more precise information as to when this regression got introduced, eventually bisecting.

Bruno

#1 lore raw

PATCH 1/1 Input: mousedev - fix regression of inverting axes

Quoted 8 lines · Bruno Prémont

Somewhere between 2.6.35 and Linus's tree as of this writing gpm started moving its cursor to the opposite direction of mouse movement.

e.g. moving mouse up causes cursor to move down, moving mouse left
causes cursor to go right

Under 2.6.35 the cursor moved into the same direction as the mouse.

Quoted 8 lines

Note, mouse is synaptics touchpad (Acer TravelMate660):
Synaptics Touchpad, model: 1, fw: 5.8, id: 0x9d48b1, caps: 0x904713/0x4006/0x0

When I get around to it I will try to get more precise information as to when this regression got introduced, eventually bisecting.

Bruno

Thanks Bruno,
I successfully tested the patch below with gpm.

---
Introduced by 987a6c0298260b7aa40702b349282554d6180e4b a swap in max/min calculation gets fixed by this patch.

Reported-by Bruno Prémont <[email protected]>
Signed-off-by Christoph Fritz <[email protected]>
---
 drivers/input/mousedev.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/input/mousedev.c +4 -4
index 83c24cc..d528a2d 100644
@@ -138,8 +138,8 @@ static void mousedev_touchpad_event(struct input_dev *dev,
 
 		fx(0) = value;
 		if (mousedev->touch && mousedev->pkt_count >= 2) {
-			size = input_abs_get_min(dev, ABS_X) -
-					input_abs_get_max(dev, ABS_X);
+			size = input_abs_get_max(dev, ABS_X) -
+					input_abs_get_min(dev, ABS_X);
 			if (size == 0)
 				size = 256 * 2;
 

@@ -155,8 +155,8 @@ static void mousedev_touchpad_event(struct input_dev *dev,
 		fy(0) = value;
 		if (mousedev->touch && mousedev->pkt_count >= 2) {
 			/* use X size for ABS_Y to keep the same scale */
-			size = input_abs_get_min(dev, ABS_X) -
-					input_abs_get_max(dev, ABS_X);
+			size = input_abs_get_max(dev, ABS_X) -
+					input_abs_get_min(dev, ABS_X);
 			if (size == 0)
 				size = 256 * 2;
Signature · 6 lines
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer Applied
#2 lore raw

Re: [PATCH] Input: mousedev - fix regression of inverting axes

Quoted 21 lines · Christoph Fritz
Quoted 8 lines · Bruno Prémont

Somewhere between 2.6.35 and Linus's tree as of this writing gpm started moving its cursor to the opposite direction of mouse movement.

e.g. moving mouse up causes cursor to move down, moving mouse left
causes cursor to go right

Under 2.6.35 the cursor moved into the same direction as the mouse.

Quoted 8 lines

Note, mouse is synaptics touchpad (Acer TravelMate660):
Synaptics Touchpad, model: 1, fw: 5.8, id: 0x9d48b1, caps: 0x904713/0x4006/0x0

When I get around to it I will try to get more precise information as to when this regression got introduced, eventually bisecting.

Bruno

Thanks Bruno,
I successfully tested the patch below with gpm.

Quoted 6 lines

---
Introduced by 987a6c0298260b7aa40702b349282554d6180e4b a swap in max/min calculation gets fixed by this patch.

Reported-by Bruno Prémont <[email protected]>
Signed-off-by Christoph Fritz <[email protected]>

Applied, thanks Christoph.

Signature · 5 lines
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
In reply to Bruno Prémont
Quoted 13 lines · On piątek, 20 sierpnia 2010 o 22:33:16 Bruno Prémont wrote:

Somewhere between 2.6.35 and Linus's tree as of this writing gpm started moving its cursor to the opposite direction of mouse movement.

e.g. moving mouse up causes cursor to move down, moving mouse left
causes cursor to go right

Under 2.6.35 the cursor moved into the same direction as the mouse.

Note, mouse is synaptics touchpad (Acer TravelMate660):
Synaptics Touchpad, model: 1, fw: 5.8, id: 0x9d48b1, caps:
0x904713/0x4006/0x0

Quoted 4 lines

When I get around to it I will try to get more precise information as to when this regression got introduced, eventually bisecting.

Bruno

I created a Bugzilla entry at
https://bugzilla.kernel.org/show_bug.cgi?id=17031
for your bug report, please add your address to the CC list in there, thanks!

Signature · 6 lines
Maciej Rutecki
http://www.maciek.unixy.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html