Skip to contentSkip to conversation

pxa168_eth: silence gcc warnings

PATCH Applied Dan Carpenter 2 participants 2 messages Aug 24, 2010

Subsystems (3)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 4/4 pxa168_eth: silence gcc warnings

Casting "pep->tx_desc_dma" to to a struct tx_desc pointer makes gcc complain:

drivers/net/pxa168_eth.c:657: warning:
cast to pointer from integer of different size

drivers/net/pxa168_eth.c +3 -3
index f324b76..b1f440b 100644
@@ -654,15 +654,15 @@ static void eth_port_start(struct net_device *dev)
 	/* Assignment of Tx CTRP of given queue */
 	tx_curr_desc = pep->tx_curr_desc_q;
 	wrl(pep, ETH_C_TX_DESC_1,
-	    (u32) ((struct tx_desc *)pep->tx_desc_dma + tx_curr_desc));
+	    (u32) (pep->tx_desc_dma + tx_curr_desc * sizeof(struct tx_desc)));
 
 	/* Assignment of Rx CRDP of given queue */
 	rx_curr_desc = pep->rx_curr_desc_q;
 	wrl(pep, ETH_C_RX_DESC_0,
-	    (u32) ((struct rx_desc *)pep->rx_desc_dma + rx_curr_desc));
+	    (u32) (pep->rx_desc_dma + rx_curr_desc * sizeof(struct rx_desc)));
 
 	wrl(pep, ETH_F_RX_DESC_0,
-	    (u32) ((struct rx_desc *)pep->rx_desc_dma + rx_curr_desc));
+	    (u32) (pep->rx_desc_dma + rx_curr_desc * sizeof(struct rx_desc)));
 
 	/* Clear all interrupts */
 	wrl(pep, INT_CAUSE, 0);
maintainer Applied
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Tue, 24 Aug 2010 18:55:05 +0200

Quoted 7 lines

Casting "pep->tx_desc_dma" to to a struct tx_desc pointer makes gcc complain:

drivers/net/pxa168_eth.c:657: warning:
cast to pointer from integer of different size

Applied.