Skip to contentSkip to conversation

MX3x: clean kpp resource structure definitions

PATCH New Michael Grzeschik 4 participants 4 messages Aug 24, 2010

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Michael Grzeschik

author
#0 lore raw

PATCH 1/1 MX3x: clean kpp resource structure definitions

Signed-off-by Michael Grzeschik <[email protected]>
---
 arch/arm/mach-mx3/devices.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-mx3/devices.c +5 -5
index a4fd1a2..a3e0fe2 100644
@@ -374,12 +374,12 @@ struct platform_device imx_rtc_device0 = {
 
 static struct resource imx_kpp_resources[] = {
 	{
-		.start	= MX3x_KPP_BASE_ADDR,
-		.end	= MX3x_KPP_BASE_ADDR + 0xf,
-		.flags	= IORESOURCE_MEM
+		.start	= KPP_BASE_ADDR,
+		.end	= KPP_BASE_ADDR + SZ_4K - 1,
+		.flags	= IORESOURCE_MEM,
 	}, {
-		.start	= MX3x_INT_KPP,
-		.end	= MX3x_INT_KPP,
+		.start	= MXC_INT_KPP,
+		.end	= MXC_INT_KPP,
 		.flags	= IORESOURCE_IRQ,
 	},
 };
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 MX3x: clean kpp resource structure definitions

Hallo Michael,

Quoted 17 lines · Michael Grzeschik
Signed-off-by Michael Grzeschik <[email protected]>
---
 arch/arm/mach-mx3/devices.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-mx3/devices.c +1 -3
index a4fd1a2..a3e0fe2 100644
@@ -374,12 +374,12 @@ struct platform_device imx_rtc_device0 = {
 
 static struct resource imx_kpp_resources[] = {
 	{
-		.start	= MX3x_KPP_BASE_ADDR,
-		.end	= MX3x_KPP_BASE_ADDR + 0xf,
-		.flags	= IORESOURCE_MEM
+		.start	= KPP_BASE_ADDR,

arch/arm/mach-mx3/devices.c struct platform_device imx_rtc_device0 = { · line 385

Quoted 10 lines
arch/arm/mach-mx3/devices.c +4 -2
+		.end	= KPP_BASE_ADDR + SZ_4K - 1,
+		.flags	= IORESOURCE_MEM,
 	}, {
-		.start	= MX3x_INT_KPP,
-		.end	= MX3x_INT_KPP,
+		.start	= MXC_INT_KPP,
+		.end	= MXC_INT_KPP,
 		.flags	= IORESOURCE_IRQ,
 	},
 };

what ist the exact problem you want to fix? I'm OK with adding that comma and using SZ_4K (assuming you checked it in the reference manuals). But why s/MX3x_KPP_BASE_ADDR/KPP_BASE_ADDR/ ?

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#2 lore raw

PATCH 1/1 MX3x: clean kpp resource structure definitions

Hallo Uwe,

Quoted 26 lines · Uwe Kleine-K?nig

Hallo Michael,

Quoted 23 lines · Michael Grzeschik
Signed-off-by Michael Grzeschik <[email protected]>
---
 arch/arm/mach-mx3/devices.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-mx3/devices.c +4 -5
index a4fd1a2..a3e0fe2 100644
@@ -374,12 +374,12 @@ struct platform_device imx_rtc_device0 = {
 
 static struct resource imx_kpp_resources[] = {
 	{
-		.start	= MX3x_KPP_BASE_ADDR,
-		.end	= MX3x_KPP_BASE_ADDR + 0xf,
-		.flags	= IORESOURCE_MEM
+		.start	= KPP_BASE_ADDR,
+		.end	= KPP_BASE_ADDR + SZ_4K - 1,
+		.flags	= IORESOURCE_MEM,
 	}, {
-		.start	= MX3x_INT_KPP,
-		.end	= MX3x_INT_KPP,
+		.start	= MXC_INT_KPP,
Quoted 8 lines

arch/arm/mach-mx3/devices.c struct platform_device imx_rtc_device0 = { · line 385

Quoted 4 lines
arch/arm/mach-mx3/devices.c +1 -0
+		.end	= MXC_INT_KPP,
 		.flags	= IORESOURCE_IRQ,
 	},
 };

what ist the exact problem you want to fix?
I'm OK with adding that
comma and using SZ_4K (assuming you checked it in the reference manuals).

Yes i looked for it in the reference manuals. So it should be ok.

Quoted 1 line

But why s/MX3x_KPP_BASE_ADDR/KPP_BASE_ADDR/ ?

I didn't see that in mx3x.h these Symbols are defined as deprecated. So you are right and we better stay with the MX3x_* Prefix.

I think you could take the SZ_4K into one of your patches when you are going to touch the devices.c again. Or do you prefer a oneline patch?

Michael

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

PATCH 1/1 MX3x: clean kpp resource structure definitions

In reply to Uwe Kleine-König
Quoted 24 lines · Uwe Kleine-K?nig

Hallo Michael,

Quoted 20 lines · Michael Grzeschik
Signed-off-by Michael Grzeschik <[email protected]>
---
 arch/arm/mach-mx3/devices.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-mx3/devices.c +3 -3
index a4fd1a2..a3e0fe2 100644
@@ -374,12 +374,12 @@ struct platform_device imx_rtc_device0 = {
 
 static struct resource imx_kpp_resources[] = {
 	{
-		.start	= MX3x_KPP_BASE_ADDR,
-		.end	= MX3x_KPP_BASE_ADDR + 0xf,
-		.flags	= IORESOURCE_MEM
+		.start	= KPP_BASE_ADDR,
+		.end	= KPP_BASE_ADDR + SZ_4K - 1,
+		.flags	= IORESOURCE_MEM,
 	}, {
Quoted 8 lines

arch/arm/mach-mx3/devices.c struct platform_device imx_rtc_device0 = { · line 385

Quoted 8 lines
arch/arm/mach-mx3/devices.c +2 -2
-		.start	= MX3x_INT_KPP,
-		.end	= MX3x_INT_KPP,
+		.start	= MXC_INT_KPP,
+		.end	= MXC_INT_KPP,
 		.flags	= IORESOURCE_IRQ,
 	},
 };

:) The final goal is to build all i.MX platforms into a single kernel, your change will add troubles for that.

Regards,
Jason.

Quoted 8 lines

what ist the exact problem you want to fix? I'm OK with adding that comma and using SZ_4K (assuming you checked it in the reference manuals). But why s/MX3x_KPP_BASE_ADDR/KPP_BASE_ADDR/ ?

Best regards
Uwe