Skip to contentSkip to conversation

xenpaging: call pageout policy function in xenpaging_evict_page

PATCH In review Olaf Hering 3 participants 3 messages Aug 24, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xenpaging: call pageout policy function in xenpaging_evict_page

Notify policy about a page that was just paged out to disk. Up to now the code called the opposite function, which clears the (xenpaging internal) reference bit, instead of setting it and marking the page as gone.

tools/xenpaging/xenpaging.c +2 -2
@@ -361,8 +361,8 @@ int xenpaging_evict_page(xc_interface *x
         goto out;
     }
 
-    /* Notify policy of page being paged in */
-    policy_notify_paged_in(paging->mem_event.domain_id, victim->gfn);
+    /* Notify policy of page being paged out */
+    policy_notify_paged_out(paging->mem_event.domain_id, victim->gfn);
 
  out:
     return ret;
#1 lore raw

Olaf Hering writes ("[Xen-devel] [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page"):

Quoted 6 lines

Notify policy about a page that was just paged out to disk. Up to now the code called the opposite function, which clears the (xenpaging internal) reference bit, instead of setting it and marking the page as gone.

This looks plausible but as I don't really understand the xenpaging code I'd like an ack from Patrick. Patrick ?

Thanks,
Ian.

Acked-by
#2 lore raw

Yes, this patch is correct.

Patrick

Quoted 15 lines · Ian Jackson

Olaf Hering writes ("[Xen-devel] [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page"):

Quoted 6 lines

Notify policy about a page that was just paged out to disk. Up to now the code called the opposite function, which clears the (xenpaging internal) reference bit, instead of setting it and marking the page as gone.

This looks plausible but as I don't really understand the xenpaging code I'd like an ack from Patrick.  Patrick ?

Thanks,
Ian.