mtd/pcmciamtd: remove dead code

PATCH Applied Dan Carpenter 3 participants 3 messages Aug 24, 2010 – Aug 30, 2010

Subsystems (2)

Kernel janitors Memory technology devices (MTD)

lore

Share & tools

lore

Dan Carpenter

author

2010-08-24 11:56 UTC #0 lore raw

PATCH 1/1 mtd/pcmciamtd: remove dead code

This code isn't reachable. I looked through the git history and it hasn't been reachable for years. Someone removed the label to silence gcc's unused label warning but these few lines accidentally got left behind.

Signed-off-by Dan Carpenter <[email protected]>

drivers/mtd/maps/pcmciamtd.c +0 -4

index e9ca5ba..86c7468 100644
@@ -654,10 +654,6 @@ static int pcmciamtd_config(struct pcmcia_device *link)
 	}
 	dev_info(&dev->p_dev->dev, "mtd%d: %s\n", mtd->index, mtd->name);
 	return 0;
-
-	dev_err(&dev->p_dev->dev, "CS Error, exiting\n");
-	pcmciamtd_release(link);
-	return -ENODEV;
 }

Dominik Brodowski

Acked-by on v1 1/1

2010-08-29 19:15 UTC #1 lore raw

Quoted 6 lines · Dan Carpenter

This code isn't reachable. I looked through the git history and it hasn't been reachable for years. Someone removed the label to silence gcc's unused label warning but these few lines accidentally got left behind.
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Dominik Brodowski <[email protected]>

Thanks,
Dominik

Artem Bityutskiy

Applied

2010-08-30 13:17 UTC #2 lore raw

In reply to Dan Carpenter

Quoted 6 lines · Dan Carpenter

This code isn't reachable. I looked through the git history and it hasn't been reachable for years. Someone removed the label to silence gcc's unused label warning but these few lines accidentally got left behind.
Signed-off-by Dan Carpenter <[email protected]>

Pushed to l2-mtd-2.6.git / master, thanks.

Signature · 2 lines

Best Regards,
Artem Bityutskiy (Битюцкий Артём)