Skip to contentSkip to conversation

ceph: ceph_get_inode() returns an ERR_PTR

PATCH In review Dan Carpenter 2 participants 2 messages Aug 25, 2010

Subsystems (2)
Kernel janitors Ceph client
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ceph: ceph_get_inode() returns an ERR_PTR

ceph_get_inode() returns an ERR_PTR and it doesn't return a NULL.

Signed-off-by Dan Carpenter <[email protected]>
fs/ceph/inode.c +2 -2
index 5d893d3..1e623ec 100644
@@ -1229,11 +1229,11 @@ retry_lookup:
 			in = dn->d_inode;
 		} else {
 			in = ceph_get_inode(parent->d_sb, vino);
-			if (in = NULL) {
+			if (IS_ERR(in)) {
 				dout("new_inode badness\n");
 				d_delete(dn);
 				dput(dn);
-				err = -ENOMEM;
+				err = PTR_ERR(in);
 				goto out;
 			}
 			dn = splice_dentry(dn, in, NULL);
#1 lore raw

Thanks, queueing this up!

sage

Quoted 28 lines · Dan Carpenter

ceph_get_inode() returns an ERR_PTR and it doesn't return a NULL.

Signed-off-by Dan Carpenter <[email protected]>
fs/ceph/inode.c +2 -3
index 5d893d3..1e623ec 100644
@@ -1229,11 +1229,11 @@ retry_lookup:
 			in = dn->d_inode;
 		} else {
 			in = ceph_get_inode(parent->d_sb, vino);
-			if (in == NULL) {
+			if (IS_ERR(in)) {
 				dout("new_inode badness\n");
 				d_delete(dn);
 				dput(dn);
-				err = -ENOMEM;
+				err = PTR_ERR(in);
 				goto out;
 			}
 			dn = splice_dentry(dn, in, NULL);
--

To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html