Skip to contentSkip to conversation

be2net: remove a BUG_ON in be_cmds.c

PATCH Applied Ajit Khaparde 2 participants 2 messages Aug 25, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ajit Khaparde

author
#0 lore raw

PATCH 3/3 be2net: remove a BUG_ON in be_cmds.c

Async notifications other than link status are possible in certain configurations. Remove the BUG_ON in the mcc completion processing path.

Signed-off-by Ajit Khaparde <[email protected]>
---
 drivers/net/benet/be_cmds.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
drivers/net/benet/be_cmds.c +2 -4
index 3d30549..22bd062 100644
@@ -140,10 +140,8 @@ int be_process_mcc(struct be_adapter *adapter, int *status)
 	while ((compl = be_mcc_compl_get(adapter))) {
 		if (compl->flags & CQE_FLAGS_ASYNC_MASK) {
 			/* Interpret flags as an async trailer */
-			BUG_ON(!is_link_state_evt(compl->flags));
-
-			/* Interpret compl as a async link evt */
-			be_async_link_state_process(adapter,
+			if (is_link_state_evt(compl->flags))
+				be_async_link_state_process(adapter,
 				(struct be_async_event_link_state *) compl);
 		} else if (compl->flags & CQE_FLAGS_COMPLETED_MASK) {
 				*status = be_mcc_compl_process(adapter, compl);
Signature · 1 line
1.7.0.4