missplaced sock_put(sk)

PATCH In review Bernard F6BVP 2 participants 2 messages Aug 26, 2010

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Bernard F6BVP

author

2010-08-26 19:34 UTC #0 lore raw

PATCH 1/1 missplaced sock_put(sk)

[PATCH] [AX25] missplaced sock_put(sk)

This patch moves a missplaced sock_put(sk) after
bh_unlock_sock(sk)
like in other parts of AX25 driver.

Bernard Pidoux

net/ax25/ax25_ds_timer.c +1 -1

@@ -112,8 +112,8 @@
 			if (sk) {
 				sock_hold(sk);
 				ax25_destroy_socket(ax25);
-				sock_put(sk);
 				bh_unlock_sock(sk);
+				sock_put(sk);
 			} else
 				ax25_destroy_socket(ax25);
 			return;

David Miller

maintainer

2010-08-26 21:09 UTC #1 lore raw

From: Bernard F6BVP <[email protected]>
Date: Thu, 26 Aug 2010 21:34:32 +0200

Quoted 7 lines

[PATCH] [AX25] missplaced sock_put(sk)
This patch moves a missplaced sock_put(sk) after
bh_unlock_sock(sk)
like in other parts of AX25 driver.
Bernard Pidoux

Please resubmit this with a proper "Signed-off-by: " tag as-per Documentation/SubmittingPatches