Skip to contentSkip to conversation

i2c-pxa: Squash warning about discarding qualifier

PATCH New Marek Vasut 4 participants 6 messages Aug 26, 2010 – Aug 27, 2010 I2C subsystem host drivers

lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 i2c-pxa: Squash warning about discarding qualifier

Signed-off-by Marek Vasut <[email protected]>
---
 drivers/i2c/busses/i2c-pxa.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-pxa.c +1 -1
index 020ff23..c94e51b 100644
@@ -1001,7 +1001,7 @@ static int i2c_pxa_probe(struct platform_device *dev)
 	struct pxa_i2c *i2c;
 	struct resource *res;
 	struct i2c_pxa_platform_data *plat = dev->dev.platform_data;
-	struct platform_device_id *id = platform_get_device_id(dev);
+	const struct platform_device_id *id = platform_get_device_id(dev);
 	int ret;
 	int irq;
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 i2c-pxa: Squash warning about discarding qualifier

Quoted 1 line · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>

Ack.

Jean & Ben, anyone help merge?

Quoted 21 lines

---
?drivers/i2c/busses/i2c-pxa.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

drivers/i2c/busses/i2c-pxa.c +1 -2
index 020ff23..c94e51b 100644
@@ -1001,7 +1001,7 @@ static int i2c_pxa_probe(struct platform_device *dev)
 ? ? ? ?struct pxa_i2c *i2c;
 ? ? ? ?struct resource *res;
 ? ? ? ?struct i2c_pxa_platform_data *plat = dev->dev.platform_data;
- ? ? ? struct platform_device_id *id = platform_get_device_id(dev);
+ ? ? ? const struct platform_device_id *id = platform_get_device_id(dev);
 ? ? ? ?int ret;
 ? ? ? ?int irq;
 
--

1.7.1

#2 lore raw

PATCH 1/1 i2c-pxa: Squash warning about discarding qualifier

Quoted 6 lines · Eric Miao
Quoted 1 line · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>

Ack.

Jean & Ben, anyone help merge?

i2c-pxa is embedded -> Ben.

Quoted 22 lines
Quoted 22 lines

---
?drivers/i2c/busses/i2c-pxa.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

drivers/i2c/busses/i2c-pxa.c +1 -2
index 020ff23..c94e51b 100644
@@ -1001,7 +1001,7 @@ static int i2c_pxa_probe(struct platform_device *dev)
 ? ? ? ?struct pxa_i2c *i2c;
 ? ? ? ?struct resource *res;
 ? ? ? ?struct i2c_pxa_platform_data *plat = dev->dev.platform_data;
- ? ? ? struct platform_device_id *id = platform_get_device_id(dev);
+ ? ? ? const struct platform_device_id *id = platform_get_device_id(dev);
 ? ? ? ?int ret;
 ? ? ? ?int irq;
 
--

1.7.1

Signature · 1 line
Jean Delvare
#3 lore raw

PATCH 1/1 i2c-pxa: Squash warning about discarding qualifier

In reply to Marek Vasut
Quoted 10 lines · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>
---
 drivers/i2c/busses/i2c-pxa.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-pxa.c +0 -0
index 020ff23..c94e51b 100644

drivers/i2c/busses/i2c-pxa.c static int i2c_pxa_probe(struct platform_device *dev) · line 1006

Quoted 7 lines
drivers/i2c/busses/i2c-pxa.c +1 -1
@@ -1001,7 +1001,7 @@ static int i2c_pxa_probe(struct platform_device *dev)
 	struct pxa_i2c *i2c;
 	struct resource *res;
 	struct i2c_pxa_platform_data *plat = dev->dev.platform_data;
-	struct platform_device_id *id = platform_get_device_id(dev);
+	const struct platform_device_id *id = platform_get_device_id(dev);
 	int ret;
 	int irq;

This is already in mainline:

http://git.kernel.org/linus/21e2ecfe19df8f28408b5a607fef8704f51fa7f8

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#4 lore raw

PATCH 1/1 i2c-pxa: Squash warning about discarding qualifier

2010/8/27 Uwe Kleine-K?nig <[email protected]>:

Quoted 20 lines · Marek Vasut
Quoted 10 lines
Signed-off-by Marek Vasut <[email protected]>

---
?drivers/i2c/busses/i2c-pxa.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

drivers/i2c/busses/i2c-pxa.c +0 -0
index 020ff23..c94e51b 100644

drivers/i2c/busses/i2c-pxa.c static int i2c_pxa_probe(struct platform_device *dev) · line 1006

Quoted 7 lines
drivers/i2c/busses/i2c-pxa.c +1 -1
@@ -1001,7 +1001,7 @@ static int i2c_pxa_probe(struct platform_device *dev)
 ? ? ? struct pxa_i2c *i2c;
 ? ? ? struct resource *res;
 ? ? ? struct i2c_pxa_platform_data *plat = dev->dev.platform_data;
- ? ? struct platform_device_id *id = platform_get_device_id(dev);
+ ? ? const struct platform_device_id *id = platform_get_device_id(dev);
 ? ? ? int ret;
 ? ? ? int irq;

This is already in mainline:

Quoted 2 lines

http://git.kernel.org/linus/21e2ecfe19df8f28408b5a607fef8704f51fa7f8

Cool, no bother then.

author
#5 lore raw

PATCH 1/1 i2c-pxa: Squash warning about discarding qualifier

In reply to Uwe Kleine-König

Dne P? 27. srpna 2010 07:35:47 Uwe Kleine-K?nig napsal(a):

Quoted 21 lines · Marek Vasut
Quoted 20 lines
Signed-off-by Marek Vasut <[email protected]>

---

 drivers/i2c/busses/i2c-pxa.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-pxa.c +1 -1
index 020ff23..c94e51b 100644
@@ -1001,7 +1001,7 @@ static int i2c_pxa_probe(struct platform_device
 *dev)
 
 	struct pxa_i2c *i2c;
 	struct resource *res;
 	struct i2c_pxa_platform_data *plat = dev->dev.platform_data;
 
-	struct platform_device_id *id = platform_get_device_id(dev);
+	const struct platform_device_id *id = platform_get_device_id(dev);
Quoted 6 lines

drivers/i2c/busses/i2c-pxa.c static int i2c_pxa_probe(struct platform_device *dev) · line 1006

Quoted 2 lines
drivers/i2c/busses/i2c-pxa.c +0 -0
 	int ret;
 	int irq;

This is already in mainline:

http://git.kernel.org/linus/21e2ecfe19df8f28408b5a607fef8704f51fa7f8

Eric, we need tree update here :)

Cheers