Skip to contentSkip to conversation

mthca: Adapt to API changes in the core for UD packing

PATCH In review Eli Cohen 2 participants 2 messages Aug 26, 2010 – Aug 27, 2010 InfiniBand

lore
Share & tools
lore

Eli Cohen

author
#0 lore raw

PATCH v10 5/12 mthca: Adapt to API changes in the core for UD packing

This is done to synchronize mthca with the API changes.

---
 drivers/infiniband/hw/mthca/mthca_qp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/infiniband/hw/mthca/mthca_qp.c +1 -1
index d2d172e..1a1c55f 100644
@@ -1493,7 +1493,7 @@ static int build_mlx_header(struct mthca_dev *dev, struct mthca_sqp *sqp,
 	int err;
 	u16 pkey;
 
-	ib_ud_header_init(256, /* assume a MAD */
+	ib_ud_header_init(256, /* assume a MAD */ 1, 0,
 			  mthca_ah_grh_present(to_mah(wr->wr.ud.ah)), 0,
 			  &sqp->ud_header);
 
Signature · 6 lines
1.7.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw

In the future, please don't have patches that break compilation. If you change an API, then change all users of that API in the same patch. It's really annoying for someone who is trying to bisect something (possibly something completely unrelated) to land at a point in history that doesn't even build.

So if there's another spin of this patchset, please fold all the "adapt to new API" patches into the main "change API" patches. You don't have to resend just for that though, I can handle it if I apply these.

- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html