MTD: OneNAND: Fix OneNAND DMA error handling and 2KiB pagesize
cover MTD: OneNAND: Fix OneNAND DMA error handling and 2KiB pagesize
Kyungmin Park (3):
MTD: OneNAND: Remove unused cmd_map at s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCs
drivers/mtd/onenand/samsung.c | 17 +++++++---------- 1 files changed, 7 insertions(+), 10 deletions(-)
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++---------- 1 files changed, 7 insertions(+), 10 deletions(-)
Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
Signature · 2 lines
Best Regards, Artem Bityutskiy (Битюцкий Артём)
Quoted 11 lines · Artem Bityutskiy
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++----------
1 files changed, 7 insertions(+), 10 deletions(-)Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
To David, Artem,
Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.
How do you think?
Thank you,
Kyungmin Park
Quoted 6 lines
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
Quoted 10 lines · Kyungmin Park
Quoted 9 lines · Artem Bityutskiy
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++---------- 1 files changed, 7 insertions(+), 10 deletions(-)
Quoted 7 lines
Quoted 2 lines
Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
To David, Artem,
Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.How do you think?
Note, Linus nowadays tends to be stricter about what goes in -rc. Why would the first patch be a fix deserving urgent merging?
About the second patch, what if you was mistaken and 20msces is not enough sometimes? Don't you afraid to introduce another bug with this?
Probably for 2.6.36 the older version of your patch can be merged, and then you can add timeout support on top?
Third patch is probably ok, if you really want it in 2.6.36.
So, I've moved the third patch to l2-mtd-2.6.git / for-2.6.36, I've left the first patch in the dunno branch, and I also put the original version of the second patch to the for-2.6.36 branch.
Please, add timeout on top of l2-mtd-2.6.git / for-2.6.36 and send it. I'll then take care of it, or at least try.
Signature · 2 lines
Best Regards, Artem Bityutskiy (Битюцкий Артём)
Quoted 14 lines · Artem Bityutskiy
Quoted 13 lines · Kyungmin Park
Quoted 11 lines · Artem Bityutskiy
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++----------
1 files changed, 7 insertions(+), 10 deletions(-)Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
Quoted 7 lines
Quoted 4 lines
To David, Artem,
Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.How do you think?
Note, Linus nowadays tends to be stricter about what goes in -rc. Why would the first patch be a fix deserving urgent merging?
There's no problem with s5pc110 since there's no DMA error. but new SOC s5pc210 has some problem with DMA.
it occurs the DMA error and can't exit the loop. as it's decided to use the 2.6.36 for s5pc210 we need to fix it ASAP.
Quoted 3 lines
About the second patch, what if you was mistaken and 20msces is not enough sometimes? Don't you afraid to introduce another bug with this?
If it takes more then 20msec it's really slow device. I think I give the enough time to transfer 2KiB or 4KiB pagesize transfer at DMA.
I'll measure the real time, how much time taken at 2.6.35 kernel and give exact number.
Quoted 3 lines
Probably for 2.6.36 the older version of your patch can be merged, and then you can add timeout support on top?
Now I implemented it as DMA polling method, but also implemented the DMA interrupt codes. as it's new implementation. I don't expect it can't merge at this windows. so send fixed codes.
Quoted 9 lines
Third patch is probably ok, if you really want it in 2.6.36.
So, I've moved the third patch to l2-mtd-2.6.git / for-2.6.36, I've left the first patch in the dunno branch, and I also put the original version of the second patch to the for-2.6.36 branch.
Please, add timeout on top of l2-mtd-2.6.git / for-2.6.36 and send it. I'll then take care of it, or at least try.
Thank you,
Kyungmin Park
Quoted 6 lines
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
Quoted 29 lines · Kyungmin Park
Quoted 14 lines · Artem Bityutskiy
Quoted 13 lines · Kyungmin Park
Quoted 11 lines · Artem Bityutskiy
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++----------
1 files changed, 7 insertions(+), 10 deletions(-)Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
Quoted 7 lines
Quoted 4 lines
To David, Artem,
Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.How do you think?
Note, Linus nowadays tends to be stricter about what goes in -rc. Why would the first patch be a fix deserving urgent merging?
There's no problem with s5pc110 since there's no DMA error. but new SOC s5pc210 has some problem with DMA.
it occurs the DMA error and can't exit the loop. as it's decided to use the 2.6.36 for s5pc210 we need to fix it ASAP.Quoted 1 line
Quoted 7 lines
Quoted 2 lines
About the second patch, what if you was mistaken and 20msces is not enough sometimes? Don't you afraid to introduce another bug with this?
If it takes more then 20msec it's really slow device. I think I give the enough time to transfer 2KiB or 4KiB pagesize transfer at DMA.
I'll measure the real time, how much time taken at 2.6.35 kernel and give exact number.
Unit is usec, so it takes 20 usec for 2KiB pagesize transfer. I use the msec for some board don't implement the HRT or based on 10msec timer. I give the 2 chances. As 10 msec can miss the time.
[ 11.402082] s5pc210_dma_ops[575] 19 [ 11.404445] s5pc210_dma_ops[575] 21 [ 11.408790] s5pc210_dma_ops[575] 21 [ 11.415221] s5pc210_dma_ops[575] 22 [ 11.417433] s5pc210_dma_ops[575] 19 [ 11.420867] s5pc210_dma_ops[575] 21 [ 11.427553] s5pc210_dma_ops[575] 22 [ 11.429736] s5pc210_dma_ops[575] 21 [ 11.435615] s5pc210_dma_ops[575] 19 [ 11.437885] s5pc210_dma_ops[575] 21 [ 11.443540] s5pc210_dma_ops[575] 21 [ 11.445726] s5pc210_dma_ops[575] 21 [ 11.487652] s5pc210_dma_ops[575] 20 [ 11.501755] s5pc210_dma_ops[575] 22 [ 11.503941] s5pc210_dma_ops[575] 21 [ 11.508539] s5pc210_dma_ops[575] 21 [ 11.510879] s5pc210_dma_ops[575] 19 [ 11.515527] s5pc210_dma_ops[575] 21 [ 11.517840] s5pc210_dma_ops[575] 19 [ 11.521170] s5pc210_dma_ops[575] 19 [ 11.526044] s5pc210_dma_ops[575] 21 [ 11.575904] s5pc210_dma_ops[575] 19
Quoted 28 lines
Quoted 4 lines
Probably for 2.6.36 the older version of your patch can be merged, and then you can add timeout support on top?
Now I implemented it as DMA polling method, but also implemented the DMA interrupt codes. as it's new implementation. I don't expect it can't merge at this windows. so send fixed codes.
Quoted 9 lines
Third patch is probably ok, if you really want it in 2.6.36.
So, I've moved the third patch to l2-mtd-2.6.git / for-2.6.36, I've left the first patch in the dunno branch, and I also put the original version of the second patch to the for-2.6.36 branch.
Please, add timeout on top of l2-mtd-2.6.git / for-2.6.36 and send it. I'll then take care of it, or at least try.
Thank you,
Kyungmin ParkQuoted 6 lines
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
Quoted 38 lines · Kyungmin Park
Quoted 14 lines · Artem Bityutskiy
Quoted 13 lines · Kyungmin Park
Quoted 11 lines · Artem Bityutskiy
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++---------- 1 files changed, 7 insertions(+), 10 deletions(-)Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
Quoted 7 lines
Quoted 4 lines
To David, Artem,
Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.How do you think?
Note, Linus nowadays tends to be stricter about what goes in -rc. Why would the first patch be a fix deserving urgent merging?
There's no problem with s5pc110 since there's no DMA error. but new SOC s5pc210 has some problem with DMA.
it occurs the DMA error and can't exit the loop. as it's decided to use the 2.6.36 for s5pc210 we need to fix it ASAP.Quoted 3 lines
About the second patch, what if you was mistaken and 20msces is not enough sometimes? Don't you afraid to introduce another bug with this?
If it takes more then 20msec it's really slow device. I think I give the enough time to transfer 2KiB or 4KiB pagesize transfer at DMA.
I'll measure the real time, how much time taken at 2.6.35 kernel and give exact number.
Quoted 1 line
Quoted 6 lines
Quoted 2 lines
Probably for 2.6.36 the older version of your patch can be merged, and then you can add timeout support on top?
Now I implemented it as DMA polling method, but also implemented the DMA interrupt codes. as it's new implementation. I don't expect it can't merge at this windows. so send fixed codes.
I am not sure I completely understand what you mean. but lets play safe and merge your original version, because it is small and just fixes the problem. Adding timeout is an improvement, and for this very simple reason it should not go to 2.6.36.
Please, clone my l2 tree
(http://git.infradead.org/users/dedekind/l2-mtd-2.6.git), checkout the 'for-2.6.36' branch, add timeout, and send it to me as as a separate independent patch. I'll take care of it then.
Would you do this please?
Signature · 2 lines
Best Regards, Artem Bityutskiy (Битюцкий Артём)
Quoted 51 lines · Artem Bityutskiy
Quoted 38 lines · Kyungmin Park
Quoted 14 lines · Artem Bityutskiy
Quoted 13 lines · Kyungmin Park
Quoted 11 lines · Artem Bityutskiy
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++----------
1 files changed, 7 insertions(+), 10 deletions(-)Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
Quoted 7 lines
Quoted 4 lines
To David, Artem,
Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.How do you think?
Note, Linus nowadays tends to be stricter about what goes in -rc. Why would the first patch be a fix deserving urgent merging?
There's no problem with s5pc110 since there's no DMA error. but new SOC s5pc210 has some problem with DMA.
it occurs the DMA error and can't exit the loop. as it's decided to use the 2.6.36 for s5pc210 we need to fix it ASAP.Quoted 3 lines
About the second patch, what if you was mistaken and 20msces is not enough sometimes? Don't you afraid to introduce another bug with this?
If it takes more then 20msec it's really slow device. I think I give the enough time to transfer 2KiB or 4KiB pagesize transfer at DMA.
I'll measure the real time, how much time taken at 2.6.35 kernel and give exact number.
Quoted 1 line
Quoted 6 lines
Quoted 2 lines
Probably for 2.6.36 the older version of your patch can be merged, and then you can add timeout support on top?
Now I implemented it as DMA polling method, but also implemented the DMA interrupt codes. as it's new implementation. I don't expect it can't merge at this windows. so send fixed codes.
I am not sure I completely understand what you mean. but lets play safe and merge your original version, because it is small and just fixes the problem. Adding timeout is an improvement, and for this very simple reason it should not go to 2.6.36.
Quoted 6 lines
Please, clone my l2 tree
(http://git.infradead.org/users/dedekind/l2-mtd-2.6.git), checkout the 'for-2.6.36' branch, add timeout, and send it to me as as a separate independent patch. I'll take care of it then.Would you do this please?
No problem,
Thank you,
Kyungmin Park
Quoted 6 lines
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
Quoted 52 lines · Kyungmin Park
Quoted 51 lines · Artem Bityutskiy
Quoted 38 lines · Kyungmin Park
Quoted 14 lines · Artem Bityutskiy
Quoted 13 lines · Kyungmin Park
Quoted 11 lines · Artem Bityutskiy
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++---------- 1 files changed, 7 insertions(+), 10 deletions(-)Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
Quoted 7 lines
Quoted 4 lines
To David, Artem,
Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.How do you think?
Note, Linus nowadays tends to be stricter about what goes in -rc. Why would the first patch be a fix deserving urgent merging?
There's no problem with s5pc110 since there's no DMA error. but new SOC s5pc210 has some problem with DMA.
it occurs the DMA error and can't exit the loop. as it's decided to use the 2.6.36 for s5pc210 we need to fix it ASAP.Quoted 3 lines
About the second patch, what if you was mistaken and 20msces is not enough sometimes? Don't you afraid to introduce another bug with this?
If it takes more then 20msec it's really slow device. I think I give the enough time to transfer 2KiB or 4KiB pagesize transfer at DMA.
I'll measure the real time, how much time taken at 2.6.35 kernel and give exact number.
Quoted 1 line
Quoted 6 lines
Quoted 2 lines
Probably for 2.6.36 the older version of your patch can be merged, and then you can add timeout support on top?
Now I implemented it as DMA polling method, but also implemented the DMA interrupt codes. as it's new implementation. I don't expect it can't merge at this windows. so send fixed codes.
I am not sure I completely understand what you mean. but lets play safe and merge your original version, because it is small and just fixes the problem. Adding timeout is an improvement, and for this very simple reason it should not go to 2.6.36.
Quoted 8 lines
Quoted 6 lines
Please, clone my l2 tree
(http://git.infradead.org/users/dedekind/l2-mtd-2.6.git), checkout the 'for-2.6.36' branch, add timeout, and send it to me as as a separate independent patch. I'll take care of it then.Would you do this please?
No problem,
Still waiting for the patch which adds timeout.
Signature · 2 lines
Best Regards, Artem Bityutskiy (Битюцкий Артём)
Hi,
Sorry for late reply. it's holiday at korea.
I posted some fixes and improvements.
you can find onenand patches at git here.
http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/heads/onenand
Thank you,
Kyungmin Park
Quoted 69 lines · Artem Bityutskiy
Quoted 52 lines · Kyungmin Park
Quoted 51 lines · Artem Bityutskiy
Quoted 38 lines · Kyungmin Park
Quoted 14 lines · Artem Bityutskiy
Quoted 13 lines · Kyungmin Park
Quoted 11 lines · Artem Bityutskiy
Quoted 7 lines · Kyungmin Park
Kyungmin Park (3):
MTD: OneNAND: Remove unusedcmd_mapat s5pc110
MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCsdrivers/mtd/onenand/samsung.c | 17 +++++++----------
1 files changed, 7 insertions(+), 10 deletions(-)Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1 and 3 to l2-mtd-2.6.git / dunno, thanks.
Quoted 7 lines
Quoted 4 lines
To David, Artem,
Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.How do you think?
Note, Linus nowadays tends to be stricter about what goes in -rc. Why would the first patch be a fix deserving urgent merging?
There's no problem with s5pc110 since there's no DMA error. but new SOC s5pc210 has some problem with DMA.
it occurs the DMA error and can't exit the loop. as it's decided to use the 2.6.36 for s5pc210 we need to fix it ASAP.Quoted 3 lines
About the second patch, what if you was mistaken and 20msces is not enough sometimes? Don't you afraid to introduce another bug with this?
If it takes more then 20msec it's really slow device. I think I give the enough time to transfer 2KiB or 4KiB pagesize transfer at DMA.
I'll measure the real time, how much time taken at 2.6.35 kernel and give exact number.
Quoted 1 line
Quoted 6 lines
Quoted 2 lines
Probably for 2.6.36 the older version of your patch can be merged, and then you can add timeout support on top?
Now I implemented it as DMA polling method, but also implemented the DMA interrupt codes. as it's new implementation. I don't expect it can't merge at this windows. so send fixed codes.
I am not sure I completely understand what you mean. but lets play safe and merge your original version, because it is small and just fixes the problem. Adding timeout is an improvement, and for this very simple reason it should not go to 2.6.36.
Quoted 8 lines
Quoted 6 lines
Please, clone my l2 tree
(http://git.infradead.org/users/dedekind/l2-mtd-2.6.git), checkout the 'for-2.6.36' branch, add timeout, and send it to me as as a separate independent patch. I'll take care of it then.Would you do this please?
No problem,
Still waiting for the patch which adds timeout.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)