Skip to contentSkip to conversation

au1xmmc.c: use resource_size()

PATCH New H Hartley Sweeten 4 participants 5 messages Dec 14, 2009 – Aug 27, 2010

Subsystems (2)
MMC, SD and SDIO Alchemy AU1XX0 MMC driver
lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 au1xmmc.c: use resource_size()

Use resource_size().

Signed-off-by H Hartley Sweeten <[email protected]>

---

drivers/mmc/host/au1xmmc.c +1 -1
index d3f5561..2d2119b 100644
@@ -963,7 +963,7 @@ static int __devinit au1xmmc_probe(struct platform_device *pdev)
 		goto out1;
 	}
 
-	host->ioarea = request_mem_region(r->start, r->end - r->start + 1,
+	host->ioarea = request_mem_region(r->start, resource_size(r),
 					   pdev->name);
 	if (!host->ioarea) {
 		dev_err(&pdev->dev, "mmio already in use\n");
#1 lore raw

PATCH RESEND 1/1 au1xmmc.c: use resource_size()

From: H Hartley Sweeten <[email protected]>
Date: Mon, 14 Dec 2009 14:28:06 -0500

Use resource_size().

Signed-off-by H Hartley Sweeten <[email protected]>
[cjb: rebased patch against Linus]
Signed-off-by Chris Ball <[email protected]>
---
 drivers/mmc/host/au1xmmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/au1xmmc.c +1 -1
index c8da5d3..e14b866 100644
@@ -964,7 +964,7 @@ static int __devinit au1xmmc_probe(struct platform_device *pdev)
 		goto out1;
 	}
 
-	host->ioarea = request_mem_region(r->start, r->end - r->start + 1,
+	host->ioarea = request_mem_region(r->start, resource_size(r),
 					   pdev->name);
 	if (!host->ioarea) {
 		dev_err(&pdev->dev, "mmio already in use\n");
Signature · 5 lines
1.7.0.1

-- 
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
#2 lore raw

[Adding maintainer to CC]

Quoted 35 lines · Chris Ball

From: H Hartley Sweeten <[email protected]>
Date: Mon, 14 Dec 2009 14:28:06 -0500

Use resource_size().

Signed-off-by H Hartley Sweeten <[email protected]>
[cjb: rebased patch against Linus]
Signed-off-by Chris Ball <[email protected]>
---
 drivers/mmc/host/au1xmmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/au1xmmc.c +1 -1
index c8da5d3..e14b866 100644
@@ -964,7 +964,7 @@ static int __devinit au1xmmc_probe(struct platform_device *pdev)
 		goto out1;
 	}
 
-	host->ioarea = request_mem_region(r->start, r->end - r->start + 1,
+	host->ioarea = request_mem_region(r->start, resource_size(r),
 					   pdev->name);
 	if (!host->ioarea) {
 		dev_err(&pdev->dev, "mmio already in use\n");
Signature · 9 lines
1.7.0.1

-- 
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by
#3 lore raw
Quoted 23 lines · Matt Fleming

[Adding maintainer to CC]

Quoted 20 lines · Chris Ball

From: H Hartley Sweeten <[email protected]>
Date: Mon, 14 Dec 2009 14:28:06 -0500

Use resource_size().

Signed-off-by H Hartley Sweeten <[email protected]>
[cjb: rebased patch against Linus]
Signed-off-by Chris Ball <[email protected]>

---
 drivers/mmc/host/au1xmmc.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/au1xmmc.c +0 -0
index c8da5d3..e14b866 100644
@@ -964,7 +964,7 @@ static int __devinit au1xmmc_probe(struct platform_device *pdev)
               goto out1;
       }
Quoted 5 lines

drivers/mmc/host/au1xmmc.c static int __devinit au1xmmc_probe(struct platform_device *pdev) · line 970

Quoted 5 lines
drivers/mmc/host/au1xmmc.c +1 -1
-     host->ioarea = request_mem_region(r->start, r->end - r->start + 1,
+     host->ioarea = request_mem_region(r->start, resource_size(r),
                                          pdev->name);
       if (!host->ioarea) {
               dev_err(&pdev->dev, "mmio already in use\n");

Wasn't that posted ages ago? I'm fine with it.

Acked-by Manuel Lauss <[email protected]>
#4 lore raw
Quoted 2 lines · Manuel Lauss

Wasn't that posted ages ago? I'm fine with it.

Yep, but it never got merged.

Thanks for the ACK.