initialise DMA engine before MMC
Subsystems (2)
PATCH 1/1 initialise DMA engine before MMC
To use DMA engine based DMA with MMC in a non-modular build, the DMA engine has to initialise before MMC.
---
drivers/Makefile +1 -1
@@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/ obj-y += lguest/ obj-$(CONFIG_CPU_FREQ) += cpufreq/ obj-$(CONFIG_CPU_IDLE) += cpuidle/ +obj-$(CONFIG_DMA_ENGINE) += dma/ obj-$(CONFIG_MMC) += mmc/ obj-$(CONFIG_MEMSTICK) += memstick/ obj-$(CONFIG_NEW_LEDS) += leds/
@@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/ obj-$(CONFIG_SUPERH) += sh/ obj-$(CONFIG_ARCH_SHMOBILE) += sh/ obj-$(CONFIG_GENERIC_TIME) += clocksource/ -obj-$(CONFIG_DMA_ENGINE) += dma/ obj-$(CONFIG_DCA) += dca/ obj-$(CONFIG_HID) += hid/ obj-$(CONFIG_PPC_PS3) += ps3/
Quoted 4 lines · Guennadi Liakhovetski
To use DMA engine based DMA with MMC in a non-modular build, the DMA engine has to initialise before MMC.
Signed-off-by Guennadi Liakhovetski <[email protected]>
Dan, any objections to this?
Quoted 7 lines · Paul Mundt
Quoted 4 lines · Guennadi Liakhovetski
To use DMA engine based DMA with MMC in a non-modular build, the DMA engine has to initialise before MMC.
Signed-off-by Guennadi Liakhovetski <[email protected]>Dan, any objections to this?
No, objections, you can add my acked-by.
2010/6/7 Guennadi Liakhovetski <[email protected]>:
Quoted 18 lines
To use DMA engine based DMA with MMC in a non-modular build, the DMA engine has to initialise before MMC.
Signed-off-by Guennadi Liakhovetski <[email protected]>---
drivers/Makefile +0
-0@@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/obj-y += lguest/
obj-$(CONFIG_CPU_FREQ) += cpufreq/
obj-$(CONFIG_CPU_IDLE) += cpuidle/
+obj-$(CONFIG_DMA_ENGINE) += dma/
obj-$(CONFIG_MMC) += mmc/
obj-$(CONFIG_MEMSTICK) += memstick/
obj-$(CONFIG_NEW_LEDS) += leds/drivers/Makefile +0
-0@@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/
Quoted 7 lines
obj-$(CONFIG_SUPERH) += sh/
obj-$(CONFIG_ARCH_SHMOBILE) += sh/
obj-$(CONFIG_GENERIC_TIME) += clocksource/
-obj-$(CONFIG_DMA_ENGINE) += dma/
obj-$(CONFIG_DCA) += dca/
obj-$(CONFIG_HID) += hid/
obj-$(CONFIG_PPC_PS3) += ps3/
What I did was to move my DMA engines to subsystem_initcall(), with this approach I would have had to rearrange a lot of subsystems I think.
But if it's easier for you this way by all means do it.
Yours,
Linus Walleij
PATCH RESEND 1/1 initialise DMA engine before MMC
In reply to Guennadi LiakhovetskiHi,
Andrew, mind taking this one?
From: Guennadi Liakhovetski <[email protected]>
Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST)
To use DMA engine based DMA with MMC in a non-modular build, the DMA engine has to initialise before MMC.
---
drivers/Makefile +1 -1
@@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/ obj-y += lguest/ obj-$(CONFIG_CPU_FREQ) += cpufreq/ obj-$(CONFIG_CPU_IDLE) += cpuidle/ +obj-$(CONFIG_DMA_ENGINE) += dma/ obj-$(CONFIG_MMC) += mmc/ obj-$(CONFIG_MEMSTICK) += memstick/ obj-$(CONFIG_NEW_LEDS) += leds/
@@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/ obj-$(CONFIG_SUPERH) += sh/ obj-$(CONFIG_ARCH_SHMOBILE) += sh/ obj-$(CONFIG_GENERIC_TIME) += clocksource/ -obj-$(CONFIG_DMA_ENGINE) += dma/ obj-$(CONFIG_DCA) += dca/ obj-$(CONFIG_HID) += hid/ obj-$(CONFIG_PPC_PS3) += ps3/
--
Chris Ball <[email protected]> <http://printf.net/>
One Laptop Per Child
Quoted 26 lines · On Fri, 27 Aug 2010 20:49:39 +0100 Chris Ball <[email protected]> wrote:
Hi,
Andrew, mind taking this one?
From: Guennadi Liakhovetski <[email protected]>
Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST)To use DMA engine based DMA with MMC in a non-modular build, the DMA engine has to initialise before MMC.
Signed-off-by Guennadi Liakhovetski <[email protected]>Acked-by Dan Williams <[email protected]>---
drivers/Makefile +1
-0@@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/ obj-y += lguest/ obj-$(CONFIG_CPU_FREQ) += cpufreq/ obj-$(CONFIG_CPU_IDLE) += cpuidle/ +obj-$(CONFIG_DMA_ENGINE) += dma/ obj-$(CONFIG_MMC) += mmc/ obj-$(CONFIG_MEMSTICK) += memstick/ obj-$(CONFIG_NEW_LEDS) += leds/
drivers/Makefile obj-$(CONFIG_CRYPTO) += crypto/ · line 108
Quoted 7 lines
drivers/Makefile +0
-1@@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/ obj-$(CONFIG_SUPERH) += sh/ obj-$(CONFIG_ARCH_SHMOBILE) += sh/ obj-$(CONFIG_GENERIC_TIME) += clocksource/ -obj-$(CONFIG_DMA_ENGINE) += dma/ obj-$(CONFIG_DCA) += dca/ obj-$(CONFIG_HID) += hid/ obj-$(CONFIG_PPC_PS3) += ps3/
erk, doing this via link ordering isn't nice.
It would be better to express this dependency via initcall levels - core_initcall() or something.