APM82xxx: Add UIC support
PATCH 5/8 APM82xxx: Add UIC support
From: Tirumala Marri <[email protected]>
This patch adds Universal Interrupt Controller support for APM82XXX processor.
--- arch/powerpc/include/asm/ppc4xx-uic.h | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
arch/powerpc/include/asm/ppc4xx-uic.h +3 -2
@@ -31,7 +31,7 @@*/ #if defined(CONFIG_440GX ) || defined(CONFIG_440SPE ) || \ defined(CONFIG_460EX ) || defined(CONFIG_460GT ) || \ - defined(CONFIG_460SX ) + defined(CONFIG_460SX ) || defined(CONFIG_APM82XXX )#define UIC_MAX 4#elif defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) || \ defined(CONFIG_405EX )
@@ -252,7 +252,8 @@#define VECNUM_ETH0 (32 + 28)#endif /* CONFIG_440SPE */ -#if defined(CONFIG_460EX ) || defined(CONFIG_460GT ) +#if defined(CONFIG_460EX ) || defined(CONFIG_460GT ) ||\ + defined(CONFIG_APM82XXX )/* UIC 0 */ #define VECNUM_UIC2NCI 10#define VECNUM_UIC2CI 11
Signature · 1 line
1.6.1.rc3
PATCH 5/8 APM82xxx: Add UIC support
Hello.
Quoted 6 lines · tmarri at apm.com
From: Tirumala Marri <[email protected]>
This patch adds Universal Interrupt Controller support for APM82XXX processor.
Signed-off-by Tirumala R Marri <[email protected]>
[...]
Quoted 4 lines
arch/powerpc/include/asm/ppc4xx-uic.h +0
-0
[...]
arch/powerpc/include/asm/ppc4xx-uic.h line 255
Quoted 6 lines
arch/powerpc/include/asm/ppc4xx-uic.h +1
-1@@ -252,7 +252,8 @@#define VECNUM_ETH0 (32 + 28)#endif /* CONFIG_440SPE */ -#if defined(CONFIG_460EX ) || defined(CONFIG_460GT ) +#if defined(CONFIG_460EX) || defined(CONFIG_460GT) ||\
Please add space before \ to keep the style consistent.
arch/powerpc/include/asm/ppc4xx-uic.h line 256
Quoted 1 line
arch/powerpc/include/asm/ppc4xx-uic.h +1
-0+defined (CONFIG_APM82XXX )
WBR, Sergei
PATCH 5/8 APM82xxx: Add UIC support
Quoted 12 lines
Quoted 5 lines
This patch adds Universal Interrupt Controller support for APM82XXX processor.
Signed-off-by Tirumala R Marri <[email protected]>[...]
Review
Quoted 1 line
(quoted diff) +0
-0
b/arch/powerpc/include/asm/ppc4xx-uic.hQuoted 3 lines
index 782d045..238b70b 100644
arch/powerpc/include/asm/ppc4xx-uic.h +0
-0[...]
Quoted 8 lines
arch/powerpc/include/asm/ppc4xx-uic.h line 255
Quoted 6 lines
arch/powerpc/include/asm/ppc4xx-uic.h +1
-1@@ -252,7 +252,8 @@#define VECNUM_ETH0 (32 + 28)#endif /* CONFIG_440SPE */ -#if defined(CONFIG_460EX ) || defined(CONFIG_460GT ) +#if defined(CONFIG_460EX) || defined(CONFIG_460GT) ||\Please add space before \ to keep the style consistent.
[Marri] Sure will fix it.
Regards,
Marri
PATCH 5/8 APM82xxx: Add UIC support
In reply to tmarri at apm.comDear tmarri at apm.com,
Quoted 4 lines · In message <[email protected]> you wrote:
From: Tirumala Marri <[email protected]>
This patch adds Universal Interrupt Controller support for APM82XXX processor.
Again. This is NOT a separate, independent commit. Please reread the documentation andfix your patch splitting.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Vulcans never bluff. -- Spock, "The Doomsday Machine", stardate 4202.1
PATCH 5/8 APM82xxx: Add UIC support
Quoted 11 lines
-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Sunday, August 29, 2010 1:57 AM
To: tmarri at apm.com
Cc: u-boot at lists.denx.de; open-source-review at apm.com
Subject: Re: [U-Boot] [PATCH 5/8] APM82xxx: Add UIC supportDear tmarri at apm.com,
In message <[email protected]> you wrote:
Quoted 7 lines
Quoted 4 lines
From: Tirumala Marri <[email protected]>
This patch adds Universal Interrupt Controller support for APM82XXX processor.
Again. This is NOT a separate, independent commit. Please reread the documentation andfix your patch splitting.
Mr Wolfgang,
Sure will fix it.
Regards,
Marri