imported patch sync-no_cluster-with-cluster-flag.patch

PATCH In review Malahal Naineni 2 participants 3 messages Aug 29, 2010 – Nov 2, 2010

Subsystems (2)

SCSI Device mapper

lore

Share & tools

lore

Malahal Naineni

author

2010-08-29 17:59 UTC #0 lore raw

PATCH 1/1 imported patch sync-no_cluster-with-cluster-flag.patch

drivers/scsi/scsi_lib.c +3 -1

diff -r 8305d08f6ecf -r 5e7598cf7714 drivers/scsi/scsi_lib.c
@@ -1633,8 +1633,10 @@ struct request_queue *__scsi_alloc_queue
 	blk_queue_max_segment_size(q, dma_get_max_seg_size(dev));
 
 	/* New queue, no concurrency on queue_flags */
-	if (!shost->use_clustering)
+	if (!shost->use_clustering) {
 		queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q);
+		q->limits.no_cluster = 1;
+	}
 
 	/*
 	 * set a reasonable default alignment on word boundaries: the

Malahal Naineni

author

2010-08-29 20:31 UTC #1 lore raw

Re: [PATCH] block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync

Here is the missing header:

no_cluster is used by device mapper (may be others) resulting in multipath devices setting QUEUE_FLAG_CLUSTER flag even though the underlying devices (e.g. open iscsi virtual adapter) don't support it.

Signed-off-by Malahal Naineni ([email protected])

Quoted 20 lines · Malahal Naineni [[email protected]] wrote:

diff -r 8305d08f6ecf -r 5e7598cf7714 drivers/scsi/scsi_lib.c

drivers/scsi/scsi_lib.c +3 -2

@@ -1633,8 +1633,10 @@ struct request_queue *__scsi_alloc_queue
 	blk_queue_max_segment_size(q, dma_get_max_seg_size(dev));
 
 	/* New queue, no concurrency on queue_flags */
-	if (!shost->use_clustering)
+	if (!shost->use_clustering) {
 		queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q);
+		q->limits.no_cluster = 1;
+	}
 
 	/*
 	 * set a reasonable default alignment on word boundaries: the
 
--

dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel

Mike Snitzer

2010-11-02 20:21 UTC #2 lore raw

Re: block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync

Malahal,

This patch should go through the scsi tree. Please update the patch (so it includes the patch header) and repost to linux-scsi.

Thanks,
Mike

Quoted 34 lines · Malahal Naineni

Here is the missing header:
no_cluster is used by device mapper (may be others) resulting in multipath devices setting QUEUE_FLAG_CLUSTER flag even though the underlying devices (e.g. open iscsi virtual adapter) don't support it.
Signed-off-by Malahal Naineni ([email protected])
Quoted 17 lines · Malahal Naineni [[email protected]] wrote:
diff -r 8305d08f6ecf -r 5e7598cf7714 drivers/scsi/scsi_lib.c
drivers/scsi/scsi_lib.c +3 -2
@@ -1633,8 +1633,10 @@ struct request_queue *__scsi_alloc_queue
 	blk_queue_max_segment_size(q, dma_get_max_seg_size(dev));
 
 	/* New queue, no concurrency on queue_flags */
-	if (!shost->use_clustering)
+	if (!shost->use_clustering) {
 		queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q);
+		q->limits.no_cluster = 1;
+	}
 
 	/*
 	 * set a reasonable default alignment on word boundaries: the
 
--
Quoted 3 lines
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel
--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel