Skip to contentSkip to conversation

fix pic migration

PATCH Applied Gleb Natapov 2 participants 2 messages Aug 30, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix pic migration

Top of kvm_kpic_state structure should have the same memory layout as kvm_pic_state since it is copied by memcpy.

arch/x86/kvm/irq.h +1 -1
index ffed068..63c3145 100644
@@ -43,7 +43,6 @@ struct kvm_kpic_state {
 	u8 irr;		/* interrupt request register */
 	u8 imr;		/* interrupt mask register */
 	u8 isr;		/* interrupt service register */
-	u8 isr_ack;	/* interrupt ack detection */
 	u8 priority_add;	/* highest irq priority */
 	u8 irq_base;
 	u8 read_reg_select;
@@ -56,6 +55,7 @@ struct kvm_kpic_state {
 	u8 init4;		/* true if 4 byte init */
 	u8 elcr;		/* PIIX edge/trigger selection */
 	u8 elcr_mask;
+	u8 isr_ack;	/* interrupt ack detection */
 	struct kvm_pic *pics_state;
 };
 

--
Gleb.

Applied
#1 lore raw
Quoted 2 lines · Gleb Natapov

Top of kvm_kpic_state structure should have the same memory layout as kvm_pic_state since it is copied by memcpy.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function