carl9170usb: Makefile, Kconfig files and MAINTAINERS

PATCH In review Christian Lamparter 2 participants 3 messages Aug 30, 2010

Subsystems (2)

Atheros ath generic utilities CARL9170 Linux community wireless driver

lore

Share & tools

lore

Christian Lamparter

author maintainer

2010-08-30 20:43 UTC #0 lore raw

PATCH 6/6 carl9170usb: Makefile, Kconfig files and MAINTAINERS

Signed-off-by Christian Lamparter <[email protected]>

---
 MAINTAINERS                                |    1 +
 drivers/net/wireless/ath/Kconfig           |    1 +
 drivers/net/wireless/ath/Makefile          |    1 +
 drivers/net/wireless/ath/carl9170/Kconfig  |   37 ++++++++++++++++++++++++++++
 drivers/net/wireless/ath/carl9170/Makefile |    4 +++
 5 files changed, 44 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/wireless/ath/carl9170/Kconfig
 create mode 100644 drivers/net/wireless/ath/carl9170/Makefile

MAINTAINERS +1 -0

index 63e441b..1f10089 100644
@@ -1119,6 +1119,7 @@ L:	[email protected]
 W:	http://wireless.kernel.org/en/users/Drivers/ar9170
 S:	Maintained
 F:	drivers/net/wireless/ath/ar9170/
+F:	drivers/net/wireless/ath/carl9170/
 
 ATK0110 HWMON DRIVER
 M:	Luca Tettamanti <[email protected]>

drivers/net/wireless/ath/Kconfig +1 -0

index 0a75be0..92c2162 100644
@@ -25,5 +25,6 @@ config ATH_DEBUG
 source "drivers/net/wireless/ath/ath5k/Kconfig"
 source "drivers/net/wireless/ath/ath9k/Kconfig"
 source "drivers/net/wireless/ath/ar9170/Kconfig"
+source "drivers/net/wireless/ath/carl9170/Kconfig"
 
 endif

drivers/net/wireless/ath/Makefile +1 -0

index 8113a50..75c372b 100644
@@ -1,6 +1,7 @@
 obj-$(CONFIG_ATH5K)		+= ath5k/
 obj-$(CONFIG_ATH9K_HW)		+= ath9k/
 obj-$(CONFIG_AR9170_USB)        += ar9170/
+obj-$(CONFIG_CARL9170_USB)        += carl9170/
 
 obj-$(CONFIG_ATH_COMMON)	+= ath.o

drivers/net/wireless/ath/carl9170/Kconfig new file +37 -0

new file mode 100644
index 0000000..cd3815a
@@ -0,0 +1,37 @@
+config CARL9170_USB
+	tristate "Community Driver for Atheros AR9170 802.11n USB support"
+	depends on USB && MAC80211 && EXPERIMENTAL
+	select FW_LOADER
+	help
+	  This is another driver for the Atheros "otus" 802.11n USB devices.
+
+	  This driver provides more features than the original,
+	  but it needs a special firmware (carl9170-1.fw) to do that.
+
+	  The firmware can be downloaded from here:
+
+	  http://wireless.kernel.org/en/users/Drivers/carl9170
+
+	  If you choose to build a module, it'll be called carl9170usb.
+
+config CARL9170_LEDS
+	bool "LED Support"
+	depends on CARL9170_USB && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = CARL9170_USB)
+	default y
+	help
+	  This option is necessary, if you want your device' LEDs to blink
+
+	  Say Y, unless you need the LEDs for firmware debugging.
+
+config CARL9170_DEBUGFS
+	bool "Debugging (DebugFS) Support"
+	depends on CARL9170_USB && MAC80211_DEBUGFS
+	default y
+	help
+	  Say Y, if you need access to carl9170usb's statistics for
+	  QoS queue status, rate control, etc.
+
+config CARL9170_WPS_BUTTON
+	bool
+	depends on CARL9170_USB && (INPUT = y || INPUT = CARL9170_USB)
+	default y

drivers/net/wireless/ath/carl9170/Makefile new file +4 -0

new file mode 100644
index 0000000..2fba020
@@ -0,0 +1,4 @@
+carl9170usb-objs := main.o usb.o cmd.o mac.o phy.o led.o fw.o tx.o rx.o
+carl9170usb-$(CONFIG_CARL9170_DEBUGFS) += debug.o
+
+obj-$(CONFIG_CARL9170_USB) += carl9170usb.o

Signature · 1 line

1.7.1

Julian Calaby

2010-08-30 22:46 UTC #1 lore raw

Christian,

Minor, *minor* nit.

Quoted 10 lines · Christian Lamparter

MAINTAINERS +0 -0
index 63e441b..1f10089 100644
@@ -1119,6 +1119,7 @@ L:        [email protected]
W: http://wireless.kernel.org/en/users/Drivers/ar9170
S: Maintained
F: drivers/net/wireless/ath/ar9170/
+F: drivers/net/wireless/ath/carl9170/

Quoted 2 lines

ATK0110 HWMON DRIVER
M: Luca Tettamanti <[email protected]>

As carl9170 has a separate website, would it make sense for it to also have a separate MAINTAINERS entry?

Also, patch 1/6 is signed off by root, you may want to fix that.

Thanks,

Signature · 5 lines

Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/

Christian Lamparter

author maintainer

2010-08-30 23:21 UTC #2 lore raw

Quoted 12 lines · On Tuesday 31 August 2010 00:45:42 Julian Calaby wrote:

Quoted 10 lines · Christian Lamparter

MAINTAINERS +1 -0

index 63e441b..1f10089 100644
@@ -1119,6 +1119,7 @@ L:        [email protected]
 W:     http://wireless.kernel.org/en/users/Drivers/ar9170
 S:     Maintained
 F:     drivers/net/wireless/ath/ar9170/
+F:     drivers/net/wireless/ath/carl9170/

Quoted 5 lines

MAINTAINERS L: [email protected] · line 1125
Quoted 2 lines
MAINTAINERS +0 -0
 ATK0110 HWMON DRIVER
 M:     Luca Tettamanti <[email protected]>
As carl9170 has a separate website, would it make sense for it to also have a separate MAINTAINERS entry?

On one hand the driver is based on ar9170 and uses the same device, but having an separate entry might be favorable when ar9170usb is dropped...

Quoted 1 line

Also, patch 1/6 is signed off by root, you may want to fix that.

Thanks!

---

By the way:

ALL COMPAT-WIRELESS USERS WITH OLDER KERNELS (older than 2.6.36-rc1, 2.6.35.2, etc...) have to apply this patch:

Quoted 1 line

https://patchwork.kernel.org/patch/118946/

(Or, suffer from panics.)