Skip to contentSkip to conversation

edac: make inst_grp_ops const

PATCH In review Stephen Hemminger 3 participants 4 messages Aug 31, 2010 – Sep 1, 2010 EDAC-core

lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 edac: make inst_grp_ops const

This sysfs_ops should be const like all the others in the kernel.

Signed-off-by Stephen Hemminger <[email protected]>
drivers/edac/edac_mc_sysfs.c +1 -1
@@ -764,7 +764,7 @@ static void edac_inst_grp_release(struct
 }
 
 /* Intermediate show/store table */
-static struct sysfs_ops inst_grp_ops = {
+static const struct sysfs_ops inst_grp_ops = {
 	.show = inst_grp_show,
 	.store = inst_grp_store
 };

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev

Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Stephen Hemminger

From: Stephen Hemminger <[email protected]>
Subject: [PATCH] edac: make inst_grp_ops const
To: "Doug Thompson" <[email protected]>, "Mauro Carvalho Chehab" <[email protected]>, [email protected]
Date: Tuesday, August 31, 2010, 4:24 PM
This sysfs_ops should be const like
all the others in the kernel.

Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Doug Thompson <[email protected]>
Quoted 11 lines

--- a/drivers/edac/edac_mc_sysfs.c

2010-08-31 15:10:29.692381171 -0700
+++ b/drivers/edac/edac_mc_sysfs.c   
2010-08-31 15:11:24.072859199 -0700
(quoted diff) +0 -0
@@ -764,7 +764,7 @@ static void

edac_inst_grp_release(struct
}

/* Intermediate show/store table */

drivers/edac/edac_mc_sysfs.c static void edac_inst_grp_release(struct · line 770

Quoted 5 lines
drivers/edac/edac_mc_sysfs.c +1 -1
-static struct sysfs_ops inst_grp_ops = {
+static const struct sysfs_ops inst_grp_ops = {
     .show = inst_grp_show,
     .store = inst_grp_store
 };

------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd

#2 lore raw
In reply to Stephen Hemminger

Ignore that prior ack by me, I thought it was an i7core_edac module, not core EDAC modules.

I will take it myself and push it upstream

doug t

Quoted 19 lines · Stephen Hemminger

From: Stephen Hemminger <[email protected]>
Subject: [PATCH] edac: make inst_grp_ops const
To: "Doug Thompson" <[email protected]>, "Mauro Carvalho Chehab" <[email protected]>, [email protected]
Date: Tuesday, August 31, 2010, 4:24 PM
This sysfs_ops should be const like
all the others in the kernel.

Signed-off-by Stephen Hemminger <[email protected]>

--- a/drivers/edac/edac_mc_sysfs.c

2010-08-31 15:10:29.692381171 -0700
+++ b/drivers/edac/edac_mc_sysfs.c   
2010-08-31 15:11:24.072859199 -0700
(quoted diff) +0 -0
@@ -764,7 +764,7 @@ static void

edac_inst_grp_release(struct
}

/* Intermediate show/store table */

drivers/edac/edac_mc_sysfs.c static void edac_inst_grp_release(struct · line 770

Quoted 5 lines
drivers/edac/edac_mc_sysfs.c +1 -1
-static struct sysfs_ops inst_grp_ops = {
+static const struct sysfs_ops inst_grp_ops = {
     .show = inst_grp_show,
     .store = inst_grp_store
 };

------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd

#3 lore raw

Doug,

Em 31-08-2010 20:00, Doug Thompson escreveu:

Quoted 4 lines

Ignore that prior ack by me, I thought it was an i7core_edac module, not core EDAC modules.

I will take it myself and push it upstream

Please take a look first on my patch series. I've did lots of "const" cleanups on my patch series, changing them on both i7core_edac and edac core.

I'm currently traveling, due to LinuxCon Brazil, but it is very likely that this patch will conflict with one big patch I've made.

Cheers,
Mauro.

------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd